linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: linux-zigbee-devel@lists.sourceforge.net
Cc: werner@almesberger.net, linux-bluetooth@vger.kernel.org,
	Alexander Aring <alex.aring@gmail.com>
Subject: [PATCH v3 bluetooth-next 5/8] 6lowpan: add udp warning for elided checksum
Date: Tue, 17 Dec 2013 14:21:25 +0100	[thread overview]
Message-ID: <1387286488-29382-6-git-send-email-alex.aring@gmail.com> (raw)
In-Reply-To: <1387286488-29382-1-git-send-email-alex.aring@gmail.com>

Bit 5 of "UDP LOWPAN_NHC Format" indicate that the checksum can be
elided.
The host need to calculate the udp checksum afterwards but this isn't
supported right now.

See:
http://tools.ietf.org/html/rfc6282#section-4.3.3
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
 net/ieee802154/6lowpan.h      |  1 +
 net/ieee802154/6lowpan_iphc.c | 11 ++++++++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/net/ieee802154/6lowpan.h b/net/ieee802154/6lowpan.h
index 4981bf8..2b835db 100644
--- a/net/ieee802154/6lowpan.h
+++ b/net/ieee802154/6lowpan.h
@@ -231,6 +231,7 @@
 #define LOWPAN_NHC_UDP_CS_P_10	0xF2 /* source = 0xF0 + 8bit inline,
 					dest = 16 bit inline */
 #define LOWPAN_NHC_UDP_CS_P_11	0xF3 /* source & dest = 0xF0B + 4bit inline */
+#define LOWPAN_NHC_UDP_CS_C	0x04 /* checksum elided */
 
 #ifdef DEBUG
 /* print data in line */
diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c
index 02bf74d..a70fa66 100644
--- a/net/ieee802154/6lowpan_iphc.c
+++ b/net/ieee802154/6lowpan_iphc.c
@@ -309,9 +309,14 @@ uncompress_udp_header(struct sk_buff *skb, struct udphdr *uh)
 		pr_debug("uncompressed UDP ports: src = %d, dst = %d\n",
 			 ntohs(uh->source), ntohs(uh->dest));
 
-		/* copy checksum */
-		memcpy(&uh->check, &skb->data[0], 2);
-		skb_pull(skb, 2);
+		/* checksum */
+		if (tmp & LOWPAN_NHC_UDP_CS_C) {
+			pr_debug_ratelimited("checksum elided currently not supported\n");
+			goto err;
+		} else {
+			memcpy(&uh->check, &skb->data[0], 2);
+			skb_pull(skb, 2);
+		}
 
 		/*
 		 * UDP lenght needs to be infered from the lower layers
-- 
1.8.5.1


  parent reply	other threads:[~2013-12-17 13:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 13:21 [PATCH v3 bluetooth-next 0/8] 6lowpan: udp compression/uncompression fix Alexander Aring
2013-12-17 13:21 ` [PATCH v3 bluetooth-next 1/8] 6lowpan: introduce lowpan_push_hc_data function Alexander Aring
2013-12-17 13:21 ` [PATCH v3 bluetooth-next 2/8] 6lowpan: udp use " Alexander Aring
2013-12-17 13:21 ` [PATCH v3 bluetooth-next 3/8] 6lowpan: fix udp compress ordering Alexander Aring
2013-12-17 13:21 ` [PATCH v3 bluetooth-next 4/8] 6lowpan: fix udp byte ordering Alexander Aring
2013-12-17 13:21 ` Alexander Aring [this message]
2013-12-17 13:21 ` [PATCH v3 bluetooth-next 6/8] 6lowpan: udp use lowpan_fetch_skb function Alexander Aring
2013-12-17 13:21 ` [PATCH v3 bluetooth-next 7/8] 6lowpan: udp use subtraction on both conditions Alexander Aring
2013-12-17 13:21 ` [PATCH v3 bluetooth-next 8/8] 6lowpan: cleanup udp compress function Alexander Aring
2013-12-17 14:18 ` [PATCH v3 bluetooth-next 0/8] 6lowpan: udp compression/uncompression fix Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387286488-29382-6-git-send-email-alex.aring@gmail.com \
    --to=alex.aring@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-zigbee-devel@lists.sourceforge.net \
    --cc=werner@almesberger.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).