From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 4/4] android/A2DP: Fix disconnecting after AVDTP session creation
Date: Thu, 19 Dec 2013 17:15:56 +0200 [thread overview]
Message-ID: <1387466156-14100-4-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1387466156-14100-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Once the connection is handover to AVDTP code the GIOChannel can be
unref but it should not close the connection.
---
android/a2dp.c | 25 ++++++++++++++++++-------
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/android/a2dp.c b/android/a2dp.c
index 2de2f66..9087c62 100644
--- a/android/a2dp.c
+++ b/android/a2dp.c
@@ -73,8 +73,10 @@ static void a2dp_device_free(struct a2dp_device *dev)
if (dev->session)
avdtp_unref(dev->session);
- if (dev->io)
+ if (dev->io) {
+ g_io_channel_shutdown(dev->io, FALSE, NULL);
g_io_channel_unref(dev->io);
+ }
devices = g_slist_remove(devices, dev);
g_free(dev);
@@ -148,11 +150,18 @@ static void signaling_connect_cb(GIOChannel *chan, GError *err,
return;
}
- /* FIXME: Add proper version */
+ g_io_channel_set_close_on_unref(chan, FALSE);
fd = g_io_channel_unix_get_fd(chan);
+
+ /* FIXME: Add proper version */
dev->session = avdtp_new(fd, imtu, omtu, 0x0100);
avdtp_add_disconnect_cb(dev->session, disconnect_cb, dev);
+ if (dev->io) {
+ g_io_channel_unref(dev->io);
+ dev->io = NULL;
+ }
+
bt_a2dp_notify_state(dev, HAL_A2DP_STATE_CONNECTED);
}
@@ -221,15 +230,17 @@ static void bt_a2dp_disconnect(const void *buf, uint16_t len)
}
dev = l->data;
+ status = HAL_STATUS_SUCCESS;
- /* Wait signaling channel to HUP */
- if (dev->io)
- g_io_channel_shutdown(dev->io, TRUE, NULL);
+ if (dev->io) {
+ bt_a2dp_notify_state(dev, HAL_A2DP_STATE_DISCONNECTED);
+ goto failed;
+ }
+ /* Wait AVDTP session to shutdown */
+ avdtp_shutdown(dev->session);
bt_a2dp_notify_state(dev, HAL_A2DP_STATE_DISCONNECTING);
- status = HAL_STATUS_SUCCESS;
-
failed:
ipc_send_rsp(HAL_SERVICE_ID_A2DP, HAL_OP_A2DP_DISCONNECT, status);
}
--
1.8.3.1
next prev parent reply other threads:[~2013-12-19 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 15:15 [PATCH BlueZ 1/4] android/AVDTP: Add avdtp_add_disconnect_cb and avdtp_remove_disconnect_cb Luiz Augusto von Dentz
2013-12-19 15:15 ` [PATCH BlueZ 2/4] android/A2DP: Use avdtp_add_disconnect_cb to cleanup on disconnect Luiz Augusto von Dentz
2013-12-19 15:15 ` [PATCH BlueZ 3/4] android/AVDTP: Add avdtp_shutdown Luiz Augusto von Dentz
2013-12-19 15:15 ` Luiz Augusto von Dentz [this message]
2013-12-20 7:28 ` [PATCH BlueZ 1/4] android/AVDTP: Add avdtp_add_disconnect_cb and avdtp_remove_disconnect_cb Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387466156-14100-4-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox