From: Szymon Janc <szymon.janc@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Szymon Janc <szymon.janc@gmail.com>
Subject: [PATCH 5/7] android/haltest: Improve EXEC macro robustness
Date: Mon, 30 Dec 2013 23:43:39 +0100 [thread overview]
Message-ID: <1388443421-6295-5-git-send-email-szymon.janc@gmail.com> (raw)
In-Reply-To: <1388443421-6295-1-git-send-email-szymon.janc@gmail.com>
Print info about method being NULL instead of crashing.
---
android/client/if-main.h | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/android/client/if-main.h b/android/client/if-main.h
index a83f48b..4a5d4cc 100644
--- a/android/client/if-main.h
+++ b/android/client/if-main.h
@@ -147,8 +147,12 @@ const struct method *get_interface_method(const char *iname,
/* Helper macro for executing function on interface and printing BT_STATUS */
#define EXEC(f, ...) \
{ \
- int err = f(__VA_ARGS__); \
- haltest_info("%s: %s\n", #f, bt_status_t2str(err)); \
+ if (f) { \
+ int err = f(__VA_ARGS__); \
+ haltest_info("%s: %s\n", #f, bt_status_t2str(err)); \
+ } else { \
+ haltest_info("%s is NULL\n", #f); \
+ } \
}
/* Helper macro for executing void function on interface */
--
1.8.5.2
next prev parent reply other threads:[~2013-12-30 22:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 22:43 [PATCH 1/7] android: Add HCI snooping tool Szymon Janc
2013-12-30 22:43 ` [PATCH 2/7] android/hal-bluetooth: Update snoop service name Szymon Janc
2013-12-30 22:43 ` [PATCH 3/7] android: Add support for bluetoothd-snoop service in system-emulator Szymon Janc
2013-12-30 22:43 ` [PATCH 4/7] android/hal-bluetooth: Add debug print to config_hci_snoop_log Szymon Janc
2013-12-30 22:43 ` Szymon Janc [this message]
2013-12-30 22:43 ` [PATCH 6/7] android/haltest: Implement missing functions from bluetooth HAL Szymon Janc
2013-12-30 22:43 ` [PATCH 7/7] android/build: Fix building HAL library on Linux Szymon Janc
2014-01-01 16:30 ` [PATCH 1/7] android: Add HCI snooping tool Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388443421-6295-5-git-send-email-szymon.janc@gmail.com \
--to=szymon.janc@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox