Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Bastien Nocera <hadess@hadess.net>, Szymon Janc <szymon.janc@gmail.com>
Subject: [PATCH 1/7] sixaxis: Don't mark USB plugged device as trusted
Date: Wed,  8 Jan 2014 01:02:22 +0100	[thread overview]
Message-ID: <1389139348-3552-2-git-send-email-szymon.janc@gmail.com> (raw)
In-Reply-To: <1389139348-3552-1-git-send-email-szymon.janc@gmail.com>

There were some valid conserns raised against marking plugged device
as trusted. Mainly due to posibility of crafted USB device. With this
patch user will be asked to confirm service connection and device can
be marked as trusted like any other devices.
---
 plugins/sixaxis.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
index 1154c15..4fdeff3 100644
--- a/plugins/sixaxis.c
+++ b/plugins/sixaxis.c
@@ -228,7 +228,6 @@ static bool setup_device(int fd, int index, struct btd_adapter *adapter)
 	btd_device_set_pnpid(device, devices[index].source, devices[index].vid,
 				devices[index].pid, devices[index].version);
 	btd_device_set_temporary(device, FALSE);
-	btd_device_set_trusted(device, TRUE);
 
 	return true;
 }
-- 
1.8.5.2


  reply	other threads:[~2014-01-08  0:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08  0:02 [PATCH 0/7] sixaxis: Don't mark USB plugged device as trusted Szymon Janc
2014-01-08  0:02 ` Szymon Janc [this message]
2014-01-08  0:02 ` [PATCH 2/7] input: Fix crash on authorization reply with first sixaxis connection Szymon Janc
2014-01-08  0:02 ` [PATCH 3/7] input: Fix check if device is sixaxis in auth_callback Szymon Janc
2014-01-08  0:02 ` [PATCH 4/7] input: Fix connecting new trusted sixaxis device Szymon Janc
2014-01-08  0:02 ` [PATCH 5/7] client: Add untrust command Szymon Janc
2014-01-08  0:02 ` [PATCH 6/7] client: Add block command Szymon Janc
2014-01-08  0:02 ` [PATCH 7/7] client: Add unblock command Szymon Janc
2014-01-09 15:57 ` [PATCH 0/7] sixaxis: Don't mark USB plugged device as trusted Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389139348-3552-2-git-send-email-szymon.janc@gmail.com \
    --to=szymon.janc@gmail.com \
    --cc=hadess@hadess.net \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox