From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 2/2] android/ipc: Leave the connect callback to handle errors
Date: Tue, 21 Jan 2014 16:00:59 +0200 [thread overview]
Message-ID: <1390312859-27349-2-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1390312859-27349-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
It is not necessary to check connect errors since there is a watch
created for that.
---
android/ipc.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/android/ipc.c b/android/ipc.c
index 8098409..4f2428c 100644
--- a/android/ipc.c
+++ b/android/ipc.c
@@ -166,12 +166,7 @@ GIOChannel *ipc_connect(const char *path, size_t size, GIOFunc connect_cb,
memcpy(addr.sun_path, path, size);
- if (connect(sk, (struct sockaddr *) &addr, sizeof(addr)) < 0) {
- error("IPC: failed to connect HAL socket %s: %d (%s)", &path[1],
- errno, strerror(errno));
- g_io_channel_unref(io);
- return NULL;
- }
+ connect(sk, (struct sockaddr *) &addr, sizeof(addr));
cond = G_IO_OUT | G_IO_ERR | G_IO_HUP | G_IO_NVAL;
--
1.8.4.2
next prev parent reply other threads:[~2014-01-21 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 14:00 [PATCH BlueZ 1/2] android/A2DP: Add retry logic to Audio IPC Luiz Augusto von Dentz
2014-01-21 14:00 ` Luiz Augusto von Dentz [this message]
2014-01-21 15:24 ` Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390312859-27349-2-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox