From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 3/4] audio/AVRCP: Fix not setting playable flag for folder
Date: Thu, 30 Jan 2014 15:03:27 -0800 [thread overview]
Message-ID: <1391123008-26767-3-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1391123008-26767-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
When listing items some folders may be set as playable but the code was
ignoring it making it impossible to play any folder.
---
profiles/audio/avrcp.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index 2cf6b41..ac861d2 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -2141,16 +2141,19 @@ static struct media_item *parse_media_folder(struct avrcp *session,
{
struct avrcp_player *player = session->controller->player;
struct media_player *mp = player->user_data;
+ struct media_item *item;
uint16_t namelen;
char name[255];
uint64_t uid;
uint8_t type;
+ uint8_t playable;
if (len < 12)
return NULL;
uid = bt_get_be64(&operands[0]);
type = operands[8];
+ playable = operands[9];
namelen = MIN(bt_get_be16(&operands[12]), sizeof(name) - 1);
if (namelen > 0) {
@@ -2158,7 +2161,13 @@ static struct media_item *parse_media_folder(struct avrcp *session,
name[namelen] = '\0';
}
- return media_player_create_folder(mp, name, type, uid);
+ item = media_player_create_folder(mp, name, type, uid);
+ if (!item)
+ return NULL;
+
+ media_item_set_playable(item, playable & 0x01);
+
+ return item;
}
static void avrcp_list_items(struct avrcp *session, uint32_t start,
--
1.8.4.2
next prev parent reply other threads:[~2014-01-30 23:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 23:03 [PATCH BlueZ 1/4] audio/player: Fix using invalid end index Luiz Augusto von Dentz
2014-01-30 23:03 ` [PATCH BlueZ 2/4] audio/AVRCP: Fix using the wrong octet for folder type Luiz Augusto von Dentz
2014-01-30 23:03 ` Luiz Augusto von Dentz [this message]
2014-01-30 23:03 ` [PATCH BlueZ 4/4] audio/AVRCP: Fix coding style Luiz Augusto von Dentz
2014-01-31 7:55 ` Andrei Emeltchenko
2014-01-31 17:14 ` Luiz Augusto von Dentz
2014-02-02 15:40 ` [PATCH BlueZ 1/4] audio/player: Fix using invalid end index Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391123008-26767-3-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox