From: johan.hedberg@gmail.com
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 6/7] Bluetooth: Don't clear HCI_ADVERTISING when powering off
Date: Mon, 24 Feb 2014 14:52:21 +0200 [thread overview]
Message-ID: <1393246342-27980-7-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1393246342-27980-1-git-send-email-johan.hedberg@gmail.com>
From: Johan Hedberg <johan.hedberg@intel.com>
Once mgmt_set_powered(off) is updated to clear the scan mode we should
not just blindly clear the HCI_ADVERTISING flag in mgmt_advertising()
but first check if there is a pending set_powered operation.
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
net/bluetooth/mgmt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 5899ac7264ff..610ac32e797b 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -4842,6 +4842,10 @@ void mgmt_connectable(struct hci_dev *hdev, u8 connectable)
void mgmt_advertising(struct hci_dev *hdev, u8 advertising)
{
+ /* Powering off may stop advertising - don't let that interfere */
+ if (!advertising && mgmt_pending_find(MGMT_OP_SET_POWERED, hdev))
+ return;
+
if (advertising)
set_bit(HCI_ADVERTISING, &hdev->dev_flags);
else
--
1.8.5.3
next prev parent reply other threads:[~2014-02-24 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 12:52 [PATCH 0/7] Bluetooth: Graceful power off procedure johan.hedberg
2014-02-24 12:52 ` [PATCH 1/7] Bluetooth: Add convenience function for getting total connection count johan.hedberg
2014-02-24 12:52 ` [PATCH 2/7] Bluetooth: Move HCI_ADVERTISING handling into mgmt.c johan.hedberg
2014-02-24 12:52 ` [PATCH 3/7] Bluetooth: Move check for MGMT_CONNECTED flag " johan.hedberg
2014-02-24 12:52 ` [PATCH 4/7] Bluetooth: Don't clear HCI_DISCOVERABLE when powering off johan.hedberg
2014-02-24 12:52 ` [PATCH 5/7] Bluetooth: Don't clear HCI_CONNECTABLE " johan.hedberg
2014-02-24 12:52 ` johan.hedberg [this message]
2014-02-24 12:52 ` [PATCH 7/7] Bluetooth: Clean up HCI state when doing power off johan.hedberg
2014-02-24 19:12 ` [PATCH 0/7] Bluetooth: Graceful power off procedure Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393246342-27980-7-git-send-email-johan.hedberg@gmail.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox