From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCHv2 4/9] avrcp: Fix buffer size check
Date: Fri, 28 Feb 2014 16:18:40 +0200 [thread overview]
Message-ID: <1393597125-18176-4-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1393597125-18176-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Fix size check taking into account that attributes starts from 1 (0 is
illegal).
---
profiles/audio/avrcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index c0e5d07..48c3355 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -1909,7 +1909,7 @@ static void avrcp_get_current_player_value(struct avrcp *session,
struct avrcp_header *pdu = (void *) buf;
uint16_t length = AVRCP_HEADER_LENGTH + count + 1;
- if (count > AVRCP_ATTRIBUTE_LAST + 1)
+ if (count > AVRCP_ATTRIBUTE_LAST)
return;
memset(buf, 0, sizeof(buf));
--
1.8.3.2
next prev parent reply other threads:[~2014-02-28 14:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 14:18 [PATCHv2 1/9] unit/avrcp: Add /TP/PAS/BV-06-C test Andrei Emeltchenko
2014-02-28 14:18 ` [PATCHv2 2/9] doc: Update test coverage document Andrei Emeltchenko
2014-02-28 14:18 ` [PATCHv2 3/9] unit/avrcp: Add /TP/PAS/BV-08-C test Andrei Emeltchenko
2014-02-28 14:18 ` Andrei Emeltchenko [this message]
2014-02-28 14:26 ` [PATCHv2 4/9] avrcp: Fix buffer size check Luiz Augusto von Dentz
2014-02-28 14:18 ` [PATCHv2 5/9] android/avrcp: Add avrcp_get_current_player_value() function Andrei Emeltchenko
2014-02-28 14:18 ` [PATCHv2 6/9] unit/avrcp: Add /TP/PAS/BV-09-C test Andrei Emeltchenko
2014-02-28 14:18 ` [PATCHv2 7/9] unit/avrcp: Add /TP/PAS/BV-10-C test Andrei Emeltchenko
2014-02-28 14:18 ` [PATCHv2 8/9] android/avrcp: Add avrcp_set_player_value() function Andrei Emeltchenko
2014-02-28 14:18 ` [PATCHv2 9/9] unit/avrcp: Add /TP/PAS/BV-11-C test Andrei Emeltchenko
2014-02-28 14:28 ` [PATCHv2 1/9] unit/avrcp: Add /TP/PAS/BV-06-C test Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393597125-18176-4-git-send-email-Andrei.Emeltchenko.news@gmail.com \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox