Linux bluetooth development
 help / color / mirror / Atom feed
From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCHv2 09/10] unit/avrcp: Add /TP/PAS/BI-01-C test
Date: Tue,  4 Mar 2014 16:02:14 +0200	[thread overview]
Message-ID: <1393941735-12187-10-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1393941735-12187-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Test verifies that Get player app setting attribute text returns error
given invalid attribute id.
---
 unit/test-avrcp.c | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/unit/test-avrcp.c b/unit/test-avrcp.c
index 6999d22..803dd6b 100644
--- a/unit/test-avrcp.c
+++ b/unit/test-avrcp.c
@@ -326,7 +326,16 @@ static ssize_t avrcp_handle_get_player_attr_text(struct avrcp *session,
 						uint8_t *params,
 						void *user_data)
 {
-	DBG("");
+	int i;
+
+	DBG("params[0] %d params_len %d", params[0], params_len);
+
+	for (i = 1; i <= params[0]; i++) {
+		DBG("params[%d] = 0x%02x", i, params[i]);
+		if (params[i] > AVRCP_ATTRIBUTE_LAST ||
+			params[i] == AVRCP_ATTRIBUTE_ILEGAL)
+			return -EINVAL;
+	}
 
 	params[0] = 0;
 
@@ -633,5 +642,18 @@ int main(int argc, char *argv[])
 				AVRCP_ATTRIBUTE_EQUALIZER, 0xaa,
 				AVRCP_ATTRIBUTE_REPEAT_MODE, 0xff));
 
+	/* Get player app setting attribute text invalid behavior - TG */
+	define_test("/TP/PAS/BI-01-C", test_server,
+			raw_pdu(0x00, 0x11, 0x0e, 0x01, 0x48, 0x00,
+				0x00, 0x19, 0x58,
+				AVRCP_GET_PLAYER_ATTRIBUTE_TEXT,
+				0x00, 0x00, 0x02, 0x01,
+				/* Invalid attribute id */
+				0x7f),
+			raw_pdu(0x02, 0x11, 0x0e, AVC_CTYPE_REJECTED,
+				0x48, 0x00, 0x00, 0x19, 0x58,
+				AVRCP_GET_PLAYER_ATTRIBUTE_TEXT,
+				0x00, 0x00, 0x01, AVRCP_STATUS_INVALID_PARAM));
+
 	return g_test_run();
 }
-- 
1.8.3.2


  parent reply	other threads:[~2014-03-04 14:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04 14:02 [PATCHv2 00/10] AVRCP test patches rebased Andrei Emeltchenko
2014-03-04 14:02 ` [PATCHv2 01/10] avrcp: Fix possible buffer overflow Andrei Emeltchenko
2014-03-04 14:02 ` [PATCHv2 02/10] unit/avrcp: Add /TP/PAS/BV-06-C test Andrei Emeltchenko
2014-03-04 14:02 ` [PATCHv2 03/10] unit/avrcp: Add /TP/PAS/BV-08-C test Andrei Emeltchenko
2014-03-04 14:02 ` [PATCHv2 04/10] android/avrcp: Add avrcp_get_current_player_value() function Andrei Emeltchenko
2014-03-04 14:02 ` [PATCHv2 05/10] unit/avrcp: Add /TP/PAS/BV-09-C test Andrei Emeltchenko
2014-03-04 14:02 ` [PATCHv2 06/10] unit/avrcp: Add /TP/PAS/BV-10-C test Andrei Emeltchenko
2014-03-04 14:02 ` [PATCHv2 07/10] android/avrcp: Add avrcp_set_player_value() function Andrei Emeltchenko
2014-03-04 14:02 ` [PATCHv2 08/10] unit/avrcp: Add /TP/PAS/BV-11-C test Andrei Emeltchenko
2014-03-04 14:02 ` Andrei Emeltchenko [this message]
2014-03-04 14:02 ` [PATCHv2 10/10] doc: Update test coverage document Andrei Emeltchenko
2014-03-05  8:24 ` [PATCHv2 00/10] AVRCP test patches rebased Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393941735-12187-10-git-send-email-Andrei.Emeltchenko.news@gmail.com \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox