From: "Thomas Bächler" <thomas@archlinux.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Gustavo Padovan" <gustavo@padovan.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
"Thomas Bächler" <thomas@archlinux.org>
Subject: [PATCH] Revert "Bluetooth: Use devname:vhci module alias for virtual HCI driver"
Date: Wed, 5 Mar 2014 12:59:12 +0100 [thread overview]
Message-ID: <1394020752-6186-1-git-send-email-thomas@archlinux.org> (raw)
Adding the devname:vhci alias and thus adding a static /dev/vhci device node
only works when assigning a fixed major/minor number. However, the code
currently uses a dynamically assigned minor number. It is therefore impossible
to create a static device and to autoload the module when accessing it.
Reverting this fixes the kmod error message
depmod: ERROR: Module 'hci_vhci' has devname (vhci) but lacks major and minor information. Ignoring.
This reverts commit bfacbb9aec029b3200053d84c8cd5d7575f2d4a5.
---
drivers/bluetooth/hci_vhci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
index 1ef6990..cf05d70 100644
--- a/drivers/bluetooth/hci_vhci.c
+++ b/drivers/bluetooth/hci_vhci.c
@@ -384,4 +384,3 @@ MODULE_AUTHOR("Marcel Holtmann <marcel@holtmann.org>");
MODULE_DESCRIPTION("Bluetooth virtual HCI driver ver " VERSION);
MODULE_VERSION(VERSION);
MODULE_LICENSE("GPL");
-MODULE_ALIAS("devname:vhci");
--
1.9.0
next reply other threads:[~2014-03-05 11:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 11:59 Thomas Bächler [this message]
2014-03-05 15:28 ` [PATCH] Revert "Bluetooth: Use devname:vhci module alias for virtual HCI driver" Josh Boyer
2014-03-05 16:11 ` Johan Hedberg
2014-03-05 16:46 ` Marcel Holtmann
2014-03-05 17:50 ` Josh Boyer
2014-03-05 18:36 ` Marcel Holtmann
2014-03-05 18:48 ` Thomas Bächler
2014-03-05 18:53 ` Josh Boyer
2014-03-05 19:02 ` Marcel Holtmann
2014-03-18 11:34 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394020752-6186-1-git-send-email-thomas@archlinux.org \
--to=thomas@archlinux.org \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox