From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 4/4] android/avrcp: Fix warnings when freeing avrcp_device struct
Date: Thu, 6 Mar 2014 15:03:23 +0200 [thread overview]
Message-ID: <1394111003-2396-4-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1394111003-2396-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
If the device does not yet have queue due to not have a session it cause
the following warnings when avrcp_device_free is called:
(bluetoothd:1102): GLib-CRITICAL **: g_queue_foreach: assertion 'queue != NULL' failed
(bluetoothd:1102): GLib-CRITICAL **: g_queue_free: assertion 'queue != NULL' failed
---
android/avrcp.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/android/avrcp.c b/android/avrcp.c
index ce636c0..1b99a9c 100644
--- a/android/avrcp.c
+++ b/android/avrcp.c
@@ -442,8 +442,10 @@ static void avrcp_device_free(void *data)
{
struct avrcp_device *dev = data;
- g_queue_foreach(dev->queue, (GFunc) g_free, NULL);
- g_queue_free(dev->queue);
+ if (dev->queue) {
+ g_queue_foreach(dev->queue, (GFunc) g_free, NULL);
+ g_queue_free(dev->queue);
+ }
if (dev->session)
avrcp_shutdown(dev->session);
--
1.8.5.3
prev parent reply other threads:[~2014-03-06 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 13:03 [PATCH BlueZ 1/4] android/avrcp: Add remote features notification Luiz Augusto von Dentz
2014-03-06 13:03 ` [PATCH BlueZ 2/4] android/client: Add AVRCP remote_features_cb support Luiz Augusto von Dentz
2014-03-06 13:03 ` [PATCH BlueZ 3/4] android/arvrcp: Fix not parsing SDP record correctly Luiz Augusto von Dentz
2014-03-06 13:03 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394111003-2396-4-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox