linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: johan.hedberg@gmail.com
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 0/6] Bluetooth: LE Security fixes/improvements
Date: Mon, 24 Mar 2014 14:39:02 +0200	[thread overview]
Message-ID: <1395664748-13494-1-git-send-email-johan.hedberg@gmail.com> (raw)

Hi,

Here's a set of patches I've ended up creating today due to various
issues found with LE security handling. Most of the issues fixed have
been in the three for a bit longer time, but the issue fixed by 3/6 was
introduced (by me) by the change to use passkey notification instead of
confirmation.

I've left the LTK re-encryption removal to be the last patch since it
can be debated whether we want it or not. I've on occasion had quite
many LTK re-encryption failures when testing against my iPhone, but
mostly it works just fine. Removing the re-encryption drops the failures
to 0. Today I kept getting local failures (Start Encrypt cmd_status)
constantly with local Intel Bluetooth hardware and a Bluetooth mouse.
Removing the re-encryption made this work again.

Johan

----------------------------------------------------------------
Johan Hedberg (6):
      Bluetooth: Fix potential NULL pointer dereference in SMP
      Bluetooth: Add missing cmd_status handler for LE_Start_Encryption
      Bluetooth: Fix SMP confirmation callback handling
      Bluetooth: Add SMP flag to track which side is the initiator
      Bluetooth: Don't try to confirm locally initiated SMP pairing
      Bluetooth: Remove LTK re-encryption procedure

 net/bluetooth/hci_event.c | 34 +++++++++++++++++++++
 net/bluetooth/smp.c       | 71
++++++++++++++++---------------------------
 net/bluetooth/smp.h       |  7 ++---
 3 files changed, 63 insertions(+), 49 deletions(-)


             reply	other threads:[~2014-03-24 12:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24 12:39 johan.hedberg [this message]
2014-03-24 12:39 ` [PATCH 1/6] Bluetooth: Fix potential NULL pointer dereference in SMP johan.hedberg
2014-03-24 12:39 ` [PATCH 2/6] Bluetooth: Add missing cmd_status handler for LE_Start_Encryption johan.hedberg
2014-03-24 12:39 ` [PATCH 3/6] Bluetooth: Fix SMP confirmation callback handling johan.hedberg
2014-03-24 12:39 ` [PATCH 4/6] Bluetooth: Add SMP flag to track which side is the initiator johan.hedberg
2014-03-24 13:54   ` [PATCH v2 " johan.hedberg
2014-03-24 12:39 ` [PATCH 5/6] Bluetooth: Don't try to confirm locally initiated SMP pairing johan.hedberg
2014-03-24 12:39 ` [PATCH 6/6] Bluetooth: Remove LTK re-encryption procedure johan.hedberg
2014-03-24 14:52 ` [PATCH 0/6] Bluetooth: LE Security fixes/improvements Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395664748-13494-1-git-send-email-johan.hedberg@gmail.com \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).