Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcin Kraglak <marcin.kraglak@tieto.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCHv3 1/8] android/gatt: Add helper for getting device by conn_id
Date: Fri, 28 Mar 2014 10:45:52 +0100	[thread overview]
Message-ID: <1395999959-2396-1-git-send-email-marcin.kraglak@tieto.com> (raw)

It will look for cgatt_device by conn_id.
---
 android/gatt.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/android/gatt.c b/android/gatt.c
index 81b29af..92e16d4 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -722,6 +722,11 @@ static struct gatt_device *find_device(bdaddr_t *addr)
 	return NULL;
 }
 
+static struct gatt_device *find_device_by_conn_id(int32_t conn_id)
+{
+	return queue_find(conn_list, match_dev_by_conn_id, INT_TO_PTR(conn_id));
+}
+
 static void handle_client_connect(const void *buf, uint16_t len)
 {
 	const struct hal_cmd_gatt_client_connect *cmd = buf;
@@ -858,8 +863,7 @@ static void handle_client_disconnect(const void *buf, uint16_t len)
 
 	ba2str((bdaddr_t *)&cmd->bdaddr, addr);
 
-	dev = queue_find(conn_list, match_dev_by_conn_id,
-						INT_TO_PTR(cmd->conn_id));
+	dev = find_device_by_conn_id(cmd->conn_id);
 	if (!dev) {
 		error("gatt: dev %s with conn_id=%d not found",
 							addr, cmd->conn_id);
@@ -924,8 +928,7 @@ static void handle_client_search_service(const void *buf, uint16_t len)
 
 	DBG("");
 
-	dev = queue_find(conn_list, match_dev_by_conn_id,
-						INT_TO_PTR(cmd->conn_id));
+	dev = find_device_by_conn_id(cmd->conn_id);
 	if (!dev) {
 		error("gatt: dev with conn_id=%d not found", cmd->conn_id);
 		status = HAL_STATUS_FAILED;
@@ -1048,8 +1051,7 @@ static bool find_service(int32_t conn_id, struct element_id *service_id,
 	struct gatt_device *device;
 	struct service *service;
 
-	device = queue_find(conn_list, match_dev_by_conn_id,
-							INT_TO_PTR(conn_id));
+	device = find_device_by_conn_id(conn_id);
 	if (!device) {
 		error("gatt: conn_id=%d not found", conn_id);
 		return false;
-- 
1.8.3.1


             reply	other threads:[~2014-03-28  9:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28  9:45 Marcin Kraglak [this message]
2014-03-28  9:45 ` [PATCHv3 2/8] android/gatt: Add initial implementation of get_included_service Marcin Kraglak
2014-03-28  9:45 ` [PATCHv3 3/8] android/gatt: Add get_included_data struct and callback Marcin Kraglak
2014-03-28  9:45 ` [PATCHv3 4/8] android/gatt: Add implementation of get_included_cb Marcin Kraglak
2014-03-28  9:45 ` [PATCHv3 5/8] android/gatt: Add initial implementation of register_for_notification Marcin Kraglak
2014-03-28  9:45 ` [PATCHv3 6/8] android/gatt: Add send_register_for_notif_ev function Marcin Kraglak
2014-03-28  9:45 ` [PATCHv3 7/8] android/gatt: Add handler for ATT_OP_HANDLE_NOTIFY and ATT_OP_HANDLE_IND Marcin Kraglak
2014-03-28  9:45 ` [PATCHv3 8/8] android/gatt: Add deregister_for_notification implementation Marcin Kraglak
2014-03-28 10:28 ` [PATCHv3 1/8] android/gatt: Add helper for getting device by conn_id Szymon Janc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395999959-2396-1-git-send-email-marcin.kraglak@tieto.com \
    --to=marcin.kraglak@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox