Linux bluetooth development
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 2/2] core/profile: Fix regression when registering for client only
Date: Mon, 14 Apr 2014 15:40:02 +0300	[thread overview]
Message-ID: <1397479202-3632-2-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1397479202-3632-1-git-send-email-luiz.dentz@gmail.com>

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This got introduced with PCE that register a record for PBAP client, but
it end up causing a regression where all profiles that have records would
be probed as if server was enabled as well.

Note that is was possible to register PBAP client with PCE record, in
that case Role option should be omitted so both server and client role
are enabled by default which does not affect PBAP server component since
it uses a different UUID, in fact the correct form to add PCE record is
probably to register as server only.
---
 src/profile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/profile.c b/src/profile.c
index f065235..f30f4f6 100644
--- a/src/profile.c
+++ b/src/profile.c
@@ -2209,7 +2209,7 @@ static struct ext_profile *create_ext(const char *owner, const char *path,
 	p->local_uuid = ext->service ? ext->service : ext->uuid;
 	p->remote_uuid = ext->remote_uuid;
 
-	if (ext->enable_server || ext->record || ext->get_record) {
+	if (ext->enable_server) {
 		p->adapter_probe = ext_adapter_probe;
 		p->adapter_remove = ext_adapter_remove;
 	}
-- 
1.9.0


  reply	other threads:[~2014-04-14 12:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14 12:40 [PATCH BlueZ 1/2] tools: Remove simple-service Luiz Augusto von Dentz
2014-04-14 12:40 ` Luiz Augusto von Dentz [this message]
2014-04-16  9:50 ` Szymon Janc
2014-04-22  7:52   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397479202-3632-2-git-send-email-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox