From: Szymon Janc <szymon.janc@tieto.com>
To: linux-bluetooth@vger.kernel.org
Cc: Szymon Janc <szymon.janc@tieto.com>
Subject: [PATCH 2/4] android/hidhost: Cleanup handle_uhid_output
Date: Fri, 18 Apr 2014 15:40:04 +0200 [thread overview]
Message-ID: <1397828406-29951-2-git-send-email-szymon.janc@tieto.com> (raw)
In-Reply-To: <1397828406-29951-1-git-send-email-szymon.janc@tieto.com>
---
android/hidhost.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/android/hidhost.c b/android/hidhost.c
index b8d2d8f..ea83733 100644
--- a/android/hidhost.c
+++ b/android/hidhost.c
@@ -173,15 +173,14 @@ static void hex2buf(const uint8_t *hex, uint8_t *buf, int num)
static void handle_uhid_output(struct hid_device *dev,
struct uhid_output_req *output)
{
- int fd;
- uint8_t *req = NULL;
- uint8_t req_size = 0;
+ int fd, req_size;
+ uint8_t *req;
- if (!(dev->ctrl_io))
+ if (!dev->ctrl_io)
return;
req_size = 1 + output->size;
- req = g_try_malloc0(req_size);
+ req = malloc0(req_size);
if (!req)
return;
@@ -191,10 +190,10 @@ static void handle_uhid_output(struct hid_device *dev,
fd = g_io_channel_unix_get_fd(dev->ctrl_io);
if (write(fd, req, req_size) < 0)
- error("error writing set_report: %s (%d)",
- strerror(errno), errno);
+ error("hidhost: error writing set_report: %s (%d)",
+ strerror(errno), errno);
- g_free(req);
+ free(req);
}
static gboolean uhid_event_cb(GIOChannel *io, GIOCondition cond,
--
1.9.1
next prev parent reply other threads:[~2014-04-18 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 13:40 [PATCH 1/4] android/hidhost: Fix handle_uhid_output Szymon Janc
2014-04-18 13:40 ` Szymon Janc [this message]
2014-04-18 13:40 ` [PATCH 3/4] android/hidhost: Don't use sscanf in hex2buf Szymon Janc
2014-04-18 13:40 ` [PATCH 4/4] android/hidhost: Check if hex2buf succed Szymon Janc
2014-04-23 8:13 ` [PATCH 1/4] android/hidhost: Fix handle_uhid_output Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397828406-29951-2-git-send-email-szymon.janc@tieto.com \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox