Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcin Kraglak <marcin.kraglak@tieto.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 3/4] android/gatt: Chack if given handle exists in database
Date: Fri, 30 May 2014 07:51:13 +0200	[thread overview]
Message-ID: <1401429074-31535-3-git-send-email-marcin.kraglak@tieto.com> (raw)
In-Reply-To: <1401429074-31535-1-git-send-email-marcin.kraglak@tieto.com>

If attribute doesn't exist, we should return ATT_ECODE_ATTR_NOT_FOUND
error.
---
 android/gatt.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/android/gatt.c b/android/gatt.c
index 80d9f30..48a32ec 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -4070,6 +4070,9 @@ static void read_requested_attributes(void *data, void *user_data)
 	uint8_t *value;
 	int value_len;
 
+	if (!gatt_db_has_attribute(gatt_db, resp_data->handle))
+		return;
+
 	permissions = gatt_db_get_attribute_permissions(gatt_db,
 							resp_data->handle);
 
@@ -5067,6 +5070,9 @@ static void write_cmd_request(const uint8_t *cmd, uint16_t cmd_len,
 	if (!len)
 		return;
 
+	if (!gatt_db_has_attribute(gatt_db, handle))
+		return;
+
 	permissions = gatt_db_get_attribute_permissions(gatt_db, handle);
 	if (check_device_permissions(dev, cmd[0], permissions))
 		return;
@@ -5093,6 +5099,9 @@ static void write_signed_cmd_request(const uint8_t *cmd, uint16_t cmd_len,
 
 	len = dec_signed_write_cmd(cmd, cmd_len, &handle, value, &vlen, s);
 
+	if (!gatt_db_has_attribute(gatt_db, handle))
+		return;
+
 	permissions = gatt_db_get_attribute_permissions(gatt_db, handle);
 	if (check_device_permissions(dev, cmd[0], permissions))
 		return;
@@ -5133,6 +5142,9 @@ static uint8_t write_req_request(const uint8_t *cmd, uint16_t cmd_len,
 	if (!len)
 		return ATT_ECODE_INVALID_PDU;
 
+	if (!gatt_db_has_attribute(gatt_db, handle))
+		return ATT_ECODE_ATTR_NOT_FOUND;
+
 	permissions = gatt_db_get_attribute_permissions(gatt_db, handle);
 
 	error = check_device_permissions(dev, cmd[0], permissions);
@@ -5181,6 +5193,9 @@ static uint8_t write_prep_request(const uint8_t *cmd, uint16_t cmd_len,
 	if (!len)
 		return ATT_ECODE_INVALID_PDU;
 
+	if (!gatt_db_has_attribute(gatt_db, handle))
+		return ATT_ECODE_ATTR_NOT_FOUND;
+
 	permissions = gatt_db_get_attribute_permissions(gatt_db, handle);
 
 	error = check_device_permissions(dev, cmd[0], permissions);
-- 
1.9.0


  parent reply	other threads:[~2014-05-30  5:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30  5:51 [PATCH 1/4] android/gatt: Fix parallel reading/writing attributes values from applications Marcin Kraglak
2014-05-30  5:51 ` [PATCH 2/4] shared/gatt: Add function to check if handle was found in database Marcin Kraglak
2014-05-30  8:32   ` Luiz Augusto von Dentz
2014-05-30  9:16     ` Szymon Janc
2014-05-30  5:51 ` Marcin Kraglak [this message]
2014-05-30  5:51 ` [PATCH 4/4] android/gatt: Check for invalid handle errors Marcin Kraglak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401429074-31535-3-git-send-email-marcin.kraglak@tieto.com \
    --to=marcin.kraglak@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox