* [PATCH] android: Fix compile error
@ 2014-06-02 14:49 Andre Guedes
2014-06-05 17:38 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Andre Guedes @ 2014-06-02 14:49 UTC (permalink / raw)
To: linux-bluetooth
During configure, if SBC is not installed in the system, we may use
SBC_CFLAGS and SBC_LIBS variables to indicate where SBC headers and
binaries can be found.
However, SBC_CFLAGS variable is not used in android/Makefile.am,
causing the following compile error:
$ ./bootstrap-configure SBC_CFLAGS=-I../sbc SBC_LIBS=-L../sbc/src/
$ make
(...)
android/hal-audio-sbc.c:22:21: fatal error: sbc/sbc.h: No such file or directory
#include <sbc/sbc.h>
^
compilation terminated.
make[1]: *** [android/android_audio_a2dp_default_la-hal-audio-sbc.lo] Error 1
This patch fixes this error by appending SBC_CFLAGS to android_audio_
a2dp_default_la_CFLAGS.
---
android/Makefile.am | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/android/Makefile.am b/android/Makefile.am
index bcaec4c..08e6a95 100644
--- a/android/Makefile.am
+++ b/android/Makefile.am
@@ -205,7 +205,8 @@ android_test_ipc_LDADD = @GLIB_LIBS@
plugin_LTLIBRARIES += android/audio.a2dp.default.la
-android_audio_a2dp_default_la_CFLAGS = $(AM_CFLAGS) -I$(srcdir)/android
+android_audio_a2dp_default_la_CFLAGS = $(AM_CFLAGS) -I$(srcdir)/android \
+ @SBC_CFLAGS@
android_audio_a2dp_default_la_LIBADD = @SBC_LIBS@
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] android: Fix compile error
2014-06-02 14:49 [PATCH] android: Fix compile error Andre Guedes
@ 2014-06-05 17:38 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2014-06-05 17:38 UTC (permalink / raw)
To: Andre Guedes; +Cc: linux-bluetooth
Hi Andre,
On Mon, Jun 02, 2014, Andre Guedes wrote:
> During configure, if SBC is not installed in the system, we may use
> SBC_CFLAGS and SBC_LIBS variables to indicate where SBC headers and
> binaries can be found.
>
> However, SBC_CFLAGS variable is not used in android/Makefile.am,
> causing the following compile error:
>
> $ ./bootstrap-configure SBC_CFLAGS=-I../sbc SBC_LIBS=-L../sbc/src/
> $ make
>
> (...)
>
> android/hal-audio-sbc.c:22:21: fatal error: sbc/sbc.h: No such file or directory
> #include <sbc/sbc.h>
> ^
> compilation terminated.
> make[1]: *** [android/android_audio_a2dp_default_la-hal-audio-sbc.lo] Error 1
>
> This patch fixes this error by appending SBC_CFLAGS to android_audio_
> a2dp_default_la_CFLAGS.
> ---
> android/Makefile.am | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-05 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-02 14:49 [PATCH] android: Fix compile error Andre Guedes
2014-06-05 17:38 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).