* [PATCH v5 0/5] Bluetooth LE 6LoWPAN using CoC
@ 2014-06-02 15:00 Jukka Rissanen
2014-06-02 15:00 ` [PATCH v5 1/5] Bluetooth: Refactor l2cap_sock_sendmsg() to copy user buffer Jukka Rissanen
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Jukka Rissanen @ 2014-06-02 15:00 UTC (permalink / raw)
To: linux-bluetooth
Hi,
v5:
- memory buffer made const in patch 1
- misc changes and refactoring in patch 2
v4:
- renamed l2cap_from_skbuf() to more logical l2cap_copy_into_skbuff()
in l2cap_core.c (patch 1)
- fixed the module usage count code in patch 4
Usage:
In the slave side do this:
$ modprobe bluetooth_6lowpan
$ echo 62 > /sys/kernel/debug/bluetooth/6lowpan_psm
$ hciconfig hci0 leadv
In the master side do this:
$ modprobe bluetooth_6lowpan
$ echo 62 > /sys/kernel/debug/bluetooth/6lowpan_psm
$ echo 'connect E0:06:E6:B7:2A:73 1' > \
/sys/kernel/debug/bluetooth/6lowpan_control
Cheers,
Jukka
Jukka Rissanen (5):
Bluetooth: Refactor l2cap_sock_sendmsg() to copy user buffer
Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed
one
Bluetooth: 6LoWPAN: Create a kernel module
Bluetooth: 6LoWPAN: Count module usage
Bluetooth: 6LoWPAN: Remove network devices when unloading
include/net/bluetooth/hci.h | 1 -
include/net/bluetooth/hci_core.h | 1 -
include/net/bluetooth/l2cap.h | 5 +-
net/bluetooth/6lowpan.c | 845 +++++++++++++++++++++++++++++----------
net/bluetooth/6lowpan.h | 47 ---
net/bluetooth/Kconfig | 6 +-
net/bluetooth/Makefile | 4 +-
net/bluetooth/a2mp.c | 12 +-
net/bluetooth/hci_core.c | 45 ---
net/bluetooth/hci_event.c | 3 -
net/bluetooth/l2cap_core.c | 101 ++---
net/bluetooth/l2cap_sock.c | 14 +-
12 files changed, 716 insertions(+), 368 deletions(-)
delete mode 100644 net/bluetooth/6lowpan.h
--
1.8.3.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v5 1/5] Bluetooth: Refactor l2cap_sock_sendmsg() to copy user buffer 2014-06-02 15:00 [PATCH v5 0/5] Bluetooth LE 6LoWPAN using CoC Jukka Rissanen @ 2014-06-02 15:00 ` Jukka Rissanen 2014-06-03 3:49 ` Marcel Holtmann 2014-06-02 15:00 ` [PATCH v5 2/5] Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one Jukka Rissanen ` (3 subsequent siblings) 4 siblings, 1 reply; 10+ messages in thread From: Jukka Rissanen @ 2014-06-02 15:00 UTC (permalink / raw) To: linux-bluetooth The l2cap_chan_send() is changed to use kernel memory directly, so this function must read the user buffer before sending the message. The change is done as the 6LoWPAN also uses l2cap_chan_send() and in order to minimize the amount of code changes, we must copy the user buffer in sock handling code. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> --- include/net/bluetooth/l2cap.h | 4 +-- net/bluetooth/a2mp.c | 12 +------ net/bluetooth/l2cap_core.c | 81 ++++++++++++++++++++++++------------------- net/bluetooth/l2cap_sock.c | 14 +++++++- 4 files changed, 61 insertions(+), 50 deletions(-) diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h index 4abdcb2..c84d770 100644 --- a/include/net/bluetooth/l2cap.h +++ b/include/net/bluetooth/l2cap.h @@ -872,8 +872,8 @@ struct l2cap_chan *l2cap_chan_create(void); void l2cap_chan_close(struct l2cap_chan *chan, int reason); int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, bdaddr_t *dst, u8 dst_type); -int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, - u32 priority); +int l2cap_chan_send(struct l2cap_chan *chan, const void *buf, size_t len, + u32 priority, unsigned int flags); void l2cap_chan_busy(struct l2cap_chan *chan, int busy); int l2cap_chan_check_security(struct l2cap_chan *chan); void l2cap_chan_set_defaults(struct l2cap_chan *chan); diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c index 9514cc9..6b99b1b 100644 --- a/net/bluetooth/a2mp.c +++ b/net/bluetooth/a2mp.c @@ -48,22 +48,12 @@ void a2mp_send(struct amp_mgr *mgr, u8 code, u8 ident, u16 len, void *data) struct l2cap_chan *chan = mgr->a2mp_chan; struct a2mp_cmd *cmd; u16 total_len = len + sizeof(*cmd); - struct kvec iv; - struct msghdr msg; cmd = __a2mp_build(code, ident, len, data); if (!cmd) return; - iv.iov_base = cmd; - iv.iov_len = total_len; - - memset(&msg, 0, sizeof(msg)); - - msg.msg_iov = (struct iovec *) &iv; - msg.msg_iovlen = 1; - - l2cap_chan_send(chan, &msg, total_len, 0); + l2cap_chan_send(chan, cmd, total_len, 0, 0); kfree(cmd); } diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 7468482..495e6bc 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -2104,19 +2104,20 @@ static void l2cap_send_ack(struct l2cap_chan *chan) } } -static inline int l2cap_skbuff_fromiovec(struct l2cap_chan *chan, - struct msghdr *msg, int len, - int count, struct sk_buff *skb) +static inline int l2cap_copy_into_skbuff(struct l2cap_chan *chan, + const void *buf, int len, + unsigned int flags, int count, + struct sk_buff *skb) { struct l2cap_conn *conn = chan->conn; struct sk_buff **frag; int sent = 0; - if (memcpy_fromiovec(skb_put(skb, count), msg->msg_iov, count)) - return -EFAULT; + memcpy(skb_put(skb, count), buf, count); sent += count; len -= count; + buf += count; /* Continuation fragments (no L2CAP header) */ frag = &skb_shinfo(skb)->frag_list; @@ -2126,19 +2127,19 @@ static inline int l2cap_skbuff_fromiovec(struct l2cap_chan *chan, count = min_t(unsigned int, conn->mtu, len); tmp = chan->ops->alloc_skb(chan, count, - msg->msg_flags & MSG_DONTWAIT); + flags & MSG_DONTWAIT); if (IS_ERR(tmp)) return PTR_ERR(tmp); *frag = tmp; - if (memcpy_fromiovec(skb_put(*frag, count), msg->msg_iov, count)) - return -EFAULT; + memcpy(skb_put(*frag, count), buf, count); (*frag)->priority = skb->priority; sent += count; len -= count; + buf += count; skb->len += (*frag)->len; skb->data_len += (*frag)->len; @@ -2150,8 +2151,9 @@ static inline int l2cap_skbuff_fromiovec(struct l2cap_chan *chan, } static struct sk_buff *l2cap_create_connless_pdu(struct l2cap_chan *chan, - struct msghdr *msg, size_t len, - u32 priority) + const void *buf, size_t len, + u32 priority, + unsigned int flags) { struct l2cap_conn *conn = chan->conn; struct sk_buff *skb; @@ -2164,7 +2166,7 @@ static struct sk_buff *l2cap_create_connless_pdu(struct l2cap_chan *chan, count = min_t(unsigned int, (conn->mtu - hlen), len); skb = chan->ops->alloc_skb(chan, count + hlen, - msg->msg_flags & MSG_DONTWAIT); + flags & MSG_DONTWAIT); if (IS_ERR(skb)) return skb; @@ -2176,7 +2178,7 @@ static struct sk_buff *l2cap_create_connless_pdu(struct l2cap_chan *chan, lh->len = cpu_to_le16(len + L2CAP_PSMLEN_SIZE); put_unaligned(chan->psm, (__le16 *) skb_put(skb, L2CAP_PSMLEN_SIZE)); - err = l2cap_skbuff_fromiovec(chan, msg, len, count, skb); + err = l2cap_copy_into_skbuff(chan, buf, len, flags, count, skb); if (unlikely(err < 0)) { kfree_skb(skb); return ERR_PTR(err); @@ -2185,8 +2187,8 @@ static struct sk_buff *l2cap_create_connless_pdu(struct l2cap_chan *chan, } static struct sk_buff *l2cap_create_basic_pdu(struct l2cap_chan *chan, - struct msghdr *msg, size_t len, - u32 priority) + const void *buf, size_t len, + u32 priority, unsigned int flags) { struct l2cap_conn *conn = chan->conn; struct sk_buff *skb; @@ -2198,7 +2200,7 @@ static struct sk_buff *l2cap_create_basic_pdu(struct l2cap_chan *chan, count = min_t(unsigned int, (conn->mtu - L2CAP_HDR_SIZE), len); skb = chan->ops->alloc_skb(chan, count + L2CAP_HDR_SIZE, - msg->msg_flags & MSG_DONTWAIT); + flags & MSG_DONTWAIT); if (IS_ERR(skb)) return skb; @@ -2209,7 +2211,7 @@ static struct sk_buff *l2cap_create_basic_pdu(struct l2cap_chan *chan, lh->cid = cpu_to_le16(chan->dcid); lh->len = cpu_to_le16(len); - err = l2cap_skbuff_fromiovec(chan, msg, len, count, skb); + err = l2cap_copy_into_skbuff(chan, buf, len, flags, count, skb); if (unlikely(err < 0)) { kfree_skb(skb); return ERR_PTR(err); @@ -2218,8 +2220,8 @@ static struct sk_buff *l2cap_create_basic_pdu(struct l2cap_chan *chan, } static struct sk_buff *l2cap_create_iframe_pdu(struct l2cap_chan *chan, - struct msghdr *msg, size_t len, - u16 sdulen) + const void *buf, size_t len, + u16 sdulen, unsigned int flags) { struct l2cap_conn *conn = chan->conn; struct sk_buff *skb; @@ -2242,7 +2244,7 @@ static struct sk_buff *l2cap_create_iframe_pdu(struct l2cap_chan *chan, count = min_t(unsigned int, (conn->mtu - hlen), len); skb = chan->ops->alloc_skb(chan, count + hlen, - msg->msg_flags & MSG_DONTWAIT); + flags & MSG_DONTWAIT); if (IS_ERR(skb)) return skb; @@ -2260,7 +2262,7 @@ static struct sk_buff *l2cap_create_iframe_pdu(struct l2cap_chan *chan, if (sdulen) put_unaligned_le16(sdulen, skb_put(skb, L2CAP_SDULEN_SIZE)); - err = l2cap_skbuff_fromiovec(chan, msg, len, count, skb); + err = l2cap_copy_into_skbuff(chan, buf, len, flags, count, skb); if (unlikely(err < 0)) { kfree_skb(skb); return ERR_PTR(err); @@ -2273,14 +2275,15 @@ static struct sk_buff *l2cap_create_iframe_pdu(struct l2cap_chan *chan, static int l2cap_segment_sdu(struct l2cap_chan *chan, struct sk_buff_head *seg_queue, - struct msghdr *msg, size_t len) + const void *buf, size_t len, + unsigned int flags) { struct sk_buff *skb; u16 sdu_len; size_t pdu_len; u8 sar; - BT_DBG("chan %p, msg %p, len %zu", chan, msg, len); + BT_DBG("chan %p, buf %p, len %zu", chan, buf, len); /* It is critical that ERTM PDUs fit in a single HCI fragment, * so fragmented skbs are not used. The HCI layer's handling @@ -2314,7 +2317,8 @@ static int l2cap_segment_sdu(struct l2cap_chan *chan, } while (len > 0) { - skb = l2cap_create_iframe_pdu(chan, msg, pdu_len, sdu_len); + skb = l2cap_create_iframe_pdu(chan, buf, pdu_len, sdu_len, + flags); if (IS_ERR(skb)) { __skb_queue_purge(seg_queue); @@ -2342,8 +2346,9 @@ static int l2cap_segment_sdu(struct l2cap_chan *chan, } static struct sk_buff *l2cap_create_le_flowctl_pdu(struct l2cap_chan *chan, - struct msghdr *msg, - size_t len, u16 sdulen) + const void *buf, size_t len, + u16 sdulen, + unsigned int flags) { struct l2cap_conn *conn = chan->conn; struct sk_buff *skb; @@ -2363,7 +2368,7 @@ static struct sk_buff *l2cap_create_le_flowctl_pdu(struct l2cap_chan *chan, count = min_t(unsigned int, (conn->mtu - hlen), len); skb = chan->ops->alloc_skb(chan, count + hlen, - msg->msg_flags & MSG_DONTWAIT); + flags & MSG_DONTWAIT); if (IS_ERR(skb)) return skb; @@ -2375,7 +2380,7 @@ static struct sk_buff *l2cap_create_le_flowctl_pdu(struct l2cap_chan *chan, if (sdulen) put_unaligned_le16(sdulen, skb_put(skb, L2CAP_SDULEN_SIZE)); - err = l2cap_skbuff_fromiovec(chan, msg, len, count, skb); + err = l2cap_copy_into_skbuff(chan, buf, len, flags, count, skb); if (unlikely(err < 0)) { kfree_skb(skb); return ERR_PTR(err); @@ -2386,13 +2391,14 @@ static struct sk_buff *l2cap_create_le_flowctl_pdu(struct l2cap_chan *chan, static int l2cap_segment_le_sdu(struct l2cap_chan *chan, struct sk_buff_head *seg_queue, - struct msghdr *msg, size_t len) + const void *buf, size_t len, + unsigned int flags) { struct sk_buff *skb; size_t pdu_len; u16 sdu_len; - BT_DBG("chan %p, msg %p, len %zu", chan, msg, len); + BT_DBG("chan %p, buf %p, len %zu", chan, buf, len); pdu_len = chan->conn->mtu - L2CAP_HDR_SIZE; @@ -2405,7 +2411,8 @@ static int l2cap_segment_le_sdu(struct l2cap_chan *chan, if (len <= pdu_len) pdu_len = len; - skb = l2cap_create_le_flowctl_pdu(chan, msg, pdu_len, sdu_len); + skb = l2cap_create_le_flowctl_pdu(chan, buf, pdu_len, sdu_len, + flags); if (IS_ERR(skb)) { __skb_queue_purge(seg_queue); return PTR_ERR(skb); @@ -2414,6 +2421,7 @@ static int l2cap_segment_le_sdu(struct l2cap_chan *chan, __skb_queue_tail(seg_queue, skb); len -= pdu_len; + buf += pdu_len; if (sdu_len) { sdu_len = 0; @@ -2424,8 +2432,8 @@ static int l2cap_segment_le_sdu(struct l2cap_chan *chan, return 0; } -int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, - u32 priority) +int l2cap_chan_send(struct l2cap_chan *chan, const void *buf, size_t len, + u32 priority, unsigned int flags) { struct sk_buff *skb; int err; @@ -2436,7 +2444,8 @@ int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, /* Connectionless channel */ if (chan->chan_type == L2CAP_CHAN_CONN_LESS) { - skb = l2cap_create_connless_pdu(chan, msg, len, priority); + skb = l2cap_create_connless_pdu(chan, buf, len, priority, + flags); if (IS_ERR(skb)) return PTR_ERR(skb); @@ -2463,7 +2472,7 @@ int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, __skb_queue_head_init(&seg_queue); - err = l2cap_segment_le_sdu(chan, &seg_queue, msg, len); + err = l2cap_segment_le_sdu(chan, &seg_queue, buf, len, flags); if (chan->state != BT_CONNECTED) { __skb_queue_purge(&seg_queue); @@ -2493,7 +2502,7 @@ int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, return -EMSGSIZE; /* Create a basic PDU */ - skb = l2cap_create_basic_pdu(chan, msg, len, priority); + skb = l2cap_create_basic_pdu(chan, buf, len, priority, flags); if (IS_ERR(skb)) return PTR_ERR(skb); @@ -2523,7 +2532,7 @@ int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, * since it's possible to block while waiting for memory * allocation. */ - err = l2cap_segment_sdu(chan, &seg_queue, msg, len); + err = l2cap_segment_sdu(chan, &seg_queue, buf, len, flags); /* The channel could have been closed while segmenting, * check that it is still connected. diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c index f59e00c..e66c14c 100644 --- a/net/bluetooth/l2cap_sock.c +++ b/net/bluetooth/l2cap_sock.c @@ -948,6 +948,7 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, { struct sock *sk = sock->sk; struct l2cap_chan *chan = l2cap_pi(sk)->chan; + void *buf; int err; BT_DBG("sock %p, sk %p", sock, sk); @@ -968,10 +969,21 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, if (err) return err; + buf = kmalloc(len, GFP_KERNEL); + if (!buf) + return -ENOMEM; + + if (memcpy_fromiovec(buf, msg->msg_iov, len)) { + err = -EFAULT; + goto done; + } + l2cap_chan_lock(chan); - err = l2cap_chan_send(chan, msg, len, sk->sk_priority); + err = l2cap_chan_send(chan, buf, len, sk->sk_priority, msg->msg_flags); l2cap_chan_unlock(chan); +done: + kfree(buf); return err; } -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v5 1/5] Bluetooth: Refactor l2cap_sock_sendmsg() to copy user buffer 2014-06-02 15:00 ` [PATCH v5 1/5] Bluetooth: Refactor l2cap_sock_sendmsg() to copy user buffer Jukka Rissanen @ 2014-06-03 3:49 ` Marcel Holtmann 0 siblings, 0 replies; 10+ messages in thread From: Marcel Holtmann @ 2014-06-03 3:49 UTC (permalink / raw) To: Jukka Rissanen; +Cc: linux-bluetooth Hi Jukka, > The l2cap_chan_send() is changed to use kernel memory directly, > so this function must read the user buffer before sending the > message. > > The change is done as the 6LoWPAN also uses l2cap_chan_send() > and in order to minimize the amount of code changes, we must > copy the user buffer in sock handling code. > > Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> > --- > include/net/bluetooth/l2cap.h | 4 +-- > net/bluetooth/a2mp.c | 12 +------ > net/bluetooth/l2cap_core.c | 81 ++++++++++++++++++++++++------------------- > net/bluetooth/l2cap_sock.c | 14 +++++++- > 4 files changed, 61 insertions(+), 50 deletions(-) > > diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h > index 4abdcb2..c84d770 100644 > --- a/include/net/bluetooth/l2cap.h > +++ b/include/net/bluetooth/l2cap.h > @@ -872,8 +872,8 @@ struct l2cap_chan *l2cap_chan_create(void); > void l2cap_chan_close(struct l2cap_chan *chan, int reason); > int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, > bdaddr_t *dst, u8 dst_type); > -int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, > - u32 priority); > +int l2cap_chan_send(struct l2cap_chan *chan, const void *buf, size_t len, > + u32 priority, unsigned int flags); > void l2cap_chan_busy(struct l2cap_chan *chan, int busy); > int l2cap_chan_check_security(struct l2cap_chan *chan); > void l2cap_chan_set_defaults(struct l2cap_chan *chan); > diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c > index 9514cc9..6b99b1b 100644 > --- a/net/bluetooth/a2mp.c > +++ b/net/bluetooth/a2mp.c > @@ -48,22 +48,12 @@ void a2mp_send(struct amp_mgr *mgr, u8 code, u8 ident, u16 len, void *data) > struct l2cap_chan *chan = mgr->a2mp_chan; > struct a2mp_cmd *cmd; > u16 total_len = len + sizeof(*cmd); > - struct kvec iv; > - struct msghdr msg; > > cmd = __a2mp_build(code, ident, len, data); > if (!cmd) > return; > > - iv.iov_base = cmd; > - iv.iov_len = total_len; > - > - memset(&msg, 0, sizeof(msg)); > - > - msg.msg_iov = (struct iovec *) &iv; > - msg.msg_iovlen = 1; > - > - l2cap_chan_send(chan, &msg, total_len, 0); > + l2cap_chan_send(chan, cmd, total_len, 0, 0); > > kfree(cmd); > } > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c > index 7468482..495e6bc 100644 > --- a/net/bluetooth/l2cap_core.c > +++ b/net/bluetooth/l2cap_core.c > @@ -2104,19 +2104,20 @@ static void l2cap_send_ack(struct l2cap_chan *chan) > } > } > > -static inline int l2cap_skbuff_fromiovec(struct l2cap_chan *chan, > - struct msghdr *msg, int len, > - int count, struct sk_buff *skb) > +static inline int l2cap_copy_into_skbuff(struct l2cap_chan *chan, > + const void *buf, int len, > + unsigned int flags, int count, > + struct sk_buff *skb) > { > struct l2cap_conn *conn = chan->conn; > struct sk_buff **frag; > int sent = 0; > > - if (memcpy_fromiovec(skb_put(skb, count), msg->msg_iov, count)) > - return -EFAULT; > + memcpy(skb_put(skb, count), buf, count); > > sent += count; > len -= count; > + buf += count; > > /* Continuation fragments (no L2CAP header) */ > frag = &skb_shinfo(skb)->frag_list; > @@ -2126,19 +2127,19 @@ static inline int l2cap_skbuff_fromiovec(struct l2cap_chan *chan, > count = min_t(unsigned int, conn->mtu, len); > > tmp = chan->ops->alloc_skb(chan, count, > - msg->msg_flags & MSG_DONTWAIT); > + flags & MSG_DONTWAIT); > if (IS_ERR(tmp)) > return PTR_ERR(tmp); > > *frag = tmp; > > - if (memcpy_fromiovec(skb_put(*frag, count), msg->msg_iov, count)) > - return -EFAULT; > + memcpy(skb_put(*frag, count), buf, count); > > (*frag)->priority = skb->priority; > > sent += count; > len -= count; > + buf += count; > > skb->len += (*frag)->len; > skb->data_len += (*frag)->len; > @@ -2150,8 +2151,9 @@ static inline int l2cap_skbuff_fromiovec(struct l2cap_chan *chan, > } > > static struct sk_buff *l2cap_create_connless_pdu(struct l2cap_chan *chan, > - struct msghdr *msg, size_t len, > - u32 priority) > + const void *buf, size_t len, > + u32 priority, > + unsigned int flags) > { > struct l2cap_conn *conn = chan->conn; > struct sk_buff *skb; > @@ -2164,7 +2166,7 @@ static struct sk_buff *l2cap_create_connless_pdu(struct l2cap_chan *chan, > count = min_t(unsigned int, (conn->mtu - hlen), len); > > skb = chan->ops->alloc_skb(chan, count + hlen, > - msg->msg_flags & MSG_DONTWAIT); > + flags & MSG_DONTWAIT); > if (IS_ERR(skb)) > return skb; > > @@ -2176,7 +2178,7 @@ static struct sk_buff *l2cap_create_connless_pdu(struct l2cap_chan *chan, > lh->len = cpu_to_le16(len + L2CAP_PSMLEN_SIZE); > put_unaligned(chan->psm, (__le16 *) skb_put(skb, L2CAP_PSMLEN_SIZE)); > > - err = l2cap_skbuff_fromiovec(chan, msg, len, count, skb); > + err = l2cap_copy_into_skbuff(chan, buf, len, flags, count, skb); > if (unlikely(err < 0)) { > kfree_skb(skb); > return ERR_PTR(err); > @@ -2185,8 +2187,8 @@ static struct sk_buff *l2cap_create_connless_pdu(struct l2cap_chan *chan, > } > > static struct sk_buff *l2cap_create_basic_pdu(struct l2cap_chan *chan, > - struct msghdr *msg, size_t len, > - u32 priority) > + const void *buf, size_t len, > + u32 priority, unsigned int flags) > { > struct l2cap_conn *conn = chan->conn; > struct sk_buff *skb; > @@ -2198,7 +2200,7 @@ static struct sk_buff *l2cap_create_basic_pdu(struct l2cap_chan *chan, > count = min_t(unsigned int, (conn->mtu - L2CAP_HDR_SIZE), len); > > skb = chan->ops->alloc_skb(chan, count + L2CAP_HDR_SIZE, > - msg->msg_flags & MSG_DONTWAIT); > + flags & MSG_DONTWAIT); > if (IS_ERR(skb)) > return skb; > > @@ -2209,7 +2211,7 @@ static struct sk_buff *l2cap_create_basic_pdu(struct l2cap_chan *chan, > lh->cid = cpu_to_le16(chan->dcid); > lh->len = cpu_to_le16(len); > > - err = l2cap_skbuff_fromiovec(chan, msg, len, count, skb); > + err = l2cap_copy_into_skbuff(chan, buf, len, flags, count, skb); > if (unlikely(err < 0)) { > kfree_skb(skb); > return ERR_PTR(err); > @@ -2218,8 +2220,8 @@ static struct sk_buff *l2cap_create_basic_pdu(struct l2cap_chan *chan, > } > > static struct sk_buff *l2cap_create_iframe_pdu(struct l2cap_chan *chan, > - struct msghdr *msg, size_t len, > - u16 sdulen) > + const void *buf, size_t len, > + u16 sdulen, unsigned int flags) > { > struct l2cap_conn *conn = chan->conn; > struct sk_buff *skb; > @@ -2242,7 +2244,7 @@ static struct sk_buff *l2cap_create_iframe_pdu(struct l2cap_chan *chan, > count = min_t(unsigned int, (conn->mtu - hlen), len); > > skb = chan->ops->alloc_skb(chan, count + hlen, > - msg->msg_flags & MSG_DONTWAIT); > + flags & MSG_DONTWAIT); > if (IS_ERR(skb)) > return skb; > > @@ -2260,7 +2262,7 @@ static struct sk_buff *l2cap_create_iframe_pdu(struct l2cap_chan *chan, > if (sdulen) > put_unaligned_le16(sdulen, skb_put(skb, L2CAP_SDULEN_SIZE)); > > - err = l2cap_skbuff_fromiovec(chan, msg, len, count, skb); > + err = l2cap_copy_into_skbuff(chan, buf, len, flags, count, skb); > if (unlikely(err < 0)) { > kfree_skb(skb); > return ERR_PTR(err); > @@ -2273,14 +2275,15 @@ static struct sk_buff *l2cap_create_iframe_pdu(struct l2cap_chan *chan, > > static int l2cap_segment_sdu(struct l2cap_chan *chan, > struct sk_buff_head *seg_queue, > - struct msghdr *msg, size_t len) > + const void *buf, size_t len, > + unsigned int flags) > { > struct sk_buff *skb; > u16 sdu_len; > size_t pdu_len; > u8 sar; > > - BT_DBG("chan %p, msg %p, len %zu", chan, msg, len); > + BT_DBG("chan %p, buf %p, len %zu", chan, buf, len); > > /* It is critical that ERTM PDUs fit in a single HCI fragment, > * so fragmented skbs are not used. The HCI layer's handling > @@ -2314,7 +2317,8 @@ static int l2cap_segment_sdu(struct l2cap_chan *chan, > } > > while (len > 0) { > - skb = l2cap_create_iframe_pdu(chan, msg, pdu_len, sdu_len); > + skb = l2cap_create_iframe_pdu(chan, buf, pdu_len, sdu_len, > + flags); > > if (IS_ERR(skb)) { > __skb_queue_purge(seg_queue); > @@ -2342,8 +2346,9 @@ static int l2cap_segment_sdu(struct l2cap_chan *chan, > } > > static struct sk_buff *l2cap_create_le_flowctl_pdu(struct l2cap_chan *chan, > - struct msghdr *msg, > - size_t len, u16 sdulen) > + const void *buf, size_t len, > + u16 sdulen, > + unsigned int flags) > { > struct l2cap_conn *conn = chan->conn; > struct sk_buff *skb; > @@ -2363,7 +2368,7 @@ static struct sk_buff *l2cap_create_le_flowctl_pdu(struct l2cap_chan *chan, > count = min_t(unsigned int, (conn->mtu - hlen), len); > > skb = chan->ops->alloc_skb(chan, count + hlen, > - msg->msg_flags & MSG_DONTWAIT); > + flags & MSG_DONTWAIT); > if (IS_ERR(skb)) > return skb; > > @@ -2375,7 +2380,7 @@ static struct sk_buff *l2cap_create_le_flowctl_pdu(struct l2cap_chan *chan, > if (sdulen) > put_unaligned_le16(sdulen, skb_put(skb, L2CAP_SDULEN_SIZE)); > > - err = l2cap_skbuff_fromiovec(chan, msg, len, count, skb); > + err = l2cap_copy_into_skbuff(chan, buf, len, flags, count, skb); > if (unlikely(err < 0)) { > kfree_skb(skb); > return ERR_PTR(err); > @@ -2386,13 +2391,14 @@ static struct sk_buff *l2cap_create_le_flowctl_pdu(struct l2cap_chan *chan, > > static int l2cap_segment_le_sdu(struct l2cap_chan *chan, > struct sk_buff_head *seg_queue, > - struct msghdr *msg, size_t len) > + const void *buf, size_t len, > + unsigned int flags) > { > struct sk_buff *skb; > size_t pdu_len; > u16 sdu_len; > > - BT_DBG("chan %p, msg %p, len %zu", chan, msg, len); > + BT_DBG("chan %p, buf %p, len %zu", chan, buf, len); > > pdu_len = chan->conn->mtu - L2CAP_HDR_SIZE; > > @@ -2405,7 +2411,8 @@ static int l2cap_segment_le_sdu(struct l2cap_chan *chan, > if (len <= pdu_len) > pdu_len = len; > > - skb = l2cap_create_le_flowctl_pdu(chan, msg, pdu_len, sdu_len); > + skb = l2cap_create_le_flowctl_pdu(chan, buf, pdu_len, sdu_len, > + flags); > if (IS_ERR(skb)) { > __skb_queue_purge(seg_queue); > return PTR_ERR(skb); > @@ -2414,6 +2421,7 @@ static int l2cap_segment_le_sdu(struct l2cap_chan *chan, > __skb_queue_tail(seg_queue, skb); > > len -= pdu_len; > + buf += pdu_len; > > if (sdu_len) { > sdu_len = 0; > @@ -2424,8 +2432,8 @@ static int l2cap_segment_le_sdu(struct l2cap_chan *chan, > return 0; > } > > -int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, > - u32 priority) > +int l2cap_chan_send(struct l2cap_chan *chan, const void *buf, size_t len, > + u32 priority, unsigned int flags) > { > struct sk_buff *skb; > int err; > @@ -2436,7 +2444,8 @@ int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, > > /* Connectionless channel */ > if (chan->chan_type == L2CAP_CHAN_CONN_LESS) { > - skb = l2cap_create_connless_pdu(chan, msg, len, priority); > + skb = l2cap_create_connless_pdu(chan, buf, len, priority, > + flags); > if (IS_ERR(skb)) > return PTR_ERR(skb); > > @@ -2463,7 +2472,7 @@ int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, > > __skb_queue_head_init(&seg_queue); > > - err = l2cap_segment_le_sdu(chan, &seg_queue, msg, len); > + err = l2cap_segment_le_sdu(chan, &seg_queue, buf, len, flags); > > if (chan->state != BT_CONNECTED) { > __skb_queue_purge(&seg_queue); > @@ -2493,7 +2502,7 @@ int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, > return -EMSGSIZE; > > /* Create a basic PDU */ > - skb = l2cap_create_basic_pdu(chan, msg, len, priority); > + skb = l2cap_create_basic_pdu(chan, buf, len, priority, flags); > if (IS_ERR(skb)) > return PTR_ERR(skb); > > @@ -2523,7 +2532,7 @@ int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, > * since it's possible to block while waiting for memory > * allocation. > */ > - err = l2cap_segment_sdu(chan, &seg_queue, msg, len); > + err = l2cap_segment_sdu(chan, &seg_queue, buf, len, flags); > > /* The channel could have been closed while segmenting, > * check that it is still connected. > diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c > index f59e00c..e66c14c 100644 > --- a/net/bluetooth/l2cap_sock.c > +++ b/net/bluetooth/l2cap_sock.c > @@ -948,6 +948,7 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, > { > struct sock *sk = sock->sk; > struct l2cap_chan *chan = l2cap_pi(sk)->chan; > + void *buf; > int err; > > BT_DBG("sock %p, sk %p", sock, sk); > @@ -968,10 +969,21 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, > if (err) > return err; > > + buf = kmalloc(len, GFP_KERNEL); > + if (!buf) > + return -ENOMEM; > + > + if (memcpy_fromiovec(buf, msg->msg_iov, len)) { > + err = -EFAULT; > + goto done; > + } > + > l2cap_chan_lock(chan); > - err = l2cap_chan_send(chan, msg, len, sk->sk_priority); > + err = l2cap_chan_send(chan, buf, len, sk->sk_priority, msg->msg_flags); > l2cap_chan_unlock(chan); > > +done: > + kfree(buf); > return err; > } somehow we need to optimize this last bit. I really do not like that we have to copy the data from the socket buffer into a private buffer and then have to copy into an SKB. The overhead of the extra buffer needs to be removed. However this code is now inside bluetooth.ko module and not an exported function. So it might be enough to have an internal l2cap_chan_send_fromiovec to optimize this one. The rest of the patch looks fine to me, but we can not add this extra penalty to every existing L2CAP socket user. Regards Marcel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v5 2/5] Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one 2014-06-02 15:00 [PATCH v5 0/5] Bluetooth LE 6LoWPAN using CoC Jukka Rissanen 2014-06-02 15:00 ` [PATCH v5 1/5] Bluetooth: Refactor l2cap_sock_sendmsg() to copy user buffer Jukka Rissanen @ 2014-06-02 15:00 ` Jukka Rissanen 2014-06-03 3:55 ` Marcel Holtmann 2014-06-02 15:00 ` [PATCH v5 3/5] Bluetooth: 6LoWPAN: Create a kernel module Jukka Rissanen ` (2 subsequent siblings) 4 siblings, 1 reply; 10+ messages in thread From: Jukka Rissanen @ 2014-06-02 15:00 UTC (permalink / raw) To: linux-bluetooth Create a CoC dynamically instead of one fixed channel for communication to peer devices. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> --- include/net/bluetooth/hci.h | 1 - include/net/bluetooth/hci_core.h | 1 - include/net/bluetooth/l2cap.h | 1 - net/bluetooth/6lowpan.c | 782 +++++++++++++++++++++++++++++---------- net/bluetooth/6lowpan.h | 47 --- net/bluetooth/hci_core.c | 45 --- net/bluetooth/hci_event.c | 3 - net/bluetooth/l2cap_core.c | 20 +- 8 files changed, 587 insertions(+), 313 deletions(-) delete mode 100644 net/bluetooth/6lowpan.h diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h index 16587dc..3f95aba 100644 --- a/include/net/bluetooth/hci.h +++ b/include/net/bluetooth/hci.h @@ -139,7 +139,6 @@ enum { HCI_PERIODIC_INQ, HCI_FAST_CONNECTABLE, HCI_BREDR_ENABLED, - HCI_6LOWPAN_ENABLED, HCI_LE_SCAN_INTERRUPTED, }; diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h index b386bf1..c3a2954 100644 --- a/include/net/bluetooth/hci_core.h +++ b/include/net/bluetooth/hci_core.h @@ -520,7 +520,6 @@ enum { HCI_CONN_AES_CCM, HCI_CONN_POWER_SAVE, HCI_CONN_REMOTE_OOB, - HCI_CONN_6LOWPAN, }; static inline bool hci_conn_ssp_enabled(struct hci_conn *conn) diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h index c84d770..aaa656d 100644 --- a/include/net/bluetooth/l2cap.h +++ b/include/net/bluetooth/l2cap.h @@ -137,7 +137,6 @@ struct l2cap_conninfo { #define L2CAP_FC_L2CAP 0x02 #define L2CAP_FC_CONNLESS 0x04 #define L2CAP_FC_A2MP 0x08 -#define L2CAP_FC_6LOWPAN 0x3e /* reserved and temporary value */ /* L2CAP Control Field bit masks */ #define L2CAP_CTRL_SAR 0xC000 diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c index d906016..d197bbe 100644 --- a/net/bluetooth/6lowpan.c +++ b/net/bluetooth/6lowpan.c @@ -1,5 +1,5 @@ /* - Copyright (c) 2013 Intel Corp. + Copyright (c) 2013-2014 Intel Corp. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License version 2 and @@ -14,6 +14,7 @@ #include <linux/if_arp.h> #include <linux/netdevice.h> #include <linux/etherdevice.h> +#include <linux/debugfs.h> #include <net/ipv6.h> #include <net/ip6_route.h> @@ -25,16 +26,21 @@ #include <net/bluetooth/hci_core.h> #include <net/bluetooth/l2cap.h> -#include "6lowpan.h" - #include "../ieee802154/6lowpan.h" /* for the compression support */ +#define VERSION "1.0" + +static struct dentry *lowpan_psm_debugfs; +static struct dentry *lowpan_control_debugfs; +static struct l2cap_ops bt_6lowpan_chan_ops; + #define IFACE_NAME_TEMPLATE "bt%d" #define EUI64_ADDR_LEN 8 struct skb_cb { struct in6_addr addr; - struct l2cap_conn *conn; + struct l2cap_chan *chan; + int status; }; #define lowpan_cb(skb) ((struct skb_cb *)((skb)->cb)) @@ -48,9 +54,19 @@ struct skb_cb { static LIST_HEAD(bt_6lowpan_devices); static DEFINE_RWLOCK(devices_lock); +/* If psm is set to 0 (default value), then 6lowpan is disabled. + * Other values are used to indicate a Protocol Service Multiplexer + * value for 6lowpan. + */ +static u16 psm_6lowpan; + +/* We are listening incoming connections via this channel + */ +static struct l2cap_chan *listen_chan; + struct lowpan_peer { struct list_head list; - struct l2cap_conn *conn; + struct l2cap_chan *chan; /* peer addresses in various formats */ unsigned char eui64_addr[EUI64_ADDR_LEN]; @@ -101,13 +117,26 @@ static inline struct lowpan_peer *peer_lookup_ba(struct lowpan_dev *dev, ba, type); list_for_each_entry_safe(peer, tmp, &dev->peers, list) { - BT_DBG("addr %pMR type %d", - &peer->conn->hcon->dst, peer->conn->hcon->dst_type); + BT_DBG("dst addr %pMR dst type %d", + &peer->chan->dst, peer->chan->dst_type); - if (bacmp(&peer->conn->hcon->dst, ba)) + if (bacmp(&peer->chan->dst, ba)) continue; - if (type == peer->conn->hcon->dst_type) + if (type == peer->chan->dst_type) + return peer; + } + + return NULL; +} + +static inline struct lowpan_peer *peer_lookup_chan(struct lowpan_dev *dev, + struct l2cap_chan *chan) +{ + struct lowpan_peer *peer, *tmp; + + list_for_each_entry_safe(peer, tmp, &dev->peers, list) { + if (peer->chan == chan) return peer; } @@ -120,7 +149,7 @@ static inline struct lowpan_peer *peer_lookup_conn(struct lowpan_dev *dev, struct lowpan_peer *peer, *tmp; list_for_each_entry_safe(peer, tmp, &dev->peers, list) { - if (peer->conn == conn) + if (peer->chan->conn == conn) return peer; } @@ -185,7 +214,7 @@ static int give_skb_to_upper(struct sk_buff *skb, struct net_device *dev) } static int process_data(struct sk_buff *skb, struct net_device *netdev, - struct l2cap_conn *conn) + struct l2cap_chan *chan) { const u8 *saddr, *daddr; u8 iphc0, iphc1; @@ -196,7 +225,7 @@ static int process_data(struct sk_buff *skb, struct net_device *netdev, dev = lowpan_dev(netdev); read_lock_irqsave(&devices_lock, flags); - peer = peer_lookup_conn(dev, conn); + peer = peer_lookup_chan(dev, chan); read_unlock_irqrestore(&devices_lock, flags); if (!peer) goto drop; @@ -225,7 +254,7 @@ drop: } static int recv_pkt(struct sk_buff *skb, struct net_device *dev, - struct l2cap_conn *conn) + struct l2cap_chan *chan) { struct sk_buff *local_skb; int ret; @@ -269,7 +298,7 @@ static int recv_pkt(struct sk_buff *skb, struct net_device *dev, if (!local_skb) goto drop; - ret = process_data(local_skb, dev, conn); + ret = process_data(local_skb, dev, chan); if (ret != NET_RX_SUCCESS) goto drop; @@ -286,147 +315,37 @@ static int recv_pkt(struct sk_buff *skb, struct net_device *dev, return NET_RX_SUCCESS; drop: + dev->stats.rx_dropped++; kfree_skb(skb); return NET_RX_DROP; } /* Packet from BT LE device */ -int bt_6lowpan_recv(struct l2cap_conn *conn, struct sk_buff *skb) +static int chan_recv_cb(struct l2cap_chan *chan, struct sk_buff *skb) { struct lowpan_dev *dev; struct lowpan_peer *peer; int err; - peer = lookup_peer(conn); + peer = lookup_peer(chan->conn); if (!peer) return -ENOENT; - dev = lookup_dev(conn); + dev = lookup_dev(chan->conn); if (!dev || !dev->netdev) return -ENOENT; - err = recv_pkt(skb, dev->netdev, conn); + err = recv_pkt(skb, dev->netdev, chan); + BT_DBG("recv pkt %d", err); return err; } -static inline int skbuff_copy(void *msg, int len, int count, int mtu, - struct sk_buff *skb, struct net_device *dev) -{ - struct sk_buff **frag; - int sent = 0; - - memcpy(skb_put(skb, count), msg, count); - - sent += count; - msg += count; - len -= count; - - dev->stats.tx_bytes += count; - dev->stats.tx_packets++; - - raw_dump_table(__func__, "Sending", skb->data, skb->len); - - /* Continuation fragments (no L2CAP header) */ - frag = &skb_shinfo(skb)->frag_list; - while (len > 0) { - struct sk_buff *tmp; - - count = min_t(unsigned int, mtu, len); - - tmp = bt_skb_alloc(count, GFP_ATOMIC); - if (!tmp) - return -ENOMEM; - - *frag = tmp; - - memcpy(skb_put(*frag, count), msg, count); - - raw_dump_table(__func__, "Sending fragment", - (*frag)->data, count); - - (*frag)->priority = skb->priority; - - sent += count; - msg += count; - len -= count; - - skb->len += (*frag)->len; - skb->data_len += (*frag)->len; - - frag = &(*frag)->next; - - dev->stats.tx_bytes += count; - dev->stats.tx_packets++; - } - - return sent; -} - -static struct sk_buff *create_pdu(struct l2cap_conn *conn, void *msg, - size_t len, u32 priority, - struct net_device *dev) -{ - struct sk_buff *skb; - int err, count; - struct l2cap_hdr *lh; - - /* FIXME: This mtu check should be not needed and atm is only used for - * testing purposes - */ - if (conn->mtu > (L2CAP_LE_MIN_MTU + L2CAP_HDR_SIZE)) - conn->mtu = L2CAP_LE_MIN_MTU + L2CAP_HDR_SIZE; - - count = min_t(unsigned int, (conn->mtu - L2CAP_HDR_SIZE), len); - - BT_DBG("conn %p len %zu mtu %d count %d", conn, len, conn->mtu, count); - - skb = bt_skb_alloc(count + L2CAP_HDR_SIZE, GFP_ATOMIC); - if (!skb) - return ERR_PTR(-ENOMEM); - - skb->priority = priority; - - lh = (struct l2cap_hdr *)skb_put(skb, L2CAP_HDR_SIZE); - lh->cid = cpu_to_le16(L2CAP_FC_6LOWPAN); - lh->len = cpu_to_le16(len); - - err = skbuff_copy(msg, len, count, conn->mtu, skb, dev); - if (unlikely(err < 0)) { - kfree_skb(skb); - BT_DBG("skbuff copy %d failed", err); - return ERR_PTR(err); - } - - return skb; -} - -static int conn_send(struct l2cap_conn *conn, - void *msg, size_t len, u32 priority, - struct net_device *dev) -{ - struct sk_buff *skb; - - skb = create_pdu(conn, msg, len, priority, dev); - if (IS_ERR(skb)) - return -EINVAL; - - BT_DBG("conn %p skb %p len %d priority %u", conn, skb, skb->len, - skb->priority); - - hci_send_acl(conn->hchan, skb, ACL_START); - - return 0; -} - static u8 get_addr_type_from_eui64(u8 byte) { - /* Is universal(0) or local(1) bit, */ - if (byte & 0x02) - return ADDR_LE_DEV_RANDOM; - - return ADDR_LE_DEV_PUBLIC; + /* Is universal(0) or local(1) bit */ + return ((byte & 0x02) ? BDADDR_LE_RANDOM : BDADDR_LE_PUBLIC); } static void copy_to_bdaddr(struct in6_addr *ip6_daddr, bdaddr_t *addr) @@ -475,7 +394,7 @@ static int header_create(struct sk_buff *skb, struct net_device *netdev, if (ipv6_addr_is_multicast(&hdr->daddr)) { memcpy(&lowpan_cb(skb)->addr, &hdr->daddr, sizeof(struct in6_addr)); - lowpan_cb(skb)->conn = NULL; + lowpan_cb(skb)->chan = NULL; } else { unsigned long flags; @@ -484,9 +403,8 @@ static int header_create(struct sk_buff *skb, struct net_device *netdev, */ convert_dest_bdaddr(&hdr->daddr, &addr, &addr_type); - BT_DBG("dest addr %pMR type %s IP %pI6c", &addr, - addr_type == ADDR_LE_DEV_PUBLIC ? "PUBLIC" : "RANDOM", - &hdr->daddr); + BT_DBG("dest addr %pMR type %d IP %pI6c", &addr, + addr_type, &hdr->daddr); read_lock_irqsave(&devices_lock, flags); peer = peer_lookup_ba(dev, &addr, addr_type); @@ -501,7 +419,7 @@ static int header_create(struct sk_buff *skb, struct net_device *netdev, memcpy(&lowpan_cb(skb)->addr, &hdr->daddr, sizeof(struct in6_addr)); - lowpan_cb(skb)->conn = peer->conn; + lowpan_cb(skb)->chan = peer->chan; } saddr = dev->netdev->dev_addr; @@ -510,14 +428,34 @@ static int header_create(struct sk_buff *skb, struct net_device *netdev, } /* Packet to BT LE device */ -static int send_pkt(struct l2cap_conn *conn, const void *saddr, - const void *daddr, struct sk_buff *skb, +static int send_pkt(struct l2cap_chan *chan, struct sk_buff *skb, struct net_device *netdev) { - raw_dump_table(__func__, "raw skb data dump before fragmentation", - skb->data, skb->len); + int err; + + /* Remember the skb so that we can send EAGAIN to the caller if + * we run out of credits. + */ + chan->data = skb; - return conn_send(conn, skb->data, skb->len, 0, netdev); + err = l2cap_chan_send(chan, skb->data, skb->len, 0, 0); + if (err > 0) { + netdev->stats.tx_bytes += err; + netdev->stats.tx_packets++; + return 0; + } + + if (!err) + err = lowpan_cb(skb)->status; + + if (err < 0) { + if (err == -EAGAIN) + netdev->stats.tx_dropped++; + else + netdev->stats.tx_errors++; + } + + return err; } static void send_mcast_pkt(struct sk_buff *skb, struct net_device *netdev) @@ -540,8 +478,7 @@ static void send_mcast_pkt(struct sk_buff *skb, struct net_device *netdev) list_for_each_entry_safe(pentry, ptmp, &dev->peers, list) { local_skb = skb_clone(skb, GFP_ATOMIC); - send_pkt(pentry->conn, netdev->dev_addr, - pentry->eui64_addr, local_skb, netdev); + send_pkt(pentry->chan, local_skb, netdev); kfree_skb(local_skb); } @@ -553,7 +490,6 @@ static void send_mcast_pkt(struct sk_buff *skb, struct net_device *netdev) static netdev_tx_t bt_xmit(struct sk_buff *skb, struct net_device *netdev) { int err = 0; - unsigned char *eui64_addr; struct lowpan_dev *dev; struct lowpan_peer *peer; bdaddr_t addr; @@ -568,21 +504,20 @@ static netdev_tx_t bt_xmit(struct sk_buff *skb, struct net_device *netdev) unsigned long flags; convert_dest_bdaddr(&lowpan_cb(skb)->addr, &addr, &addr_type); - eui64_addr = lowpan_cb(skb)->addr.s6_addr + 8; dev = lowpan_dev(netdev); read_lock_irqsave(&devices_lock, flags); peer = peer_lookup_ba(dev, &addr, addr_type); read_unlock_irqrestore(&devices_lock, flags); - BT_DBG("xmit %s to %pMR type %s IP %pI6c peer %p", - netdev->name, &addr, - addr_type == ADDR_LE_DEV_PUBLIC ? "PUBLIC" : "RANDOM", + BT_DBG("xmit %s to %pMR type %d IP %pI6c peer %p", + netdev->name, &addr, addr_type, &lowpan_cb(skb)->addr, peer); - if (peer && peer->conn) - err = send_pkt(peer->conn, netdev->dev_addr, - eui64_addr, skb, netdev); + if (peer && peer->chan) + err = send_pkt(peer->chan, skb, netdev); + else + err = -ENOENT; } dev_kfree_skb(skb); @@ -634,7 +569,7 @@ static void set_addr(u8 *eui, u8 *addr, u8 addr_type) eui[7] = addr[0]; /* Universal/local bit set, BT 6lowpan draft ch. 3.2.1 */ - if (addr_type == ADDR_LE_DEV_PUBLIC) + if (addr_type == BDADDR_LE_PUBLIC) eui[0] &= ~0x02; else eui[0] |= 0x02; @@ -673,26 +608,65 @@ static bool is_bt_6lowpan(struct hci_conn *hcon) if (hcon->type != LE_LINK) return false; - return test_bit(HCI_CONN_6LOWPAN, &hcon->flags); + if (!psm_6lowpan) + return false; + + return true; +} + +static struct l2cap_chan *chan_create(void) +{ + struct l2cap_chan *chan; + + chan = l2cap_chan_create(); + if (!chan) + return NULL; + + l2cap_chan_set_defaults(chan); + + chan->chan_type = L2CAP_CHAN_CONN_ORIENTED; + chan->mode = L2CAP_MODE_LE_FLOWCTL; + chan->omtu = 65535; + chan->imtu = chan->omtu; + chan->ops = &bt_6lowpan_chan_ops; + + return chan; } -static int add_peer_conn(struct l2cap_conn *conn, struct lowpan_dev *dev) +static struct l2cap_chan *chan_open(struct l2cap_chan *pchan) +{ + struct l2cap_chan *chan; + + chan = chan_create(); + if (!chan) + return NULL; + + chan->remote_mps = chan->omtu; + chan->mps = chan->omtu; + + chan->state = BT_CONNECTED; + + return chan; +} + +static struct l2cap_chan *add_peer_chan(struct l2cap_chan *chan, + struct lowpan_dev *dev) { struct lowpan_peer *peer; unsigned long flags; peer = kzalloc(sizeof(*peer), GFP_ATOMIC); if (!peer) - return -ENOMEM; + return NULL; - peer->conn = conn; + peer->chan = chan; memset(&peer->peer_addr, 0, sizeof(struct in6_addr)); /* RFC 2464 ch. 5 */ peer->peer_addr.s6_addr[0] = 0xFE; peer->peer_addr.s6_addr[1] = 0x80; - set_addr((u8 *)&peer->peer_addr.s6_addr + 8, conn->hcon->dst.b, - conn->hcon->dst_type); + set_addr((u8 *)&peer->peer_addr.s6_addr + 8, chan->dst.b, + chan->dst_type); memcpy(&peer->eui64_addr, (u8 *)&peer->peer_addr.s6_addr + 8, EUI64_ADDR_LEN); @@ -706,40 +680,24 @@ static int add_peer_conn(struct l2cap_conn *conn, struct lowpan_dev *dev) INIT_DELAYED_WORK(&dev->notify_peers, do_notify_peers); schedule_delayed_work(&dev->notify_peers, msecs_to_jiffies(100)); - return 0; + return peer->chan; } -/* This gets called when BT LE 6LoWPAN device is connected. We then - * create network device that acts as a proxy between BT LE device - * and kernel network stack. - */ -int bt_6lowpan_add_conn(struct l2cap_conn *conn) +static int setup_netdev(struct l2cap_chan *chan, struct lowpan_dev **dev) { - struct lowpan_peer *peer = NULL; - struct lowpan_dev *dev; struct net_device *netdev; int err = 0; unsigned long flags; - if (!is_bt_6lowpan(conn->hcon)) - return 0; - - peer = lookup_peer(conn); - if (peer) - return -EEXIST; - - dev = lookup_dev(conn); - if (dev) - return add_peer_conn(conn, dev); - - netdev = alloc_netdev(sizeof(*dev), IFACE_NAME_TEMPLATE, netdev_setup); + netdev = alloc_netdev(sizeof(struct lowpan_dev), IFACE_NAME_TEMPLATE, + netdev_setup); if (!netdev) return -ENOMEM; - set_dev_addr(netdev, &conn->hcon->src, conn->hcon->src_type); + set_dev_addr(netdev, &chan->src, chan->src_type); netdev->netdev_ops = &netdev_ops; - SET_NETDEV_DEV(netdev, &conn->hcon->dev); + SET_NETDEV_DEV(netdev, &chan->conn->hcon->dev); SET_NETDEV_DEVTYPE(netdev, &bt_type); err = register_netdev(netdev); @@ -749,28 +707,53 @@ int bt_6lowpan_add_conn(struct l2cap_conn *conn) goto out; } - BT_DBG("ifindex %d peer bdaddr %pMR my addr %pMR", - netdev->ifindex, &conn->hcon->dst, &conn->hcon->src); + BT_DBG("ifindex %d peer bdaddr %pMR type %d my addr %pMR type %d", + netdev->ifindex, &chan->dst, chan->dst_type, + &chan->src, chan->src_type); set_bit(__LINK_STATE_PRESENT, &netdev->state); - dev = netdev_priv(netdev); - dev->netdev = netdev; - dev->hdev = conn->hcon->hdev; - INIT_LIST_HEAD(&dev->peers); + *dev = netdev_priv(netdev); + (*dev)->netdev = netdev; + (*dev)->hdev = chan->conn->hcon->hdev; + INIT_LIST_HEAD(&(*dev)->peers); write_lock_irqsave(&devices_lock, flags); - INIT_LIST_HEAD(&dev->list); - list_add(&dev->list, &bt_6lowpan_devices); + INIT_LIST_HEAD(&(*dev)->list); + list_add(&(*dev)->list, &bt_6lowpan_devices); write_unlock_irqrestore(&devices_lock, flags); - ifup(netdev); - - return add_peer_conn(conn, dev); + return 0; out: return err; } +static inline void chan_ready_cb(struct l2cap_chan *chan) +{ + struct lowpan_dev *dev; + + dev = lookup_dev(chan->conn); + + BT_DBG("chan %p conn %p dev %p", chan, chan->conn, dev); + + if (!dev) { + if (setup_netdev(chan, &dev) < 0) { + l2cap_chan_del(chan, -ENOENT); + return; + } + } + + add_peer_chan(chan, dev); + ifup(dev->netdev); +} + +static inline struct l2cap_chan *chan_new_conn_cb(struct l2cap_chan *chan) +{ + BT_DBG("chan %p", chan); + + return chan_open(chan); +} + static void delete_netdev(struct work_struct *work) { struct lowpan_dev *entry = container_of(work, struct lowpan_dev, @@ -781,26 +764,38 @@ static void delete_netdev(struct work_struct *work) /* The entry pointer is deleted in device_event() */ } -int bt_6lowpan_del_conn(struct l2cap_conn *conn) +static void chan_close_cb(struct l2cap_chan *chan) { struct lowpan_dev *entry, *tmp; struct lowpan_dev *dev = NULL; struct lowpan_peer *peer; int err = -ENOENT; unsigned long flags; - bool last = false; + bool last = false, removed = true; - if (!conn || !is_bt_6lowpan(conn->hcon)) - return 0; + BT_DBG("chan %p conn %p", chan, chan->conn); + + if (chan->conn && chan->conn->hcon) { + if (!is_bt_6lowpan(chan->conn->hcon)) + return; + + /* If conn is set, then the netdev is also there and we should + * not remove it. + */ + removed = false; + } write_lock_irqsave(&devices_lock, flags); list_for_each_entry_safe(entry, tmp, &bt_6lowpan_devices, list) { dev = lowpan_dev(entry->netdev); - peer = peer_lookup_conn(dev, conn); + peer = peer_lookup_chan(dev, chan); if (peer) { last = peer_del(dev, peer); err = 0; + BT_DBG("dev %p removing %speer %p", dev, + last ? "last " : "1 ", peer); + kfree(peer); break; } } @@ -810,18 +805,393 @@ int bt_6lowpan_del_conn(struct l2cap_conn *conn) cancel_delayed_work_sync(&dev->notify_peers); - /* bt_6lowpan_del_conn() is called with hci dev lock held which - * means that we must delete the netdevice in worker thread. - */ - INIT_WORK(&entry->delete_netdev, delete_netdev); - schedule_work(&entry->delete_netdev); + if (!removed) { + INIT_WORK(&entry->delete_netdev, delete_netdev); + schedule_work(&entry->delete_netdev); + } } else { write_unlock_irqrestore(&devices_lock, flags); } + return; +} + +static void chan_state_change_cb(struct l2cap_chan *chan, int state, int err) +{ + BT_DBG("chan %p conn %p", chan, chan->conn); +} + +static struct sk_buff *chan_alloc_skb_cb(struct l2cap_chan *chan, + unsigned long len, int nb) +{ + return bt_skb_alloc(len, GFP_ATOMIC); +} + +static void chan_suspend_cb(struct l2cap_chan *chan) +{ + struct sk_buff *skb = chan->data; + + BT_DBG("chan %p conn %p skb %p", chan, chan->conn, skb); + + lowpan_cb(skb)->status = -EAGAIN; +} + +static void chan_resume_cb(struct l2cap_chan *chan) +{ + struct sk_buff *skb = chan->data; + + BT_DBG("chan %p conn %p skb %p", chan, chan->conn, skb); + + lowpan_cb(skb)->status = 0; +} + +static long chan_get_sndtimeo_cb(struct l2cap_chan *chan) +{ + return msecs_to_jiffies(1000); +} + +static void chan_teardown_cb(struct l2cap_chan *chan, int err) +{ + BT_DBG("chan %p conn %p err %d", chan, chan->conn, err); +} + +static struct l2cap_ops bt_6lowpan_chan_ops = { + .name = "L2CAP 6LoWPAN channel", + .new_connection = chan_new_conn_cb, + .recv = chan_recv_cb, + .teardown = chan_teardown_cb, + .close = chan_close_cb, + .state_change = chan_state_change_cb, + .ready = chan_ready_cb, + .resume = chan_resume_cb, + .suspend = chan_suspend_cb, + .get_sndtimeo = chan_get_sndtimeo_cb, + .alloc_skb = chan_alloc_skb_cb, + + .defer = l2cap_chan_no_defer, + .set_shutdown = l2cap_chan_no_set_shutdown, +}; + +static inline __u8 bdaddr_type(__u8 type) +{ + if (type == ADDR_LE_DEV_PUBLIC) + return BDADDR_LE_PUBLIC; + else + return BDADDR_LE_RANDOM; +} + +static int bt_6lowpan_connect(bdaddr_t *addr, u8 dst_type) +{ + struct l2cap_chan *pchan; + int err; + + pchan = chan_create(); + if (!pchan) + return -EINVAL; + + err = l2cap_chan_connect(pchan, cpu_to_le16(psm_6lowpan), 0, + addr, dst_type); + + BT_DBG("chan %p err %d", pchan, err); + return err; } +static void chan_close(struct l2cap_chan *chan, int reason) +{ + l2cap_chan_lock(chan); + l2cap_chan_close(chan, reason); + l2cap_chan_unlock(chan); + l2cap_chan_put(chan); +} + +static int bt_6lowpan_disconnect(struct l2cap_conn *conn, u8 dst_type) +{ + struct lowpan_peer *peer; + + BT_DBG("conn %p dst type %d", conn, dst_type); + + peer = lookup_peer(conn); + if (!peer) + return -ENOENT; + + chan_close(peer->chan, ENOENT); + + return 0; +} + +static struct l2cap_chan *bt_6lowpan_listen(void) +{ + bdaddr_t *addr = BDADDR_ANY; + struct l2cap_chan *pchan; + int err; + + if (psm_6lowpan == 0) + return NULL; + + pchan = chan_create(); + if (!pchan) + return NULL; + + pchan->state = BT_LISTEN; + pchan->src_type = BDADDR_LE_PUBLIC; + + BT_DBG("psm 0x%04x chan %p src type %d", psm_6lowpan, pchan, + pchan->src_type); + + err = l2cap_add_psm(pchan, addr, cpu_to_le16(psm_6lowpan)); + if (err) { + BT_ERR("psm cannot be added err %d", err); + return NULL; + } + + return pchan; +} + +static int get_l2cap_conn(char *buf, bdaddr_t *addr, u8 *addr_type, + struct l2cap_conn **conn) +{ + struct hci_conn *hcon; + struct hci_dev *hdev; + bdaddr_t *src = BDADDR_ANY; + int n; + + n = sscanf(buf, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx %hhu", + &addr->b[5], &addr->b[4], &addr->b[3], + &addr->b[2], &addr->b[1], &addr->b[0], + addr_type); + + if (n < 7) + return -EINVAL; + + hdev = hci_get_route(addr, src); + if (!hdev) + return -ENOENT; + + hci_dev_lock(hdev); + hcon = hci_conn_hash_lookup_ba(hdev, LE_LINK, addr); + hci_dev_unlock(hdev); + + if (!hcon) + return -ENOENT; + + *conn = (struct l2cap_conn *)hcon->l2cap_data; + + BT_DBG("conn %p dst %pMR type %d", *conn, &hcon->dst, hcon->dst_type); + + return 0; +} + +static void disconnect_all_peers(void) +{ + struct lowpan_dev *entry, *tmp_dev; + struct lowpan_peer *peer, *tmp_peer, *new_peer; + struct list_head peers; + unsigned long flags; + + INIT_LIST_HEAD(&peers); + + /* We make a separate list of peers as the close_cb() will + * modify the device peers list so it is better not to mess + * with the same list at the same time. + */ + + read_lock_irqsave(&devices_lock, flags); + + list_for_each_entry_safe(entry, tmp_dev, &bt_6lowpan_devices, list) { + list_for_each_entry_safe(peer, tmp_peer, &entry->peers, list) { + new_peer = kmalloc(sizeof(*new_peer), GFP_ATOMIC); + if (!new_peer) + break; + + new_peer->chan = peer->chan; + INIT_LIST_HEAD(&new_peer->list); + + list_add(&new_peer->list, &peers); + } + } + + read_unlock_irqrestore(&devices_lock, flags); + + list_for_each_entry_safe(peer, tmp_peer, &peers, list) { + chan_close(peer->chan, ENOENT); + kfree(peer); + } +} + +static ssize_t lowpan_psm_write(struct file *fp, const char __user *user_buffer, + size_t count, loff_t *position) +{ + char buf[32]; + size_t buf_size = min(count, sizeof(buf) - 1); + int ret; + unsigned long value; + u16 psm; + + if (copy_from_user(buf, user_buffer, buf_size)) + return -EFAULT; + + buf[buf_size] = '\0'; + + ret = kstrtoul(buf, 0, &value); + if (ret < 0) + return ret; + + psm = value; + if (psm == 0 || psm_6lowpan != psm) + /* Disconnect existing connections if 6lowpan is + * disabled (psm = 0), or if psm changes. + */ + disconnect_all_peers(); + + psm_6lowpan = psm; + + if (listen_chan) + chan_close(listen_chan, 0); + + listen_chan = bt_6lowpan_listen(); + + return count; +} + +static ssize_t lowpan_control_write(struct file *fp, + const char __user *user_buffer, + size_t count, + loff_t *position) +{ + char buf[32]; + size_t buf_size = min(count, sizeof(buf) - 1); + int ret; + bdaddr_t addr; + u8 addr_type; + struct l2cap_conn *conn = NULL; + + if (copy_from_user(buf, user_buffer, buf_size)) + return -EFAULT; + + buf[buf_size] = '\0'; + + if (memcmp(buf, "connect ", 8) == 0) { + + ret = get_l2cap_conn(&buf[8], &addr, &addr_type, &conn); + if (ret == -EINVAL) + return ret; + + if (listen_chan) { + chan_close(listen_chan, 0); + listen_chan = NULL; + } + + if (conn) { + struct lowpan_peer *peer; + + if (!is_bt_6lowpan(conn->hcon)) + return -EINVAL; + + peer = lookup_peer(conn); + if (peer) { + BT_DBG("6LoWPAN connection already exists"); + return -EALREADY; + } + + BT_DBG("conn %p dst %pMR type %d user %d", conn, + &conn->hcon->dst, conn->hcon->dst_type, + addr_type); + } + + ret = bt_6lowpan_connect(&addr, addr_type); + if (ret < 0) + return ret; + + return count; + } + + if (memcmp(buf, "disconnect ", 11) == 0) { + + ret = get_l2cap_conn(&buf[11], &addr, &addr_type, &conn); + if (ret < 0) + return ret; + + ret = bt_6lowpan_disconnect(conn, addr_type); + if (ret < 0) + return ret; + + return count; + } + + return count; +} + +static int lowpan_psm_show(struct seq_file *f, void *ptr) +{ + seq_printf(f, "%u\n", psm_6lowpan); + return 0; +} + +static int lowpan_control_show(struct seq_file *f, void *ptr) +{ + struct lowpan_dev *entry, *tmp_dev; + struct lowpan_peer *peer, *tmp_peer; + unsigned long flags; + + read_lock_irqsave(&devices_lock, flags); + + list_for_each_entry_safe(entry, tmp_dev, &bt_6lowpan_devices, list) { + list_for_each_entry_safe(peer, tmp_peer, &entry->peers, list) + seq_printf(f, "%pMR (type %u)\n", + &peer->chan->dst, peer->chan->dst_type); + } + + read_unlock_irqrestore(&devices_lock, flags); + + return 0; +} + +static int lowpan_psm_open(struct inode *inode, struct file *file) +{ + return single_open(file, lowpan_psm_show, inode->i_private); +} + +static int lowpan_control_open(struct inode *inode, struct file *file) +{ + return single_open(file, lowpan_control_show, inode->i_private); +} + +static const struct file_operations lowpan_psm_fops = { + .open = lowpan_psm_open, + .read = seq_read, + .write = lowpan_psm_write, + .llseek = seq_lseek, + .release = single_release, +}; + +static const struct file_operations lowpan_control_fops = { + .open = lowpan_control_open, + .read = seq_read, + .write = lowpan_control_write, + .llseek = seq_lseek, + .release = single_release, +}; + +static void setup_6lowpan(void) +{ + lowpan_psm_debugfs = debugfs_create_file("6lowpan_psm", 0644, + bt_debugfs, NULL, + &lowpan_psm_fops); + lowpan_control_debugfs = debugfs_create_file("6lowpan_control", 0644, + bt_debugfs, NULL, + &lowpan_control_fops); +} + +static void cleanup_6lowpan(void) +{ + debugfs_remove(lowpan_psm_debugfs); + debugfs_remove(lowpan_control_debugfs); + + if (listen_chan) + chan_close(listen_chan, 0); +} + static int device_event(struct notifier_block *unused, unsigned long event, void *ptr) { @@ -854,12 +1224,18 @@ static struct notifier_block bt_6lowpan_dev_notifier = { .notifier_call = device_event, }; -int bt_6lowpan_init(void) +static int __init bt_6lowpan_init(void) { + setup_6lowpan(); + return register_netdevice_notifier(&bt_6lowpan_dev_notifier); } void bt_6lowpan_cleanup(void) { + cleanup_6lowpan(); + + disconnect_devices(); + unregister_netdevice_notifier(&bt_6lowpan_dev_notifier); } diff --git a/net/bluetooth/6lowpan.h b/net/bluetooth/6lowpan.h deleted file mode 100644 index 5d281f1..0000000 --- a/net/bluetooth/6lowpan.h +++ /dev/null @@ -1,47 +0,0 @@ -/* - Copyright (c) 2013 Intel Corp. - - This program is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License version 2 and - only version 2 as published by the Free Software Foundation. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. -*/ - -#ifndef __6LOWPAN_H -#define __6LOWPAN_H - -#include <linux/errno.h> -#include <linux/skbuff.h> -#include <net/bluetooth/l2cap.h> - -#if IS_ENABLED(CONFIG_BT_6LOWPAN) -int bt_6lowpan_recv(struct l2cap_conn *conn, struct sk_buff *skb); -int bt_6lowpan_add_conn(struct l2cap_conn *conn); -int bt_6lowpan_del_conn(struct l2cap_conn *conn); -int bt_6lowpan_init(void); -void bt_6lowpan_cleanup(void); -#else -static int bt_6lowpan_recv(struct l2cap_conn *conn, struct sk_buff *skb) -{ - return -EOPNOTSUPP; -} -static int bt_6lowpan_add_conn(struct l2cap_conn *conn) -{ - return -EOPNOTSUPP; -} -int bt_6lowpan_del_conn(struct l2cap_conn *conn) -{ - return -EOPNOTSUPP; -} -static int bt_6lowpan_init(void) -{ - return -EOPNOTSUPP; -} -static void bt_6lowpan_cleanup(void) { } -#endif - -#endif /* __6LOWPAN_H */ diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c index 0a43cce..fb532ca 100644 --- a/net/bluetooth/hci_core.c +++ b/net/bluetooth/hci_core.c @@ -928,49 +928,6 @@ static int adv_channel_map_get(void *data, u64 *val) DEFINE_SIMPLE_ATTRIBUTE(adv_channel_map_fops, adv_channel_map_get, adv_channel_map_set, "%llu\n"); -static ssize_t lowpan_read(struct file *file, char __user *user_buf, - size_t count, loff_t *ppos) -{ - struct hci_dev *hdev = file->private_data; - char buf[3]; - - buf[0] = test_bit(HCI_6LOWPAN_ENABLED, &hdev->dev_flags) ? 'Y' : 'N'; - buf[1] = '\n'; - buf[2] = '\0'; - return simple_read_from_buffer(user_buf, count, ppos, buf, 2); -} - -static ssize_t lowpan_write(struct file *fp, const char __user *user_buffer, - size_t count, loff_t *position) -{ - struct hci_dev *hdev = fp->private_data; - bool enable; - char buf[32]; - size_t buf_size = min(count, (sizeof(buf)-1)); - - if (copy_from_user(buf, user_buffer, buf_size)) - return -EFAULT; - - buf[buf_size] = '\0'; - - if (strtobool(buf, &enable) < 0) - return -EINVAL; - - if (enable == test_bit(HCI_6LOWPAN_ENABLED, &hdev->dev_flags)) - return -EALREADY; - - change_bit(HCI_6LOWPAN_ENABLED, &hdev->dev_flags); - - return count; -} - -static const struct file_operations lowpan_debugfs_fops = { - .open = simple_open, - .read = lowpan_read, - .write = lowpan_write, - .llseek = default_llseek, -}; - static int le_auto_conn_show(struct seq_file *sf, void *ptr) { struct hci_dev *hdev = sf->private; @@ -1881,8 +1838,6 @@ static int __hci_init(struct hci_dev *hdev) hdev, &conn_max_interval_fops); debugfs_create_file("adv_channel_map", 0644, hdev->debugfs, hdev, &adv_channel_map_fops); - debugfs_create_file("6lowpan", 0644, hdev->debugfs, hdev, - &lowpan_debugfs_fops); debugfs_create_file("le_auto_conn", 0644, hdev->debugfs, hdev, &le_auto_conn_fops); debugfs_create_u16("discov_interleaved_timeout", 0644, diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index 1096e4c..2140143 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -4044,9 +4044,6 @@ static void hci_le_conn_complete_evt(struct hci_dev *hdev, struct sk_buff *skb) conn->handle = __le16_to_cpu(ev->handle); conn->state = BT_CONNECTED; - if (test_bit(HCI_6LOWPAN_ENABLED, &hdev->dev_flags)) - set_bit(HCI_CONN_6LOWPAN, &conn->flags); - hci_conn_add_sysfs(conn); hci_proto_connect_cfm(conn, ev->status); diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 495e6bc..1fde5cb 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -40,7 +40,6 @@ #include "smp.h" #include "a2mp.h" #include "amp.h" -#include "6lowpan.h" #define LE_FLOWCTL_MAX_CREDITS 65535 @@ -205,6 +204,7 @@ done: write_unlock(&chan_list_lock); return err; } +EXPORT_SYMBOL_GPL(l2cap_add_psm); int l2cap_add_scid(struct l2cap_chan *chan, __u16 scid) { @@ -437,6 +437,7 @@ struct l2cap_chan *l2cap_chan_create(void) return chan; } +EXPORT_SYMBOL_GPL(l2cap_chan_create); static void l2cap_chan_destroy(struct kref *kref) { @@ -464,6 +465,7 @@ void l2cap_chan_put(struct l2cap_chan *c) kref_put(&c->kref, l2cap_chan_destroy); } +EXPORT_SYMBOL_GPL(l2cap_chan_put); void l2cap_chan_set_defaults(struct l2cap_chan *chan) { @@ -482,6 +484,7 @@ void l2cap_chan_set_defaults(struct l2cap_chan *chan) set_bit(FLAG_FORCE_ACTIVE, &chan->flags); } +EXPORT_SYMBOL_GPL(l2cap_chan_set_defaults); static void l2cap_le_flowctl_init(struct l2cap_chan *chan) { @@ -614,6 +617,7 @@ void l2cap_chan_del(struct l2cap_chan *chan, int err) return; } +EXPORT_SYMBOL_GPL(l2cap_chan_del); void l2cap_conn_update_id_addr(struct hci_conn *hcon) { @@ -717,6 +721,7 @@ void l2cap_chan_close(struct l2cap_chan *chan, int reason) break; } } +EXPORT_SYMBOL(l2cap_chan_close); static inline u8 l2cap_get_auth_type(struct l2cap_chan *chan) { @@ -1460,8 +1465,6 @@ static void l2cap_le_conn_ready(struct l2cap_conn *conn) BT_DBG(""); - bt_6lowpan_add_conn(conn); - /* Check if we have socket listening on cid */ pchan = l2cap_global_chan_by_scid(BT_LISTEN, L2CAP_CID_ATT, &hcon->src, &hcon->dst); @@ -2565,6 +2568,7 @@ int l2cap_chan_send(struct l2cap_chan *chan, const void *buf, size_t len, return err; } +EXPORT_SYMBOL_GPL(l2cap_chan_send); static void l2cap_send_srej(struct l2cap_chan *chan, u16 txseq) { @@ -6943,10 +6947,6 @@ static void l2cap_recv_frame(struct l2cap_conn *conn, struct sk_buff *skb) l2cap_conn_del(conn->hcon, EACCES); break; - case L2CAP_FC_6LOWPAN: - bt_6lowpan_recv(conn, skb); - break; - default: l2cap_data_channel(conn, cid, skb); break; @@ -7193,6 +7193,7 @@ done: hci_dev_put(hdev); return err; } +EXPORT_SYMBOL_GPL(l2cap_chan_connect); /* ---- L2CAP interface with lower layer (HCI) ---- */ @@ -7255,8 +7256,6 @@ void l2cap_disconn_cfm(struct hci_conn *hcon, u8 reason) { BT_DBG("hcon %p reason %d", hcon, reason); - bt_6lowpan_del_conn(hcon->l2cap_data); - l2cap_conn_del(hcon, bt_to_errno(reason)); } @@ -7539,14 +7538,11 @@ int __init l2cap_init(void) debugfs_create_u16("l2cap_le_default_mps", 0466, bt_debugfs, &le_default_mps); - bt_6lowpan_init(); - return 0; } void l2cap_exit(void) { - bt_6lowpan_cleanup(); debugfs_remove(l2cap_debugfs); l2cap_cleanup_sockets(); } -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v5 2/5] Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one 2014-06-02 15:00 ` [PATCH v5 2/5] Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one Jukka Rissanen @ 2014-06-03 3:55 ` Marcel Holtmann 0 siblings, 0 replies; 10+ messages in thread From: Marcel Holtmann @ 2014-06-03 3:55 UTC (permalink / raw) To: Jukka Rissanen; +Cc: linux-bluetooth Hi Jukka, > Create a CoC dynamically instead of one fixed channel for communication > to peer devices. > > Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> > --- > include/net/bluetooth/hci.h | 1 - > include/net/bluetooth/hci_core.h | 1 - > include/net/bluetooth/l2cap.h | 1 - > net/bluetooth/6lowpan.c | 782 +++++++++++++++++++++++++++++---------- > net/bluetooth/6lowpan.h | 47 --- > net/bluetooth/hci_core.c | 45 --- > net/bluetooth/hci_event.c | 3 - > net/bluetooth/l2cap_core.c | 20 +- > 8 files changed, 587 insertions(+), 313 deletions(-) > delete mode 100644 net/bluetooth/6lowpan.h > > diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h > index 16587dc..3f95aba 100644 > --- a/include/net/bluetooth/hci.h > +++ b/include/net/bluetooth/hci.h > @@ -139,7 +139,6 @@ enum { > HCI_PERIODIC_INQ, > HCI_FAST_CONNECTABLE, > HCI_BREDR_ENABLED, > - HCI_6LOWPAN_ENABLED, > HCI_LE_SCAN_INTERRUPTED, > }; > > diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h > index b386bf1..c3a2954 100644 > --- a/include/net/bluetooth/hci_core.h > +++ b/include/net/bluetooth/hci_core.h > @@ -520,7 +520,6 @@ enum { > HCI_CONN_AES_CCM, > HCI_CONN_POWER_SAVE, > HCI_CONN_REMOTE_OOB, > - HCI_CONN_6LOWPAN, > }; > > static inline bool hci_conn_ssp_enabled(struct hci_conn *conn) > diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h > index c84d770..aaa656d 100644 > --- a/include/net/bluetooth/l2cap.h > +++ b/include/net/bluetooth/l2cap.h > @@ -137,7 +137,6 @@ struct l2cap_conninfo { > #define L2CAP_FC_L2CAP 0x02 > #define L2CAP_FC_CONNLESS 0x04 > #define L2CAP_FC_A2MP 0x08 > -#define L2CAP_FC_6LOWPAN 0x3e /* reserved and temporary value */ > > /* L2CAP Control Field bit masks */ > #define L2CAP_CTRL_SAR 0xC000 > diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c > index d906016..d197bbe 100644 > --- a/net/bluetooth/6lowpan.c > +++ b/net/bluetooth/6lowpan.c > @@ -1,5 +1,5 @@ > /* > - Copyright (c) 2013 Intel Corp. > + Copyright (c) 2013-2014 Intel Corp. > > This program is free software; you can redistribute it and/or modify > it under the terms of the GNU General Public License version 2 and > @@ -14,6 +14,7 @@ > #include <linux/if_arp.h> > #include <linux/netdevice.h> > #include <linux/etherdevice.h> > +#include <linux/debugfs.h> > > #include <net/ipv6.h> > #include <net/ip6_route.h> > @@ -25,16 +26,21 @@ > #include <net/bluetooth/hci_core.h> > #include <net/bluetooth/l2cap.h> > > -#include "6lowpan.h" > - > #include "../ieee802154/6lowpan.h" /* for the compression support */ > > +#define VERSION "1.0" > + > +static struct dentry *lowpan_psm_debugfs; > +static struct dentry *lowpan_control_debugfs; > +static struct l2cap_ops bt_6lowpan_chan_ops; > + > #define IFACE_NAME_TEMPLATE "bt%d" > #define EUI64_ADDR_LEN 8 > > struct skb_cb { > struct in6_addr addr; > - struct l2cap_conn *conn; > + struct l2cap_chan *chan; > + int status; > }; > #define lowpan_cb(skb) ((struct skb_cb *)((skb)->cb)) > > @@ -48,9 +54,19 @@ struct skb_cb { > static LIST_HEAD(bt_6lowpan_devices); > static DEFINE_RWLOCK(devices_lock); > > +/* If psm is set to 0 (default value), then 6lowpan is disabled. > + * Other values are used to indicate a Protocol Service Multiplexer > + * value for 6lowpan. > + */ > +static u16 psm_6lowpan; > + > +/* We are listening incoming connections via this channel > + */ > +static struct l2cap_chan *listen_chan; > + > struct lowpan_peer { > struct list_head list; > - struct l2cap_conn *conn; > + struct l2cap_chan *chan; > > /* peer addresses in various formats */ > unsigned char eui64_addr[EUI64_ADDR_LEN]; > @@ -101,13 +117,26 @@ static inline struct lowpan_peer *peer_lookup_ba(struct lowpan_dev *dev, > ba, type); > > list_for_each_entry_safe(peer, tmp, &dev->peers, list) { > - BT_DBG("addr %pMR type %d", > - &peer->conn->hcon->dst, peer->conn->hcon->dst_type); > + BT_DBG("dst addr %pMR dst type %d", > + &peer->chan->dst, peer->chan->dst_type); > > - if (bacmp(&peer->conn->hcon->dst, ba)) > + if (bacmp(&peer->chan->dst, ba)) > continue; > > - if (type == peer->conn->hcon->dst_type) > + if (type == peer->chan->dst_type) > + return peer; > + } > + > + return NULL; > +} > + > +static inline struct lowpan_peer *peer_lookup_chan(struct lowpan_dev *dev, > + struct l2cap_chan *chan) > +{ > + struct lowpan_peer *peer, *tmp; > + > + list_for_each_entry_safe(peer, tmp, &dev->peers, list) { > + if (peer->chan == chan) > return peer; > } > > @@ -120,7 +149,7 @@ static inline struct lowpan_peer *peer_lookup_conn(struct lowpan_dev *dev, > struct lowpan_peer *peer, *tmp; > > list_for_each_entry_safe(peer, tmp, &dev->peers, list) { > - if (peer->conn == conn) > + if (peer->chan->conn == conn) > return peer; > } > > @@ -185,7 +214,7 @@ static int give_skb_to_upper(struct sk_buff *skb, struct net_device *dev) > } > > static int process_data(struct sk_buff *skb, struct net_device *netdev, > - struct l2cap_conn *conn) > + struct l2cap_chan *chan) > { > const u8 *saddr, *daddr; > u8 iphc0, iphc1; > @@ -196,7 +225,7 @@ static int process_data(struct sk_buff *skb, struct net_device *netdev, > dev = lowpan_dev(netdev); > > read_lock_irqsave(&devices_lock, flags); > - peer = peer_lookup_conn(dev, conn); > + peer = peer_lookup_chan(dev, chan); > read_unlock_irqrestore(&devices_lock, flags); > if (!peer) > goto drop; > @@ -225,7 +254,7 @@ drop: > } > > static int recv_pkt(struct sk_buff *skb, struct net_device *dev, > - struct l2cap_conn *conn) > + struct l2cap_chan *chan) > { > struct sk_buff *local_skb; > int ret; > @@ -269,7 +298,7 @@ static int recv_pkt(struct sk_buff *skb, struct net_device *dev, > if (!local_skb) > goto drop; > > - ret = process_data(local_skb, dev, conn); > + ret = process_data(local_skb, dev, chan); > if (ret != NET_RX_SUCCESS) > goto drop; > > @@ -286,147 +315,37 @@ static int recv_pkt(struct sk_buff *skb, struct net_device *dev, > return NET_RX_SUCCESS; > > drop: > + dev->stats.rx_dropped++; > kfree_skb(skb); > return NET_RX_DROP; > } > > /* Packet from BT LE device */ > -int bt_6lowpan_recv(struct l2cap_conn *conn, struct sk_buff *skb) > +static int chan_recv_cb(struct l2cap_chan *chan, struct sk_buff *skb) > { > struct lowpan_dev *dev; > struct lowpan_peer *peer; > int err; > > - peer = lookup_peer(conn); > + peer = lookup_peer(chan->conn); > if (!peer) > return -ENOENT; > > - dev = lookup_dev(conn); > + dev = lookup_dev(chan->conn); > if (!dev || !dev->netdev) > return -ENOENT; > > - err = recv_pkt(skb, dev->netdev, conn); > + err = recv_pkt(skb, dev->netdev, chan); > + > BT_DBG("recv pkt %d", err); > > return err; > } > > -static inline int skbuff_copy(void *msg, int len, int count, int mtu, > - struct sk_buff *skb, struct net_device *dev) > -{ > - struct sk_buff **frag; > - int sent = 0; > - > - memcpy(skb_put(skb, count), msg, count); > - > - sent += count; > - msg += count; > - len -= count; > - > - dev->stats.tx_bytes += count; > - dev->stats.tx_packets++; > - > - raw_dump_table(__func__, "Sending", skb->data, skb->len); > - > - /* Continuation fragments (no L2CAP header) */ > - frag = &skb_shinfo(skb)->frag_list; > - while (len > 0) { > - struct sk_buff *tmp; > - > - count = min_t(unsigned int, mtu, len); > - > - tmp = bt_skb_alloc(count, GFP_ATOMIC); > - if (!tmp) > - return -ENOMEM; > - > - *frag = tmp; > - > - memcpy(skb_put(*frag, count), msg, count); > - > - raw_dump_table(__func__, "Sending fragment", > - (*frag)->data, count); > - > - (*frag)->priority = skb->priority; > - > - sent += count; > - msg += count; > - len -= count; > - > - skb->len += (*frag)->len; > - skb->data_len += (*frag)->len; > - > - frag = &(*frag)->next; > - > - dev->stats.tx_bytes += count; > - dev->stats.tx_packets++; > - } > - > - return sent; > -} > - > -static struct sk_buff *create_pdu(struct l2cap_conn *conn, void *msg, > - size_t len, u32 priority, > - struct net_device *dev) > -{ > - struct sk_buff *skb; > - int err, count; > - struct l2cap_hdr *lh; > - > - /* FIXME: This mtu check should be not needed and atm is only used for > - * testing purposes > - */ > - if (conn->mtu > (L2CAP_LE_MIN_MTU + L2CAP_HDR_SIZE)) > - conn->mtu = L2CAP_LE_MIN_MTU + L2CAP_HDR_SIZE; > - > - count = min_t(unsigned int, (conn->mtu - L2CAP_HDR_SIZE), len); > - > - BT_DBG("conn %p len %zu mtu %d count %d", conn, len, conn->mtu, count); > - > - skb = bt_skb_alloc(count + L2CAP_HDR_SIZE, GFP_ATOMIC); > - if (!skb) > - return ERR_PTR(-ENOMEM); > - > - skb->priority = priority; > - > - lh = (struct l2cap_hdr *)skb_put(skb, L2CAP_HDR_SIZE); > - lh->cid = cpu_to_le16(L2CAP_FC_6LOWPAN); > - lh->len = cpu_to_le16(len); > - > - err = skbuff_copy(msg, len, count, conn->mtu, skb, dev); > - if (unlikely(err < 0)) { > - kfree_skb(skb); > - BT_DBG("skbuff copy %d failed", err); > - return ERR_PTR(err); > - } > - > - return skb; > -} > - > -static int conn_send(struct l2cap_conn *conn, > - void *msg, size_t len, u32 priority, > - struct net_device *dev) > -{ > - struct sk_buff *skb; > - > - skb = create_pdu(conn, msg, len, priority, dev); > - if (IS_ERR(skb)) > - return -EINVAL; > - > - BT_DBG("conn %p skb %p len %d priority %u", conn, skb, skb->len, > - skb->priority); > - > - hci_send_acl(conn->hchan, skb, ACL_START); > - > - return 0; > -} > - > static u8 get_addr_type_from_eui64(u8 byte) > { > - /* Is universal(0) or local(1) bit, */ > - if (byte & 0x02) > - return ADDR_LE_DEV_RANDOM; > - > - return ADDR_LE_DEV_PUBLIC; > + /* Is universal(0) or local(1) bit */ > + return ((byte & 0x02) ? BDADDR_LE_RANDOM : BDADDR_LE_PUBLIC); > } > > static void copy_to_bdaddr(struct in6_addr *ip6_daddr, bdaddr_t *addr) > @@ -475,7 +394,7 @@ static int header_create(struct sk_buff *skb, struct net_device *netdev, > if (ipv6_addr_is_multicast(&hdr->daddr)) { > memcpy(&lowpan_cb(skb)->addr, &hdr->daddr, > sizeof(struct in6_addr)); > - lowpan_cb(skb)->conn = NULL; > + lowpan_cb(skb)->chan = NULL; > } else { > unsigned long flags; > > @@ -484,9 +403,8 @@ static int header_create(struct sk_buff *skb, struct net_device *netdev, > */ > convert_dest_bdaddr(&hdr->daddr, &addr, &addr_type); > > - BT_DBG("dest addr %pMR type %s IP %pI6c", &addr, > - addr_type == ADDR_LE_DEV_PUBLIC ? "PUBLIC" : "RANDOM", > - &hdr->daddr); > + BT_DBG("dest addr %pMR type %d IP %pI6c", &addr, > + addr_type, &hdr->daddr); > > read_lock_irqsave(&devices_lock, flags); > peer = peer_lookup_ba(dev, &addr, addr_type); > @@ -501,7 +419,7 @@ static int header_create(struct sk_buff *skb, struct net_device *netdev, > > memcpy(&lowpan_cb(skb)->addr, &hdr->daddr, > sizeof(struct in6_addr)); > - lowpan_cb(skb)->conn = peer->conn; > + lowpan_cb(skb)->chan = peer->chan; > } > > saddr = dev->netdev->dev_addr; > @@ -510,14 +428,34 @@ static int header_create(struct sk_buff *skb, struct net_device *netdev, > } > > /* Packet to BT LE device */ > -static int send_pkt(struct l2cap_conn *conn, const void *saddr, > - const void *daddr, struct sk_buff *skb, > +static int send_pkt(struct l2cap_chan *chan, struct sk_buff *skb, > struct net_device *netdev) > { > - raw_dump_table(__func__, "raw skb data dump before fragmentation", > - skb->data, skb->len); > + int err; > + > + /* Remember the skb so that we can send EAGAIN to the caller if > + * we run out of credits. > + */ > + chan->data = skb; > > - return conn_send(conn, skb->data, skb->len, 0, netdev); > + err = l2cap_chan_send(chan, skb->data, skb->len, 0, 0); > + if (err > 0) { > + netdev->stats.tx_bytes += err; > + netdev->stats.tx_packets++; > + return 0; > + } > + > + if (!err) > + err = lowpan_cb(skb)->status; > + > + if (err < 0) { > + if (err == -EAGAIN) > + netdev->stats.tx_dropped++; > + else > + netdev->stats.tx_errors++; > + } > + > + return err; > } > > static void send_mcast_pkt(struct sk_buff *skb, struct net_device *netdev) > @@ -540,8 +478,7 @@ static void send_mcast_pkt(struct sk_buff *skb, struct net_device *netdev) > list_for_each_entry_safe(pentry, ptmp, &dev->peers, list) { > local_skb = skb_clone(skb, GFP_ATOMIC); > > - send_pkt(pentry->conn, netdev->dev_addr, > - pentry->eui64_addr, local_skb, netdev); > + send_pkt(pentry->chan, local_skb, netdev); > > kfree_skb(local_skb); > } > @@ -553,7 +490,6 @@ static void send_mcast_pkt(struct sk_buff *skb, struct net_device *netdev) > static netdev_tx_t bt_xmit(struct sk_buff *skb, struct net_device *netdev) > { > int err = 0; > - unsigned char *eui64_addr; > struct lowpan_dev *dev; > struct lowpan_peer *peer; > bdaddr_t addr; > @@ -568,21 +504,20 @@ static netdev_tx_t bt_xmit(struct sk_buff *skb, struct net_device *netdev) > unsigned long flags; > > convert_dest_bdaddr(&lowpan_cb(skb)->addr, &addr, &addr_type); > - eui64_addr = lowpan_cb(skb)->addr.s6_addr + 8; > dev = lowpan_dev(netdev); > > read_lock_irqsave(&devices_lock, flags); > peer = peer_lookup_ba(dev, &addr, addr_type); > read_unlock_irqrestore(&devices_lock, flags); > > - BT_DBG("xmit %s to %pMR type %s IP %pI6c peer %p", > - netdev->name, &addr, > - addr_type == ADDR_LE_DEV_PUBLIC ? "PUBLIC" : "RANDOM", > + BT_DBG("xmit %s to %pMR type %d IP %pI6c peer %p", > + netdev->name, &addr, addr_type, > &lowpan_cb(skb)->addr, peer); > > - if (peer && peer->conn) > - err = send_pkt(peer->conn, netdev->dev_addr, > - eui64_addr, skb, netdev); > + if (peer && peer->chan) > + err = send_pkt(peer->chan, skb, netdev); > + else > + err = -ENOENT; > } > dev_kfree_skb(skb); > > @@ -634,7 +569,7 @@ static void set_addr(u8 *eui, u8 *addr, u8 addr_type) > eui[7] = addr[0]; > > /* Universal/local bit set, BT 6lowpan draft ch. 3.2.1 */ > - if (addr_type == ADDR_LE_DEV_PUBLIC) > + if (addr_type == BDADDR_LE_PUBLIC) > eui[0] &= ~0x02; > else > eui[0] |= 0x02; > @@ -673,26 +608,65 @@ static bool is_bt_6lowpan(struct hci_conn *hcon) > if (hcon->type != LE_LINK) > return false; > > - return test_bit(HCI_CONN_6LOWPAN, &hcon->flags); > + if (!psm_6lowpan) > + return false; > + > + return true; > +} > + > +static struct l2cap_chan *chan_create(void) > +{ > + struct l2cap_chan *chan; > + > + chan = l2cap_chan_create(); > + if (!chan) > + return NULL; > + > + l2cap_chan_set_defaults(chan); > + > + chan->chan_type = L2CAP_CHAN_CONN_ORIENTED; > + chan->mode = L2CAP_MODE_LE_FLOWCTL; > + chan->omtu = 65535; > + chan->imtu = chan->omtu; > + chan->ops = &bt_6lowpan_chan_ops; > + > + return chan; > } > > -static int add_peer_conn(struct l2cap_conn *conn, struct lowpan_dev *dev) > +static struct l2cap_chan *chan_open(struct l2cap_chan *pchan) > +{ > + struct l2cap_chan *chan; > + > + chan = chan_create(); > + if (!chan) > + return NULL; > + > + chan->remote_mps = chan->omtu; > + chan->mps = chan->omtu; > + > + chan->state = BT_CONNECTED; > + > + return chan; > +} > + > +static struct l2cap_chan *add_peer_chan(struct l2cap_chan *chan, > + struct lowpan_dev *dev) > { > struct lowpan_peer *peer; > unsigned long flags; > > peer = kzalloc(sizeof(*peer), GFP_ATOMIC); > if (!peer) > - return -ENOMEM; > + return NULL; > > - peer->conn = conn; > + peer->chan = chan; > memset(&peer->peer_addr, 0, sizeof(struct in6_addr)); > > /* RFC 2464 ch. 5 */ > peer->peer_addr.s6_addr[0] = 0xFE; > peer->peer_addr.s6_addr[1] = 0x80; > - set_addr((u8 *)&peer->peer_addr.s6_addr + 8, conn->hcon->dst.b, > - conn->hcon->dst_type); > + set_addr((u8 *)&peer->peer_addr.s6_addr + 8, chan->dst.b, > + chan->dst_type); > > memcpy(&peer->eui64_addr, (u8 *)&peer->peer_addr.s6_addr + 8, > EUI64_ADDR_LEN); > @@ -706,40 +680,24 @@ static int add_peer_conn(struct l2cap_conn *conn, struct lowpan_dev *dev) > INIT_DELAYED_WORK(&dev->notify_peers, do_notify_peers); > schedule_delayed_work(&dev->notify_peers, msecs_to_jiffies(100)); > > - return 0; > + return peer->chan; > } > > -/* This gets called when BT LE 6LoWPAN device is connected. We then > - * create network device that acts as a proxy between BT LE device > - * and kernel network stack. > - */ > -int bt_6lowpan_add_conn(struct l2cap_conn *conn) > +static int setup_netdev(struct l2cap_chan *chan, struct lowpan_dev **dev) > { > - struct lowpan_peer *peer = NULL; > - struct lowpan_dev *dev; > struct net_device *netdev; > int err = 0; > unsigned long flags; > > - if (!is_bt_6lowpan(conn->hcon)) > - return 0; > - > - peer = lookup_peer(conn); > - if (peer) > - return -EEXIST; > - > - dev = lookup_dev(conn); > - if (dev) > - return add_peer_conn(conn, dev); > - > - netdev = alloc_netdev(sizeof(*dev), IFACE_NAME_TEMPLATE, netdev_setup); > + netdev = alloc_netdev(sizeof(struct lowpan_dev), IFACE_NAME_TEMPLATE, > + netdev_setup); > if (!netdev) > return -ENOMEM; > > - set_dev_addr(netdev, &conn->hcon->src, conn->hcon->src_type); > + set_dev_addr(netdev, &chan->src, chan->src_type); > > netdev->netdev_ops = &netdev_ops; > - SET_NETDEV_DEV(netdev, &conn->hcon->dev); > + SET_NETDEV_DEV(netdev, &chan->conn->hcon->dev); > SET_NETDEV_DEVTYPE(netdev, &bt_type); > > err = register_netdev(netdev); > @@ -749,28 +707,53 @@ int bt_6lowpan_add_conn(struct l2cap_conn *conn) > goto out; > } > > - BT_DBG("ifindex %d peer bdaddr %pMR my addr %pMR", > - netdev->ifindex, &conn->hcon->dst, &conn->hcon->src); > + BT_DBG("ifindex %d peer bdaddr %pMR type %d my addr %pMR type %d", > + netdev->ifindex, &chan->dst, chan->dst_type, > + &chan->src, chan->src_type); > set_bit(__LINK_STATE_PRESENT, &netdev->state); > > - dev = netdev_priv(netdev); > - dev->netdev = netdev; > - dev->hdev = conn->hcon->hdev; > - INIT_LIST_HEAD(&dev->peers); > + *dev = netdev_priv(netdev); > + (*dev)->netdev = netdev; > + (*dev)->hdev = chan->conn->hcon->hdev; > + INIT_LIST_HEAD(&(*dev)->peers); > > write_lock_irqsave(&devices_lock, flags); > - INIT_LIST_HEAD(&dev->list); > - list_add(&dev->list, &bt_6lowpan_devices); > + INIT_LIST_HEAD(&(*dev)->list); > + list_add(&(*dev)->list, &bt_6lowpan_devices); > write_unlock_irqrestore(&devices_lock, flags); > > - ifup(netdev); > - > - return add_peer_conn(conn, dev); > + return 0; > > out: > return err; > } > > +static inline void chan_ready_cb(struct l2cap_chan *chan) > +{ > + struct lowpan_dev *dev; > + > + dev = lookup_dev(chan->conn); > + > + BT_DBG("chan %p conn %p dev %p", chan, chan->conn, dev); > + > + if (!dev) { > + if (setup_netdev(chan, &dev) < 0) { > + l2cap_chan_del(chan, -ENOENT); > + return; > + } > + } > + > + add_peer_chan(chan, dev); > + ifup(dev->netdev); > +} > + > +static inline struct l2cap_chan *chan_new_conn_cb(struct l2cap_chan *chan) > +{ > + BT_DBG("chan %p", chan); > + > + return chan_open(chan); > +} > + > static void delete_netdev(struct work_struct *work) > { > struct lowpan_dev *entry = container_of(work, struct lowpan_dev, > @@ -781,26 +764,38 @@ static void delete_netdev(struct work_struct *work) > /* The entry pointer is deleted in device_event() */ > } > > -int bt_6lowpan_del_conn(struct l2cap_conn *conn) > +static void chan_close_cb(struct l2cap_chan *chan) > { > struct lowpan_dev *entry, *tmp; > struct lowpan_dev *dev = NULL; > struct lowpan_peer *peer; > int err = -ENOENT; > unsigned long flags; > - bool last = false; > + bool last = false, removed = true; > > - if (!conn || !is_bt_6lowpan(conn->hcon)) > - return 0; > + BT_DBG("chan %p conn %p", chan, chan->conn); > + > + if (chan->conn && chan->conn->hcon) { > + if (!is_bt_6lowpan(chan->conn->hcon)) > + return; > + > + /* If conn is set, then the netdev is also there and we should > + * not remove it. > + */ > + removed = false; > + } > > write_lock_irqsave(&devices_lock, flags); > > list_for_each_entry_safe(entry, tmp, &bt_6lowpan_devices, list) { > dev = lowpan_dev(entry->netdev); > - peer = peer_lookup_conn(dev, conn); > + peer = peer_lookup_chan(dev, chan); > if (peer) { > last = peer_del(dev, peer); > err = 0; > + BT_DBG("dev %p removing %speer %p", dev, > + last ? "last " : "1 ", peer); > + kfree(peer); > break; > } > } > @@ -810,18 +805,393 @@ int bt_6lowpan_del_conn(struct l2cap_conn *conn) > > cancel_delayed_work_sync(&dev->notify_peers); > > - /* bt_6lowpan_del_conn() is called with hci dev lock held which > - * means that we must delete the netdevice in worker thread. > - */ > - INIT_WORK(&entry->delete_netdev, delete_netdev); > - schedule_work(&entry->delete_netdev); > + if (!removed) { > + INIT_WORK(&entry->delete_netdev, delete_netdev); > + schedule_work(&entry->delete_netdev); > + } > } else { > write_unlock_irqrestore(&devices_lock, flags); > } > > + return; > +} > + > +static void chan_state_change_cb(struct l2cap_chan *chan, int state, int err) > +{ > + BT_DBG("chan %p conn %p", chan, chan->conn); > +} > + > +static struct sk_buff *chan_alloc_skb_cb(struct l2cap_chan *chan, > + unsigned long len, int nb) > +{ > + return bt_skb_alloc(len, GFP_ATOMIC); > +} > + > +static void chan_suspend_cb(struct l2cap_chan *chan) > +{ > + struct sk_buff *skb = chan->data; > + > + BT_DBG("chan %p conn %p skb %p", chan, chan->conn, skb); > + > + lowpan_cb(skb)->status = -EAGAIN; > +} > + > +static void chan_resume_cb(struct l2cap_chan *chan) > +{ > + struct sk_buff *skb = chan->data; > + > + BT_DBG("chan %p conn %p skb %p", chan, chan->conn, skb); > + > + lowpan_cb(skb)->status = 0; > +} > + > +static long chan_get_sndtimeo_cb(struct l2cap_chan *chan) > +{ > + return msecs_to_jiffies(1000); > +} > + > +static void chan_teardown_cb(struct l2cap_chan *chan, int err) > +{ > + BT_DBG("chan %p conn %p err %d", chan, chan->conn, err); > +} > + > +static struct l2cap_ops bt_6lowpan_chan_ops = { > + .name = "L2CAP 6LoWPAN channel", > + .new_connection = chan_new_conn_cb, > + .recv = chan_recv_cb, > + .teardown = chan_teardown_cb, > + .close = chan_close_cb, > + .state_change = chan_state_change_cb, > + .ready = chan_ready_cb, > + .resume = chan_resume_cb, > + .suspend = chan_suspend_cb, > + .get_sndtimeo = chan_get_sndtimeo_cb, > + .alloc_skb = chan_alloc_skb_cb, > + > + .defer = l2cap_chan_no_defer, > + .set_shutdown = l2cap_chan_no_set_shutdown, > +}; > + > +static inline __u8 bdaddr_type(__u8 type) > +{ > + if (type == ADDR_LE_DEV_PUBLIC) > + return BDADDR_LE_PUBLIC; > + else > + return BDADDR_LE_RANDOM; > +} > + > +static int bt_6lowpan_connect(bdaddr_t *addr, u8 dst_type) > +{ > + struct l2cap_chan *pchan; > + int err; > + > + pchan = chan_create(); > + if (!pchan) > + return -EINVAL; > + > + err = l2cap_chan_connect(pchan, cpu_to_le16(psm_6lowpan), 0, > + addr, dst_type); > + > + BT_DBG("chan %p err %d", pchan, err); > + > return err; > } > > +static void chan_close(struct l2cap_chan *chan, int reason) > +{ > + l2cap_chan_lock(chan); > + l2cap_chan_close(chan, reason); > + l2cap_chan_unlock(chan); > + l2cap_chan_put(chan); > +} > + > +static int bt_6lowpan_disconnect(struct l2cap_conn *conn, u8 dst_type) > +{ > + struct lowpan_peer *peer; > + > + BT_DBG("conn %p dst type %d", conn, dst_type); > + > + peer = lookup_peer(conn); > + if (!peer) > + return -ENOENT; > + > + chan_close(peer->chan, ENOENT); > + > + return 0; > +} > + > +static struct l2cap_chan *bt_6lowpan_listen(void) > +{ > + bdaddr_t *addr = BDADDR_ANY; > + struct l2cap_chan *pchan; > + int err; > + > + if (psm_6lowpan == 0) > + return NULL; > + > + pchan = chan_create(); > + if (!pchan) > + return NULL; > + > + pchan->state = BT_LISTEN; > + pchan->src_type = BDADDR_LE_PUBLIC; > + > + BT_DBG("psm 0x%04x chan %p src type %d", psm_6lowpan, pchan, > + pchan->src_type); > + > + err = l2cap_add_psm(pchan, addr, cpu_to_le16(psm_6lowpan)); > + if (err) { > + BT_ERR("psm cannot be added err %d", err); > + return NULL; > + } > + > + return pchan; > +} > + > +static int get_l2cap_conn(char *buf, bdaddr_t *addr, u8 *addr_type, > + struct l2cap_conn **conn) > +{ > + struct hci_conn *hcon; > + struct hci_dev *hdev; > + bdaddr_t *src = BDADDR_ANY; > + int n; > + > + n = sscanf(buf, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx %hhu", > + &addr->b[5], &addr->b[4], &addr->b[3], > + &addr->b[2], &addr->b[1], &addr->b[0], > + addr_type); > + > + if (n < 7) > + return -EINVAL; > + > + hdev = hci_get_route(addr, src); > + if (!hdev) > + return -ENOENT; > + > + hci_dev_lock(hdev); > + hcon = hci_conn_hash_lookup_ba(hdev, LE_LINK, addr); > + hci_dev_unlock(hdev); > + > + if (!hcon) > + return -ENOENT; > + > + *conn = (struct l2cap_conn *)hcon->l2cap_data; > + > + BT_DBG("conn %p dst %pMR type %d", *conn, &hcon->dst, hcon->dst_type); > + > + return 0; > +} > + > +static void disconnect_all_peers(void) > +{ > + struct lowpan_dev *entry, *tmp_dev; > + struct lowpan_peer *peer, *tmp_peer, *new_peer; > + struct list_head peers; > + unsigned long flags; > + > + INIT_LIST_HEAD(&peers); > + > + /* We make a separate list of peers as the close_cb() will > + * modify the device peers list so it is better not to mess > + * with the same list at the same time. > + */ > + > + read_lock_irqsave(&devices_lock, flags); > + > + list_for_each_entry_safe(entry, tmp_dev, &bt_6lowpan_devices, list) { > + list_for_each_entry_safe(peer, tmp_peer, &entry->peers, list) { > + new_peer = kmalloc(sizeof(*new_peer), GFP_ATOMIC); > + if (!new_peer) > + break; > + > + new_peer->chan = peer->chan; > + INIT_LIST_HEAD(&new_peer->list); > + > + list_add(&new_peer->list, &peers); > + } > + } > + > + read_unlock_irqrestore(&devices_lock, flags); > + > + list_for_each_entry_safe(peer, tmp_peer, &peers, list) { > + chan_close(peer->chan, ENOENT); > + kfree(peer); > + } > +} > + > +static ssize_t lowpan_psm_write(struct file *fp, const char __user *user_buffer, > + size_t count, loff_t *position) > +{ > + char buf[32]; > + size_t buf_size = min(count, sizeof(buf) - 1); > + int ret; > + unsigned long value; > + u16 psm; > + > + if (copy_from_user(buf, user_buffer, buf_size)) > + return -EFAULT; > + > + buf[buf_size] = '\0'; > + > + ret = kstrtoul(buf, 0, &value); > + if (ret < 0) > + return ret; > + > + psm = value; > + if (psm == 0 || psm_6lowpan != psm) > + /* Disconnect existing connections if 6lowpan is > + * disabled (psm = 0), or if psm changes. > + */ > + disconnect_all_peers(); > + > + psm_6lowpan = psm; > + > + if (listen_chan) > + chan_close(listen_chan, 0); > + > + listen_chan = bt_6lowpan_listen(); > + > + return count; > +} > + > +static ssize_t lowpan_control_write(struct file *fp, > + const char __user *user_buffer, > + size_t count, > + loff_t *position) > +{ > + char buf[32]; > + size_t buf_size = min(count, sizeof(buf) - 1); > + int ret; > + bdaddr_t addr; > + u8 addr_type; > + struct l2cap_conn *conn = NULL; > + > + if (copy_from_user(buf, user_buffer, buf_size)) > + return -EFAULT; > + > + buf[buf_size] = '\0'; > + > + if (memcmp(buf, "connect ", 8) == 0) { > + > + ret = get_l2cap_conn(&buf[8], &addr, &addr_type, &conn); > + if (ret == -EINVAL) > + return ret; > + > + if (listen_chan) { > + chan_close(listen_chan, 0); > + listen_chan = NULL; > + } > + > + if (conn) { > + struct lowpan_peer *peer; > + > + if (!is_bt_6lowpan(conn->hcon)) > + return -EINVAL; > + > + peer = lookup_peer(conn); > + if (peer) { > + BT_DBG("6LoWPAN connection already exists"); > + return -EALREADY; > + } > + > + BT_DBG("conn %p dst %pMR type %d user %d", conn, > + &conn->hcon->dst, conn->hcon->dst_type, > + addr_type); > + } > + > + ret = bt_6lowpan_connect(&addr, addr_type); > + if (ret < 0) > + return ret; > + > + return count; > + } > + > + if (memcmp(buf, "disconnect ", 11) == 0) { > + > + ret = get_l2cap_conn(&buf[11], &addr, &addr_type, &conn); > + if (ret < 0) > + return ret; > + > + ret = bt_6lowpan_disconnect(conn, addr_type); > + if (ret < 0) > + return ret; > + > + return count; > + } > + > + return count; > +} > + > +static int lowpan_psm_show(struct seq_file *f, void *ptr) > +{ > + seq_printf(f, "%u\n", psm_6lowpan); > + return 0; > +} why is this still seq_printf here. It should be simple value read and write for the PSM debugfs entry. Similar to ssp_debug_mode for example. > + > +static int lowpan_control_show(struct seq_file *f, void *ptr) > +{ > + struct lowpan_dev *entry, *tmp_dev; > + struct lowpan_peer *peer, *tmp_peer; > + unsigned long flags; > + > + read_lock_irqsave(&devices_lock, flags); > + > + list_for_each_entry_safe(entry, tmp_dev, &bt_6lowpan_devices, list) { > + list_for_each_entry_safe(peer, tmp_peer, &entry->peers, list) > + seq_printf(f, "%pMR (type %u)\n", > + &peer->chan->dst, peer->chan->dst_type); > + } > + > + read_unlock_irqrestore(&devices_lock, flags); > + > + return 0; > +} > + > +static int lowpan_psm_open(struct inode *inode, struct file *file) > +{ > + return single_open(file, lowpan_psm_show, inode->i_private); > +} > + > +static int lowpan_control_open(struct inode *inode, struct file *file) > +{ > + return single_open(file, lowpan_control_show, inode->i_private); > +} > + > +static const struct file_operations lowpan_psm_fops = { > + .open = lowpan_psm_open, > + .read = seq_read, > + .write = lowpan_psm_write, > + .llseek = seq_lseek, > + .release = single_release, > +}; > + > +static const struct file_operations lowpan_control_fops = { > + .open = lowpan_control_open, > + .read = seq_read, > + .write = lowpan_control_write, > + .llseek = seq_lseek, > + .release = single_release, > +}; > + > +static void setup_6lowpan(void) > +{ > + lowpan_psm_debugfs = debugfs_create_file("6lowpan_psm", 0644, > + bt_debugfs, NULL, > + &lowpan_psm_fops); > + lowpan_control_debugfs = debugfs_create_file("6lowpan_control", 0644, > + bt_debugfs, NULL, > + &lowpan_control_fops); > +} > + > +static void cleanup_6lowpan(void) > +{ > + debugfs_remove(lowpan_psm_debugfs); > + debugfs_remove(lowpan_control_debugfs); You need to check that the variables are not NULL. I think debugfs is a bit picky here. Check the debugfs_remove if it gracefully deals with NULL pointers. > + > + if (listen_chan) > + chan_close(listen_chan, 0); > +} > + > static int device_event(struct notifier_block *unused, > unsigned long event, void *ptr) > { > @@ -854,12 +1224,18 @@ static struct notifier_block bt_6lowpan_dev_notifier = { > .notifier_call = device_event, > }; > > -int bt_6lowpan_init(void) > +static int __init bt_6lowpan_init(void) > { > + setup_6lowpan(); > + Just move the content into the init function. No need for splitting it out since it is rather simple code. > return register_netdevice_notifier(&bt_6lowpan_dev_notifier); > } > > void bt_6lowpan_cleanup(void) > { > + cleanup_6lowpan(); Same here. Move the code directly into the cleanup function. > + > + disconnect_devices(); > + > unregister_netdevice_notifier(&bt_6lowpan_dev_notifier); > } Regards Marcel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v5 3/5] Bluetooth: 6LoWPAN: Create a kernel module 2014-06-02 15:00 [PATCH v5 0/5] Bluetooth LE 6LoWPAN using CoC Jukka Rissanen 2014-06-02 15:00 ` [PATCH v5 1/5] Bluetooth: Refactor l2cap_sock_sendmsg() to copy user buffer Jukka Rissanen 2014-06-02 15:00 ` [PATCH v5 2/5] Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one Jukka Rissanen @ 2014-06-02 15:00 ` Jukka Rissanen 2014-06-03 3:57 ` Marcel Holtmann 2014-06-02 15:00 ` [PATCH v5 4/5] Bluetooth: 6LoWPAN: Count module usage Jukka Rissanen 2014-06-02 15:00 ` [PATCH v5 5/5] Bluetooth: 6LoWPAN: Remove network devices when unloading Jukka Rissanen 4 siblings, 1 reply; 10+ messages in thread From: Jukka Rissanen @ 2014-06-02 15:00 UTC (permalink / raw) To: linux-bluetooth Instead of adding the 6LoWPAN functionality to Bluetooth module, we create a separate kernel module for it. Usage: In the slave side do this: $ modprobe bluetooth_6lowpan $ echo 62 > /sys/kernel/debug/bluetooth/6lowpan_psm $ hciconfig hci0 leadv In the master side do this: $ modprobe bluetooth_6lowpan $ echo 62 > /sys/kernel/debug/bluetooth/6lowpan_psm $ echo 'connect E0:06:E6:B7:2A:73 1' > \ /sys/kernel/debug/bluetooth/6lowpan_control The 6LoWPAN functionality can be controlled by psm value. If it is left to 0, then the module is disabled and all the 6LoWPAN connections are dropped if there were any. In the above example, the psm value is just an example and not a real value for 6LoWPAN service. The real psm value is yet to be defined in Bluetooth specification. The 6lowpan controlling interface is a temporary solution until the specifications are ready. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> --- net/bluetooth/6lowpan.c | 11 ++++++++++- net/bluetooth/Kconfig | 6 +++--- net/bluetooth/Makefile | 4 +++- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c index d197bbe..debf003 100644 --- a/net/bluetooth/6lowpan.c +++ b/net/bluetooth/6lowpan.c @@ -14,6 +14,7 @@ #include <linux/if_arp.h> #include <linux/netdevice.h> #include <linux/etherdevice.h> +#include <linux/module.h> #include <linux/debugfs.h> #include <net/ipv6.h> @@ -1231,7 +1232,7 @@ static int __init bt_6lowpan_init(void) return register_netdevice_notifier(&bt_6lowpan_dev_notifier); } -void bt_6lowpan_cleanup(void) +static void __exit bt_6lowpan_cleanup(void) { cleanup_6lowpan(); @@ -1239,3 +1240,11 @@ void bt_6lowpan_cleanup(void) unregister_netdevice_notifier(&bt_6lowpan_dev_notifier); } + +module_init(bt_6lowpan_init); +module_exit(bt_6lowpan_cleanup); + +MODULE_AUTHOR("Jukka Rissanen <jukka.rissanen@linux.intel.com>"); +MODULE_DESCRIPTION("Bluetooth 6LoWPAN"); +MODULE_VERSION(VERSION); +MODULE_LICENSE("GPL"); diff --git a/net/bluetooth/Kconfig b/net/bluetooth/Kconfig index 06ec144..f5afaa2 100644 --- a/net/bluetooth/Kconfig +++ b/net/bluetooth/Kconfig @@ -6,7 +6,6 @@ menuconfig BT tristate "Bluetooth subsystem support" depends on NET && !S390 depends on RFKILL || !RFKILL - select 6LOWPAN_IPHC if BT_6LOWPAN select CRC16 select CRYPTO select CRYPTO_BLKCIPHER @@ -41,10 +40,11 @@ menuconfig BT more information, see <http://www.bluez.org/>. config BT_6LOWPAN - bool "Bluetooth 6LoWPAN support" + tristate "Bluetooth 6LoWPAN support" depends on BT && IPV6 + select 6LOWPAN_IPHC if BT_6LOWPAN help - IPv6 compression over Bluetooth. + IPv6 compression over Bluetooth Low Energy. source "net/bluetooth/rfcomm/Kconfig" diff --git a/net/bluetooth/Makefile b/net/bluetooth/Makefile index ca51246..886e9aa 100644 --- a/net/bluetooth/Makefile +++ b/net/bluetooth/Makefile @@ -7,10 +7,12 @@ obj-$(CONFIG_BT_RFCOMM) += rfcomm/ obj-$(CONFIG_BT_BNEP) += bnep/ obj-$(CONFIG_BT_CMTP) += cmtp/ obj-$(CONFIG_BT_HIDP) += hidp/ +obj-$(CONFIG_BT_6LOWPAN) += bluetooth_6lowpan.o + +bluetooth_6lowpan-y := 6lowpan.o bluetooth-y := af_bluetooth.o hci_core.o hci_conn.o hci_event.o mgmt.o \ hci_sock.o hci_sysfs.o l2cap_core.o l2cap_sock.o smp.o sco.o lib.o \ a2mp.o amp.o -bluetooth-$(CONFIG_BT_6LOWPAN) += 6lowpan.o subdir-ccflags-y += -D__CHECK_ENDIAN__ -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v5 3/5] Bluetooth: 6LoWPAN: Create a kernel module 2014-06-02 15:00 ` [PATCH v5 3/5] Bluetooth: 6LoWPAN: Create a kernel module Jukka Rissanen @ 2014-06-03 3:57 ` Marcel Holtmann 0 siblings, 0 replies; 10+ messages in thread From: Marcel Holtmann @ 2014-06-03 3:57 UTC (permalink / raw) To: Jukka Rissanen; +Cc: linux-bluetooth Hi Jukka, > Instead of adding the 6LoWPAN functionality to Bluetooth module, > we create a separate kernel module for it. > > Usage: > > In the slave side do this: > > $ modprobe bluetooth_6lowpan > $ echo 62 > /sys/kernel/debug/bluetooth/6lowpan_psm > $ hciconfig hci0 leadv > > In the master side do this: > > $ modprobe bluetooth_6lowpan > $ echo 62 > /sys/kernel/debug/bluetooth/6lowpan_psm > $ echo 'connect E0:06:E6:B7:2A:73 1' > \ > /sys/kernel/debug/bluetooth/6lowpan_control > > The 6LoWPAN functionality can be controlled by psm value. If it > is left to 0, then the module is disabled and all the 6LoWPAN > connections are dropped if there were any. In the above example, > the psm value is just an example and not a real value for > 6LoWPAN service. The real psm value is yet to be defined in > Bluetooth specification. > > The 6lowpan controlling interface is a temporary solution > until the specifications are ready. > > Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> > --- > net/bluetooth/6lowpan.c | 11 ++++++++++- > net/bluetooth/Kconfig | 6 +++--- > net/bluetooth/Makefile | 4 +++- > 3 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c > index d197bbe..debf003 100644 > --- a/net/bluetooth/6lowpan.c > +++ b/net/bluetooth/6lowpan.c > @@ -14,6 +14,7 @@ > #include <linux/if_arp.h> > #include <linux/netdevice.h> > #include <linux/etherdevice.h> > +#include <linux/module.h> > #include <linux/debugfs.h> > > #include <net/ipv6.h> > @@ -1231,7 +1232,7 @@ static int __init bt_6lowpan_init(void) > return register_netdevice_notifier(&bt_6lowpan_dev_notifier); > } > > -void bt_6lowpan_cleanup(void) > +static void __exit bt_6lowpan_cleanup(void) > { > cleanup_6lowpan(); > > @@ -1239,3 +1240,11 @@ void bt_6lowpan_cleanup(void) > > unregister_netdevice_notifier(&bt_6lowpan_dev_notifier); > } > + > +module_init(bt_6lowpan_init); > +module_exit(bt_6lowpan_cleanup); I prefer if we call it bt_6lowpan_exit here or you fix this up in the previous patch. > + > +MODULE_AUTHOR("Jukka Rissanen <jukka.rissanen@linux.intel.com>"); > +MODULE_DESCRIPTION("Bluetooth 6LoWPAN"); > +MODULE_VERSION(VERSION); > +MODULE_LICENSE("GPL"); Regards Marcel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v5 4/5] Bluetooth: 6LoWPAN: Count module usage 2014-06-02 15:00 [PATCH v5 0/5] Bluetooth LE 6LoWPAN using CoC Jukka Rissanen ` (2 preceding siblings ...) 2014-06-02 15:00 ` [PATCH v5 3/5] Bluetooth: 6LoWPAN: Create a kernel module Jukka Rissanen @ 2014-06-02 15:00 ` Jukka Rissanen 2014-06-02 15:00 ` [PATCH v5 5/5] Bluetooth: 6LoWPAN: Remove network devices when unloading Jukka Rissanen 4 siblings, 0 replies; 10+ messages in thread From: Jukka Rissanen @ 2014-06-02 15:00 UTC (permalink / raw) To: linux-bluetooth Count how many 6LoWPAN connections there exists so that we do not unload the module if there are still connections alive. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> --- net/bluetooth/6lowpan.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c index debf003..90c64da 100644 --- a/net/bluetooth/6lowpan.c +++ b/net/bluetooth/6lowpan.c @@ -101,6 +101,8 @@ static inline bool peer_del(struct lowpan_dev *dev, struct lowpan_peer *peer) { list_del(&peer->list); + module_put(THIS_MODULE); + if (atomic_dec_and_test(&dev->peer_count)) { BT_DBG("last peer"); return true; @@ -744,6 +746,9 @@ static inline void chan_ready_cb(struct l2cap_chan *chan) } } + if (!try_module_get(THIS_MODULE)) + return; + add_peer_chan(chan, dev); ifup(dev->netdev); } -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v5 5/5] Bluetooth: 6LoWPAN: Remove network devices when unloading 2014-06-02 15:00 [PATCH v5 0/5] Bluetooth LE 6LoWPAN using CoC Jukka Rissanen ` (3 preceding siblings ...) 2014-06-02 15:00 ` [PATCH v5 4/5] Bluetooth: 6LoWPAN: Count module usage Jukka Rissanen @ 2014-06-02 15:00 ` Jukka Rissanen 2014-06-03 4:00 ` Marcel Holtmann 4 siblings, 1 reply; 10+ messages in thread From: Jukka Rissanen @ 2014-06-02 15:00 UTC (permalink / raw) To: linux-bluetooth When the module is unloaded, unregister the network device so that the system does not try to access non-existing device. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> --- net/bluetooth/6lowpan.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c index 90c64da..b2d1139 100644 --- a/net/bluetooth/6lowpan.c +++ b/net/bluetooth/6lowpan.c @@ -598,6 +598,17 @@ static void ifup(struct net_device *netdev) rtnl_unlock(); } +static void ifdown(struct net_device *netdev) +{ + int err; + + rtnl_lock(); + err = dev_close(netdev); + if (err < 0) + BT_INFO("iface %s cannot be closed (%d)", netdev->name, err); + rtnl_unlock(); +} + static void do_notify_peers(struct work_struct *work) { struct lowpan_dev *dev = container_of(work, struct lowpan_dev, @@ -811,6 +822,8 @@ static void chan_close_cb(struct l2cap_chan *chan) cancel_delayed_work_sync(&dev->notify_peers); + ifdown(dev->netdev); + if (!removed) { INIT_WORK(&entry->delete_netdev, delete_netdev); schedule_work(&entry->delete_netdev); @@ -1198,6 +1211,38 @@ static void cleanup_6lowpan(void) chan_close(listen_chan, 0); } +static void disconnect_devices(void) +{ + struct lowpan_dev *entry, *tmp, *new_dev; + struct list_head devices; + unsigned long flags; + + INIT_LIST_HEAD(&devices); + + read_lock_irqsave(&devices_lock, flags); + + list_for_each_entry_safe(entry, tmp, &bt_6lowpan_devices, list) { + new_dev = kmalloc(sizeof(*new_dev), GFP_ATOMIC); + if (!new_dev) + break; + + new_dev->netdev = entry->netdev; + INIT_LIST_HEAD(&new_dev->list); + + list_add(&new_dev->list, &devices); + } + + read_unlock_irqrestore(&devices_lock, flags); + + list_for_each_entry_safe(entry, tmp, &devices, list) { + ifdown(entry->netdev); + BT_DBG("Unregistering netdev %s %p", + entry->netdev->name, entry->netdev); + unregister_netdev(entry->netdev); + kfree(entry); + } +} + static int device_event(struct notifier_block *unused, unsigned long event, void *ptr) { @@ -1214,6 +1259,8 @@ static int device_event(struct notifier_block *unused, list_for_each_entry_safe(entry, tmp, &bt_6lowpan_devices, list) { if (entry->netdev == netdev) { + BT_DBG("Unregistered netdev %s %p", + netdev->name, netdev); list_del(&entry->list); kfree(entry); break; -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v5 5/5] Bluetooth: 6LoWPAN: Remove network devices when unloading 2014-06-02 15:00 ` [PATCH v5 5/5] Bluetooth: 6LoWPAN: Remove network devices when unloading Jukka Rissanen @ 2014-06-03 4:00 ` Marcel Holtmann 0 siblings, 0 replies; 10+ messages in thread From: Marcel Holtmann @ 2014-06-03 4:00 UTC (permalink / raw) To: Jukka Rissanen; +Cc: linux-bluetooth Hi Jukka, > When the module is unloaded, unregister the network device > so that the system does not try to access non-existing device. > > Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> > --- > net/bluetooth/6lowpan.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c > index 90c64da..b2d1139 100644 > --- a/net/bluetooth/6lowpan.c > +++ b/net/bluetooth/6lowpan.c > @@ -598,6 +598,17 @@ static void ifup(struct net_device *netdev) > rtnl_unlock(); > } > > +static void ifdown(struct net_device *netdev) > +{ > + int err; > + > + rtnl_lock(); > + err = dev_close(netdev); > + if (err < 0) > + BT_INFO("iface %s cannot be closed (%d)", netdev->name, err); > + rtnl_unlock(); > +} > + > static void do_notify_peers(struct work_struct *work) > { > struct lowpan_dev *dev = container_of(work, struct lowpan_dev, > @@ -811,6 +822,8 @@ static void chan_close_cb(struct l2cap_chan *chan) > > cancel_delayed_work_sync(&dev->notify_peers); > > + ifdown(dev->netdev); > + > if (!removed) { > INIT_WORK(&entry->delete_netdev, delete_netdev); > schedule_work(&entry->delete_netdev); > @@ -1198,6 +1211,38 @@ static void cleanup_6lowpan(void) > chan_close(listen_chan, 0); > } > > +static void disconnect_devices(void) > +{ > + struct lowpan_dev *entry, *tmp, *new_dev; > + struct list_head devices; > + unsigned long flags; > + > + INIT_LIST_HEAD(&devices); > + > + read_lock_irqsave(&devices_lock, flags); > + > + list_for_each_entry_safe(entry, tmp, &bt_6lowpan_devices, list) { > + new_dev = kmalloc(sizeof(*new_dev), GFP_ATOMIC); > + if (!new_dev) > + break; > + > + new_dev->netdev = entry->netdev; > + INIT_LIST_HEAD(&new_dev->list); > + > + list_add(&new_dev->list, &devices); > + } > + > + read_unlock_irqrestore(&devices_lock, flags); > + > + list_for_each_entry_safe(entry, tmp, &devices, list) { > + ifdown(entry->netdev); > + BT_DBG("Unregistering netdev %s %p", > + entry->netdev->name, entry->netdev); > + unregister_netdev(entry->netdev); > + kfree(entry); > + } this whole copy the list first needs an explanation on why you are doing this. Since I am not getting it. Regards Marcel ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-06-03 4:00 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-06-02 15:00 [PATCH v5 0/5] Bluetooth LE 6LoWPAN using CoC Jukka Rissanen 2014-06-02 15:00 ` [PATCH v5 1/5] Bluetooth: Refactor l2cap_sock_sendmsg() to copy user buffer Jukka Rissanen 2014-06-03 3:49 ` Marcel Holtmann 2014-06-02 15:00 ` [PATCH v5 2/5] Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one Jukka Rissanen 2014-06-03 3:55 ` Marcel Holtmann 2014-06-02 15:00 ` [PATCH v5 3/5] Bluetooth: 6LoWPAN: Create a kernel module Jukka Rissanen 2014-06-03 3:57 ` Marcel Holtmann 2014-06-02 15:00 ` [PATCH v5 4/5] Bluetooth: 6LoWPAN: Count module usage Jukka Rissanen 2014-06-02 15:00 ` [PATCH v5 5/5] Bluetooth: 6LoWPAN: Remove network devices when unloading Jukka Rissanen 2014-06-03 4:00 ` Marcel Holtmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).