Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: linux-bluetooth@vger.kernel.org
Cc: Szymon Janc <szymon.janc@tieto.com>
Subject: [PATCH 06/10] android/hal-ipc: Move exit calls under label in notification_handler
Date: Wed, 11 Jun 2014 16:32:48 +0200	[thread overview]
Message-ID: <1402497172-12436-7-git-send-email-szymon.janc@tieto.com> (raw)
In-Reply-To: <1402497172-12436-1-git-send-email-szymon.janc@tieto.com>

This reduce number of exit points in preparation for destroy callback.
---
 android/hal-ipc.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/android/hal-ipc.c b/android/hal-ipc.c
index 2cc6eda..59bc3dc 100644
--- a/android/hal-ipc.c
+++ b/android/hal-ipc.c
@@ -154,9 +154,9 @@ static void *notification_handler(void *data)
 
 		ret = recvmsg(notif_sk, &msg, 0);
 		if (ret < 0) {
-			error("Receiving notifications failed, aborting :%s",
+			error("Receiving notifications failed: %s",
 							strerror(errno));
-			exit(EXIT_FAILURE);
+			goto failed;
 		}
 
 		/* socket was shutdown */
@@ -168,8 +168,8 @@ static void *notification_handler(void *data)
 			}
 			pthread_mutex_unlock(&cmd_sk_mutex);
 
-			error("Notification socket closed, aborting");
-			exit(EXIT_FAILURE);
+			error("Notification socket closed");
+			goto failed;
 		}
 
 		fd = -1;
@@ -185,7 +185,7 @@ static void *notification_handler(void *data)
 		}
 
 		if (!handle_msg(buf, ret))
-			exit(EXIT_FAILURE);
+			goto failed;
 	}
 
 	close(notif_sk);
@@ -196,6 +196,9 @@ static void *notification_handler(void *data)
 	DBG("exit");
 
 	return NULL;
+
+failed:
+	exit(EXIT_FAILURE);
 }
 
 static int accept_connection(int sk)
-- 
1.9.1


  parent reply	other threads:[~2014-06-11 14:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 14:32 [PATCH 00/10] Some HAL IPC work Szymon Janc
2014-06-11 14:32 ` [PATCH 01/10] android/ipc: Make struct service_handler private Szymon Janc
2014-06-11 14:32 ` [PATCH 02/10] android/hal-ipc: Allow to pass custom path to IPC Szymon Janc
2014-06-11 14:32 ` [PATCH 03/10] android/hal-ipc: Fix missing mutex unlock Szymon Janc
2014-06-11 14:32 ` [PATCH 04/10] android/hal-ipc: Move exit calls outside of handle_msg Szymon Janc
2014-06-11 14:32 ` [PATCH 05/10] android/hal-ipc: Move exit calls under failed label in hal_ipc_cmd Szymon Janc
2014-06-11 14:32 ` Szymon Janc [this message]
2014-06-11 14:32 ` [PATCH 07/10] android/hal-ipc: Split IPC init and accept to separate functions Szymon Janc
2014-06-11 14:32 ` [PATCH 08/10] android/hal-ipc: Move daemon starting to bluetooth HAL Szymon Janc
2014-06-11 14:32 ` [PATCH 09/10] android/hal-ipc: Pass FD to notification handlers Szymon Janc
2014-06-11 14:32 ` [PATCH 10/10] android/ipc: Add support for sending FD in notifications Szymon Janc
2014-06-12 11:07 ` [PATCH 00/10] Some HAL IPC work Szymon Janc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402497172-12436-7-git-send-email-szymon.janc@tieto.com \
    --to=szymon.janc@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox