From: johan.hedberg@gmail.com
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 5/6] Bluetooth: Fix ignoring debug keys in mgmt_load_link_keys
Date: Tue, 24 Jun 2014 13:15:52 +0300 [thread overview]
Message-ID: <1403604953-19539-5-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1403604953-19539-1-git-send-email-johan.hedberg@gmail.com>
From: Johan Hedberg <johan.hedberg@intel.com>
If support for debug keys is not enabled we should simply ignore any
debug keys fed to us from user space using the mgmt_load_link_keys
command.
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
net/bluetooth/mgmt.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 634b44ddc9f9..49c9a4dbfd15 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -2426,6 +2426,11 @@ static int load_link_keys(struct sock *sk, struct hci_dev *hdev, void *data,
for (i = 0; i < key_count; i++) {
struct mgmt_link_key_info *key = &cp->keys[i];
+ /* Ignore debug keys if support is not enabled */
+ if (key->type == HCI_LK_DEBUG_COMBINATION &&
+ !test_bit(HCI_KEEP_DEBUG_KEYS, &hdev->flags))
+ continue;
+
hci_add_link_key(hdev, NULL, &key->addr.bdaddr, key->val,
key->type, key->pin_len, NULL);
}
--
1.9.3
next prev parent reply other threads:[~2014-06-24 10:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 10:15 [PATCH 1/6] Bluetooth: Update hci_add_link_key() to return pointer to key johan.hedberg
2014-06-24 10:15 ` [PATCH 2/6] Bluetooth: Move mgmt event sending out from hci_add_link_key() johan.hedberg
2014-06-24 10:38 ` Marcel Holtmann
2014-06-24 10:15 ` [PATCH 3/6] Bluetooth: Rename HCI_DEBUG_KEYS to HCI_KEEP_DEBUG_KEYS johan.hedberg
2014-06-24 10:38 ` Marcel Holtmann
2014-06-24 10:15 ` [PATCH 4/6] Bluetooth: Don't store debug keys if flag for them is not set johan.hedberg
2014-06-24 10:38 ` Marcel Holtmann
2014-06-24 10:15 ` johan.hedberg [this message]
2014-06-24 10:33 ` [PATCH 5/6] Bluetooth: Fix ignoring debug keys in mgmt_load_link_keys Marcel Holtmann
2014-06-24 10:15 ` [PATCH 6/6] Bluetooth: Convert hcon->flush_key to a proper flag johan.hedberg
2014-06-24 10:38 ` Marcel Holtmann
2014-06-24 10:38 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403604953-19539-5-git-send-email-johan.hedberg@gmail.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox