From: Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
Subject: [RFC 3/5] android/health: Fix deleting channels queue
Date: Fri, 27 Jun 2014 00:30:44 +0300 [thread overview]
Message-ID: <1403818246-20205-4-git-send-email-ravikumar.veeramally@linux.intel.com> (raw)
In-Reply-To: <1403818246-20205-1-git-send-email-ravikumar.veeramally@linux.intel.com>
Channels queue is created only on device creation. So do not destroy
queue on all mdls deleted in mdl_deleted_cb, just remove all entries.
---
android/health.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/android/health.c b/android/health.c
index 3afdf9b..717e9a6 100644
--- a/android/health.c
+++ b/android/health.c
@@ -1088,8 +1088,8 @@ static void mcap_mdl_deleted_cb(struct mcap_mdl *mdl, void *data)
/* mdl == NULL means, delete all mdls */
if (!mdl) {
queue_foreach(dev->channels, notify_channel, NULL);
- queue_destroy(dev->channels, free_health_channel);
- dev->channels = NULL;
+ queue_remove_all(dev->channels, NULL, NULL,
+ free_health_channel);
return;
}
--
1.9.1
next prev parent reply other threads:[~2014-06-26 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 21:30 [RFC 0/5] Implement MDL disconnect and reconnect Ravi kumar Veeramally
2014-06-26 21:30 ` [RFC 1/5] android/client/health: Introduce close_channel API Ravi kumar Veeramally
2014-06-26 21:30 ` [RFC 2/5] android/health: Implement mdl_closed_cb callback Ravi kumar Veeramally
2014-06-26 21:30 ` Ravi kumar Veeramally [this message]
2014-06-26 21:30 ` [RFC 4/5] android/health: Implement mdl reconnect Ravi kumar Veeramally
2014-06-26 21:30 ` [RFC 5/5] android/health: Implement destroy_channel call Ravi kumar Veeramally
2014-06-27 14:13 ` Andrei Emeltchenko
2014-06-27 13:32 ` [RFC 0/5] Implement MDL disconnect and reconnect Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403818246-20205-4-git-send-email-ravikumar.veeramally@linux.intel.com \
--to=ravikumar.veeramally@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).