From: Arman Uguray <armansito@chromium.org>
To: linux-bluetooth@vger.kernel.org
Cc: Arman Uguray <armansito@chromium.org>
Subject: [PATCH 06/10] shared/att: Implement outgoing "Read Multiple" request/response.
Date: Thu, 26 Jun 2014 16:14:13 -0700 [thread overview]
Message-ID: <1403824457-22461-7-git-send-email-armansito@chromium.org> (raw)
In-Reply-To: <1403824457-22461-1-git-send-email-armansito@chromium.org>
This patch adds support for "Read Multiple" requests sent via
bt_att_send and the corresponding response.
---
src/shared/att-types.h | 4 ++--
src/shared/att.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+), 2 deletions(-)
diff --git a/src/shared/att-types.h b/src/shared/att-types.h
index b6f32dd..ae2dfb6 100644
--- a/src/shared/att-types.h
+++ b/src/shared/att-types.h
@@ -114,13 +114,13 @@ struct bt_att_read_blob_rsp_param {
/* Read Multiple */
#define BT_ATT_OP_READ_MULT_REQ 0x0e
-struct bt_att_read_multiple_req_param {
+struct bt_att_read_mult_req_param {
const uint16_t *handles;
uint16_t num_handles;
};
#define BT_ATT_OP_READ_MULT_RSP 0x0f
-struct bt_att_read_multiple_rsp_param {
+struct bt_att_read_mult_rsp_param {
const uint8_t *values;
uint16_t length;
};
diff --git a/src/shared/att.c b/src/shared/att.c
index 1b6d568..2658969 100644
--- a/src/shared/att.c
+++ b/src/shared/att.c
@@ -310,6 +310,37 @@ static bool encode_read_blob_req(struct att_send_op *op,
return true;
}
+static bool encode_read_mult_req(struct att_send_op *op,
+ const void *param, uint16_t length,
+ uint16_t mtu)
+{
+ const struct bt_att_read_mult_req_param *p = param;
+ uint16_t len;
+ int i;
+
+ if (length != sizeof(*p))
+ return false;
+
+ if (p->num_handles < 1)
+ return false;
+
+ len = 1 + 2 * p->num_handles;
+ if (len > mtu)
+ return false;
+
+ op->pdu = malloc(len);
+ if (!op->pdu)
+ return false;
+
+ ((uint8_t *) op->pdu)[0] = op->opcode;
+ op->len = len;
+
+ for (i = 0; i < p->num_handles; i++)
+ put_le16(p->handles[i], ((uint8_t *) op->pdu) + 1 + 2 * i);
+
+ return true;
+}
+
static bool encode_pdu(struct att_send_op *op, const void *param,
uint16_t length, uint16_t mtu)
{
@@ -346,6 +377,8 @@ static bool encode_pdu(struct att_send_op *op, const void *param,
return encode_read_req(op, param, length, mtu);
case BT_ATT_OP_READ_BLOB_REQ:
return encode_read_blob_req(op, param, length, mtu);
+ case BT_ATT_OP_READ_MULT_REQ:
+ return encode_read_mult_req(op, param, length, mtu);
default:
break;
}
@@ -733,6 +766,22 @@ static bool handle_read_blob_rsp(struct bt_att *att, uint8_t opcode,
sizeof(param));
}
+static bool handle_read_mult_rsp(struct bt_att *att, uint8_t opcode,
+ uint8_t *pdu, ssize_t pdu_len)
+{
+ struct bt_att_read_mult_rsp_param param;
+
+ memset(¶m, 0, sizeof(param));
+
+ if (pdu_len > 1) {
+ param.length = pdu_len - 1;
+ param.values = pdu + 1;
+ }
+
+ return request_complete(att, BT_ATT_OP_READ_MULT_REQ, opcode, ¶m,
+ sizeof(param));
+}
+
static void handle_rsp(struct bt_att *att, uint8_t opcode, uint8_t *pdu,
ssize_t pdu_len)
{
@@ -761,6 +810,9 @@ static void handle_rsp(struct bt_att *att, uint8_t opcode, uint8_t *pdu,
case BT_ATT_OP_READ_BLOB_RSP:
success = handle_read_blob_rsp(att, opcode, pdu, pdu_len);
break;
+ case BT_ATT_OP_READ_MULT_RSP:
+ success = handle_read_mult_rsp(att, opcode, pdu, pdu_len);
+ break;
default:
success = false;
util_debug(att->debug_callback, att->debug_data,
--
2.0.0.526.g5318336
next prev parent reply other threads:[~2014-06-26 23:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 23:14 [PATCH 00/10] shared/att: Implement sending ATT protocol requests Arman Uguray
2014-06-26 23:14 ` [PATCH 01/10] shared/att: Implement outgoing "Find Information" request/response Arman Uguray
2014-07-07 7:20 ` Marcel Holtmann
2014-07-07 7:49 ` Szymon Janc
2014-07-07 8:44 ` Marcel Holtmann
2014-07-07 8:18 ` Arman Uguray
2014-07-07 8:42 ` Marcel Holtmann
2014-07-07 9:02 ` Arman Uguray
2014-07-07 9:48 ` Marcel Holtmann
2014-06-26 23:14 ` [PATCH 02/10] shared/att: Implement outgoing "Find By Type Value" request/response Arman Uguray
2014-06-26 23:14 ` [PATCH 03/10] shared/att: Implement outgoing "Read By Type" request/response Arman Uguray
2014-06-26 23:14 ` [PATCH 04/10] shared/att: Implement outgoing "Read" request/response Arman Uguray
2014-06-26 23:14 ` [PATCH 05/10] shared/att: Implement outgoing "Read Blob" request/response Arman Uguray
2014-06-26 23:14 ` Arman Uguray [this message]
2014-06-26 23:14 ` [PATCH 07/10] shared/att: Implement outgoing "Read By Group Type" request/response Arman Uguray
2014-06-26 23:14 ` [PATCH 08/10] shared/att: Implement outgoing "Write" request/response Arman Uguray
2014-06-26 23:14 ` [PATCH 09/10] shared/att: Implement outgoing "Prepare Write" request/response Arman Uguray
2014-06-26 23:14 ` [PATCH 10/10] shared/att: Implement outgoing "Execute " Arman Uguray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403824457-22461-7-git-send-email-armansito@chromium.org \
--to=armansito@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).