public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
To: linux-bluetooth@vger.kernel.org
Cc: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Subject: [PATCH 04/10] android/tester-ng: Verify action results also for success case
Date: Tue, 15 Jul 2014 10:24:53 +0200	[thread overview]
Message-ID: <1405412699-6358-4-git-send-email-jakub.tyszkowski@tieto.com> (raw)
In-Reply-To: <1405412699-6358-1-git-send-email-jakub.tyszkowski@tieto.com>

Case when we were expecting fail as action result but we got success was
not caught.
---
 android/tester-main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/android/tester-main.c b/android/tester-main.c
index f5bcb1c..5bafc0e 100644
--- a/android/tester-main.c
+++ b/android/tester-main.c
@@ -404,8 +404,7 @@ static bool match_data(struct step *step)
 		return false;
 	}
 
-	if (exp->action_result.status && (exp->action_result.status !=
-						step->action_result.status)) {
+	if (exp->action_result.status != step->action_result.status) {
 		tester_debug("Action status don't match");
 		return false;
 	}
-- 
1.9.1


  parent reply	other threads:[~2014-07-15  8:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15  8:24 [PATCH 01/10] android/tester-ng: Use loop for adding cases to the queue Jakub Tyszkowski
2014-07-15  8:24 ` [PATCH 02/10] android/tester-ng: Fix for not checking callback count in step Jakub Tyszkowski
2014-07-15  8:24 ` [PATCH 03/10] android/tester-ng: Set proper callback count Jakub Tyszkowski
2014-07-15  8:24 ` Jakub Tyszkowski [this message]
2014-07-15  8:24 ` [PATCH 05/10] android/tester-bluetooth: Add get bdaddr and bdname success cases Jakub Tyszkowski
2014-07-15  8:24 ` [PATCH 06/10] android/tester-bluetooth: Add various property set fail cases Jakub Tyszkowski
2014-07-15  8:24 ` [PATCH 07/10] android/tester-bluetooth: Add set scan mode success case Jakub Tyszkowski
2014-07-15  8:24 ` [PATCH 08/10] android/tester-bluetooth: Add get properties success cases Jakub Tyszkowski
2014-07-15  8:24 ` [PATCH 09/10] android/tester-bluetooth: Add set scan mode none succes case Jakub Tyszkowski
2014-07-15  8:24 ` [PATCH 10/10] android/tester: Remove old cases Jakub Tyszkowski
2014-07-16 15:31 ` [PATCH 01/10] android/tester-ng: Use loop for adding cases to the queue Szymon Janc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405412699-6358-4-git-send-email-jakub.tyszkowski@tieto.com \
    --to=jakub.tyszkowski@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox