From: Lukasz Rymanowski <lukasz.rymanowski@tieto.com>
To: linux-bluetooth@vger.kernel.org
Cc: Lukasz Rymanowski <lukasz.rymanowski@tieto.com>
Subject: [PATCH v3 3/6] android/gatt: Extract remove_autoconnect_device helper
Date: Wed, 3 Sep 2014 16:42:30 +0200 [thread overview]
Message-ID: <1409755353-6027-3-git-send-email-lukasz.rymanowski@tieto.com> (raw)
In-Reply-To: <1409755353-6027-1-git-send-email-lukasz.rymanowski@tieto.com>
---
android/gatt.c | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/android/gatt.c b/android/gatt.c
index 645f5f2..f4be376 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -1865,19 +1865,25 @@ static bool trigger_connection(struct app_connection *connection)
return ret;
}
+static void remove_autoconnect_device(struct gatt_device *dev)
+{
+ bt_auto_connect_remove(&dev->bdaddr);
+
+ if (dev->state == DEVICE_CONNECT_INIT)
+ device_set_state(dev, DEVICE_DISCONNECTED);
+
+ device_unref(dev);
+}
+
static void clear_autoconnect_devices(void *data, void *user_data)
{
struct gatt_device *dev = data;
if (queue_remove(dev->autoconnect_apps, user_data))
- if (queue_isempty(dev->autoconnect_apps)) {
- bt_auto_connect_remove(&dev->bdaddr);
+ if (queue_isempty(dev->autoconnect_apps))
+ remove_autoconnect_device(dev);
- if (dev->state == DEVICE_CONNECT_INIT)
- device_set_state(dev, DEVICE_DISCONNECTED);
- device_unref(dev);
- }
}
static uint8_t unregister_app(int client_if)
@@ -6804,12 +6810,8 @@ void bt_gatt_remove_autoconnect(unsigned int id, const bdaddr_t *addr)
queue_remove(dev->autoconnect_apps, INT_TO_PTR(id));
- if (queue_isempty(dev->autoconnect_apps)) {
- bt_auto_connect_remove(addr);
-
- if (dev->state == DEVICE_CONNECT_INIT)
- device_set_state(dev, DEVICE_DISCONNECTED);
+ if (queue_isempty(dev->autoconnect_apps))
+ remove_autoconnect_device(dev);
device_unref(dev);
- }
}
--
1.8.4
next prev parent reply other threads:[~2014-09-03 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 14:42 [PATCH v3 1/6] android/gatt: Add API to remove autoconnect GATT based device Lukasz Rymanowski
2014-09-03 14:42 ` [PATCH v3 2/6] android/gatt: Unsubscribe from autoconnect on unregister Lukasz Rymanowski
2014-09-03 14:42 ` Lukasz Rymanowski [this message]
2014-09-03 14:42 ` [PATCH v3 4/6] android/gatt: Make sure GATT will reconnect after disconnection Lukasz Rymanowski
2014-09-03 14:42 ` [PATCH v3 5/6] android/gatt: Remove device from white list on device destroy Lukasz Rymanowski
2014-09-03 14:42 ` [PATCH v3 6/6] android/hidhost: Remove reconnect logic Lukasz Rymanowski
2014-09-05 9:11 ` [PATCH v3 1/6] android/gatt: Add API to remove autoconnect GATT based device Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409755353-6027-3-git-send-email-lukasz.rymanowski@tieto.com \
--to=lukasz.rymanowski@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox