From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 2/8] android/avrcp-lib: Fix AddressedPlayerChanged
Date: Wed, 8 Oct 2014 15:31:43 +0300 [thread overview]
Message-ID: <1412771509-7996-2-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1412771509-7996-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This adds proper handling for AddressedPlayerChanged in
avrcp_register_notification_rsp.
---
android/avrcp-lib.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/android/avrcp-lib.c b/android/avrcp-lib.c
index 8350497..a487668 100644
--- a/android/avrcp-lib.c
+++ b/android/avrcp-lib.c
@@ -3243,6 +3243,7 @@ int avrcp_register_notification_rsp(struct avrcp *session, uint8_t transaction,
void *data, size_t len)
{
struct iovec iov[2];
+ uint16_t *player;
if (event > AVRCP_EVENT_LAST)
return -EINVAL;
@@ -3269,6 +3270,14 @@ int avrcp_register_notification_rsp(struct avrcp *session, uint8_t transaction,
put_be32(*(uint32_t *) data, data);
break;
case AVRCP_EVENT_ADDRESSED_PLAYER_CHANGED:
+ if (len != 4)
+ return -EINVAL;
+
+ player = data;
+ put_be16(player[0], &player[0]);
+ put_be16(player[1], &player[1]);
+
+ break;
case AVRCP_EVENT_SETTINGS_CHANGED:
if (len < sizeof(uint8_t))
return -EINVAL;
--
1.9.3
next prev parent reply other threads:[~2014-10-08 12:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 12:31 [PATCH BlueZ 1/8] android/avrcp-lib: Add support for SetBrowsedPlayer PDU Luiz Augusto von Dentz
2014-10-08 12:31 ` Luiz Augusto von Dentz [this message]
2014-10-08 12:31 ` [PATCH BlueZ 3/8] unit/test-avrcp: Add /TP/MPS/BV-04-C test Luiz Augusto von Dentz
2014-10-08 12:31 ` [PATCH BlueZ 4/8] unit/test-avrcp: Add /TP/MPS/BV-05-C test Luiz Augusto von Dentz
2014-10-08 12:31 ` [PATCH BlueZ 5/8] unit/test-avrcp: Add /TP/MPS/BV-06-C test Luiz Augusto von Dentz
2014-10-08 12:31 ` [PATCH BlueZ 6/8] unit/test-avrcp: Add /TP/MPS/BV-07-C test Luiz Augusto von Dentz
2014-10-08 12:31 ` [PATCH BlueZ 7/8] unit/test-avrcp: Add /TP/MPS/BI-01-C test Luiz Augusto von Dentz
2014-10-08 12:31 ` [PATCH BlueZ 8/8] unit/test-avrcp: Add /TP/MPS/BI-02-C test Luiz Augusto von Dentz
2014-10-10 14:15 ` [PATCH BlueZ 1/8] android/avrcp-lib: Add support for SetBrowsedPlayer PDU Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412771509-7996-2-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox