From: "Aurélien Zanelli" <aurelien.zanelli@parrot.com>
To: <linux-bluetooth@vger.kernel.org>
Cc: "Aurélien Zanelli" <aurelien.zanelli@parrot.com>
Subject: [PATCH 0/2] sbc: fix frame length in DUAL_CHANNEL mode
Date: Thu, 23 Oct 2014 16:32:19 +0200 [thread overview]
Message-ID: <1414074741-20286-1-git-send-email-aurelien.zanelli@parrot.com> (raw)
Hi everyone,
I was playing with sbc encoder in GStreamer, which use bluez sbc library to
encode and I found two issues related to DUAL_CHANNEL mode in it.
First the frame length calculation for DUAL_CHANNEL mode was wrong. I found
the A2DP specification and it seems that for DUAL_CHANNEL mode, we should use
the same formula as MONO mode to calculate the frame length. The first patch
intend to fix this.
The second patch try to fix an overflow which can occur when the frame length
is greater than 255.
Aurélien Zanelli (2):
sbc: fix frame length calculation for DUAL_CHANNEL mode
sbc: use an uint16 to store frame length in internal frame structure
sbc/sbc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
1.7.10.4
next reply other threads:[~2014-10-23 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 14:32 Aurélien Zanelli [this message]
2014-10-23 14:32 ` [PATCH 1/2] sbc: fix frame length calculation for DUAL_CHANNEL mode Aurélien Zanelli
2014-10-23 14:32 ` [PATCH 2/2] sbc: use an uint16 to store frame length in internal frame structure Aurélien Zanelli
2014-10-27 10:41 ` [PATCH 0/2] sbc: fix frame length in DUAL_CHANNEL mode Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414074741-20286-1-git-send-email-aurelien.zanelli@parrot.com \
--to=aurelien.zanelli@parrot.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox