Linux bluetooth development
 help / color / mirror / Atom feed
From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCHv1 29/47] android/handsfree: Add support for new API for at_response
Date: Tue,  4 Nov 2014 10:18:52 +0200	[thread overview]
Message-ID: <1415089150-18798-30-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1415089150-18798-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

at_response has new parameter bdaddr in new Android API.
---
 android/hal-handsfree.c | 12 ++++++++++++
 android/hal-ipc-api.txt |  1 +
 android/hal-msg.h       |  1 +
 android/handsfree.c     |  5 ++++-
 4 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/android/hal-handsfree.c b/android/hal-handsfree.c
index 058df79..e9388b8 100644
--- a/android/hal-handsfree.c
+++ b/android/hal-handsfree.c
@@ -561,7 +561,12 @@ static bt_status_t formatted_at_response(const char *rsp)
 					len, cmd, NULL, NULL, NULL);
 }
 
+#if ANDROID_VERSION > PLATFORM_VER(4, 4, 4)
+static bt_status_t at_response(bthf_at_response_t response, int error,
+							bt_bdaddr_t *bd_addr)
+#else
 static bt_status_t at_response(bthf_at_response_t response, int error)
+#endif
 {
 	struct hal_cmd_handsfree_at_response cmd;
 
@@ -570,6 +575,13 @@ static bt_status_t at_response(bthf_at_response_t response, int error)
 	if (!interface_ready())
 		return BT_STATUS_NOT_READY;
 
+#if ANDROID_VERSION > PLATFORM_VER(4, 4, 4)
+	if (!bd_addr)
+		return BT_STATUS_PARM_INVALID;
+
+	memcpy(cmd.bdaddr, bd_addr, sizeof(cmd.bdaddr));
+#endif
+
 	cmd.response = response;
 	cmd.error = error;
 
diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index 806114a..b5d5557 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -917,6 +917,7 @@ Commands and responses:
 
 		Command parameters: Response code (1 octet)
 		                    Error code (1 octet)
+		                    Remote address (6 octets)
 		Response parameters: <none>
 
 		Valid response codes: 0x00 = ERROR
diff --git a/android/hal-msg.h b/android/hal-msg.h
index 5c5ed22..4b3d8b8 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -568,6 +568,7 @@ struct hal_cmd_handsfree_formatted_at_response {
 struct hal_cmd_handsfree_at_response {
 	uint8_t response;
 	uint8_t error;
+	uint8_t bdaddr[6];
 } __attribute__((packed));
 
 #define HAL_HANDSFREE_CALL_DIRECTION_OUTGOING	0x00
diff --git a/android/handsfree.c b/android/handsfree.c
index 19a46f6..92a341a 100644
--- a/android/handsfree.c
+++ b/android/handsfree.c
@@ -2160,11 +2160,14 @@ static void handle_at_resp(const void *buf, uint16_t len)
 {
 	const struct hal_cmd_handsfree_at_response *cmd = buf;
 	struct hf_device *dev;
+	bdaddr_t bdaddr;
 	uint8_t status;
 
 	DBG("");
 
-	dev = find_default_device();
+	android2bdaddr(cmd->bdaddr, &bdaddr);
+
+	dev = find_device(&bdaddr);
 	if (!dev) {
 		status = HAL_STATUS_FAILED;
 		goto done;
-- 
1.9.1


  parent reply	other threads:[~2014-11-04  8:18 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04  8:18 [PATCHv1 00/47] BlueZ support for Android 5.0 Lollipop Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 01/47] android: Set exact Android version Andrei Emeltchenko
2014-11-04 14:03   ` Szymon Janc
2014-11-04  8:18 ` [PATCHv1 02/47] android/hal-bluetooth: Add parameter to create_bond Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 03/47] android/hal-bluetooth: Add missing functions Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 04/47] android/hal-audio: Add support for new Android API Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 05/47] android/hal-audio: Implement dummy Audio HAL functions Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 06/47] android/hal-sco: Add support for new Android API Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 07/47] android/hal-sco: Remove deprecated API usage Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 08/47] android/hal-sco: Implement dummy SCO HAL functions Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 09/47] android/hal-sco: Save bd_addr for output stream of Audio SCO HAL Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 10/47] android/hal-sco: Save bd_addr for input " Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 11/47] android/hal-sco: Add remote address parameter in Get SCO fd command Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 12/47] android/hal-sco: Use bdaddr " Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 13/47] android/gatt: Add support for new API Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 14/47] android/gatt: Add support for new parameter for connect Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 15/47] android/gatt: Add support for new parameter in srv connect() Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 16/47] android/client: Support new API for Audio HAL Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 17/47] android/client: Support new API for SCO HAL Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 18/47] android/client: Add new API argument for scan() Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 19/47] android/client: Add support for new Android API for PAN HAL Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 20/47] android/client: Add support for new GATT HAL API Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 21/47] android/client: Add new API support for handsfree client Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 22/47] android/handsfree: Add support for new API for handsfree init Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 23/47] android/handsfree: Add support for new API for start_vr Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 24/47] android/handsfree: Add support for new API for stop_vr Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 25/47] android/handsfree: Add support for new API for volume_control Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 26/47] android/handsfree: Add support for new API for cops_response Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 27/47] android/handsfree: Add support for new API for cind_response Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 28/47] android/handsfree: Add support for new API for formatted_at_response Andrei Emeltchenko
2014-11-04  8:18 ` Andrei Emeltchenko [this message]
2014-11-04  8:18 ` [PATCHv1 30/47] android/handsfree: Add support for new API for clcc_response Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 31/47] android/handsfree: Add support for new API for vr_cmd_cb Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 32/47] android/handsfree: Add support for new API for handle_answer Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 33/47] android/handsfree: Add support for new API for hangup_call_cmd_cb Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 34/47] android/handsfree: Add support for new API for volume_cmd_cb Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 35/47] android/handsfree: Add support for new API for dial_call_cmd_cb Andrei Emeltchenko
2014-11-04  8:18 ` [PATCHv1 36/47] android/handsfree: Add support for new API for handle_dtmf Andrei Emeltchenko
2014-11-04  8:19 ` [PATCHv1 37/47] android/handsfree: Add support for new API for nrec_cmd_cb Andrei Emeltchenko
2014-11-04  8:19 ` [PATCHv1 38/47] android/handsfree: Add support for new API for chld_cmd_cb Andrei Emeltchenko
2014-11-04  8:19 ` [PATCHv1 39/47] android/handsfree: Add support for new API for cnum_cmd_cb Andrei Emeltchenko
2014-11-04  8:19 ` [PATCHv1 40/47] android/handsfree: Add support for new API for cind_cmd_cb Andrei Emeltchenko
2014-11-04  8:19 ` [PATCHv1 41/47] android/handsfree: Add support for new API for cops_cmd_cb Andrei Emeltchenko
2014-11-04  8:19 ` [PATCHv1 42/47] android/handsfree: Add support for new API for clcc_cmd_cb Andrei Emeltchenko
2014-11-04  8:19 ` [PATCHv1 43/47] android/handsfree: Add support for new API for unknown_at_cmd_cb Andrei Emeltchenko
2014-11-04  8:19 ` [PATCHv1 44/47] android/handsfree: Add support for new API for key_pressed_cmd_cb Andrei Emeltchenko
2014-11-04  8:19 ` [PATCHv1 45/47] android/handsfree: Use bdaddr provided for find_device() Andrei Emeltchenko
2014-11-04  8:19 ` [PATCHv1 46/47] android/handsfree: Return default device for zero bdaddr Andrei Emeltchenko
2014-11-04  8:19 ` [PATCHv1 47/47] android/build: Disable declaration-after-statement warnings Andrei Emeltchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415089150-18798-30-git-send-email-Andrei.Emeltchenko.news@gmail.com \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox