Linux bluetooth development
 help / color / mirror / Atom feed
From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 14/14] android/handsfree: Add support for new API for key_pressed_cmd_cb
Date: Thu,  6 Nov 2014 10:32:09 +0200	[thread overview]
Message-ID: <1415262729-12573-15-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1415262729-12573-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Key Pressed Command notification callback has new parameter bdaddr.
---
 android/hal-handsfree.c | 9 ++++++++-
 android/hal-ipc-api.txt | 2 +-
 android/hal-msg.h       | 3 +++
 android/handsfree.c     | 6 +++++-
 4 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/android/hal-handsfree.c b/android/hal-handsfree.c
index 76e036a..2834c80 100644
--- a/android/hal-handsfree.c
+++ b/android/hal-handsfree.c
@@ -238,8 +238,15 @@ static void handle_unknown_at(void *buf, uint16_t len, int fd)
 
 static void handle_hsp_key_press(void *buf, uint16_t len, int fd)
 {
-	if (cbs->key_pressed_cmd_cb)
+	if (cbs->key_pressed_cmd_cb) {
+#if ANDROID_VERSION >= PLATFORM_VER(5, 0, 0)
+		struct hal_ev_handsfree_hsp_key_press *ev = buf;
+
+		cbs->key_pressed_cmd_cb((bt_bdaddr_t *) (ev->bdaddr));
+#else
 		cbs->key_pressed_cmd_cb();
+#endif
+	}
 }
 
 /*
diff --git a/android/hal-ipc-api.txt b/android/hal-ipc-api.txt
index 3e8a38c..c7d5c59 100644
--- a/android/hal-ipc-api.txt
+++ b/android/hal-ipc-api.txt
@@ -1081,7 +1081,7 @@ Notifications:
 
 	Opcode 0x90 - Key Pressed Command notification
 
-		Notification parameters: <none>
+		Notification parameters: Remote address (6 octets)
 
 
 Bluetooth Advanced Audio HAL (ID 6)
diff --git a/android/hal-msg.h b/android/hal-msg.h
index f86e6b7..eef226e 100644
--- a/android/hal-msg.h
+++ b/android/hal-msg.h
@@ -1427,6 +1427,9 @@ struct hal_ev_handsfree_unknown_at {
 } __attribute__((packed));
 
 #define HAL_EV_HANDSFREE_HSP_KEY_PRESS	0x90
+struct hal_ev_handsfree_hsp_key_press {
+	uint8_t bdaddr[6];
+} __attribute__((packed));
 
 #define HAL_AVRCP_FEATURE_NONE			0x00
 #define HAL_AVRCP_FEATURE_METADATA		0x01
diff --git a/android/handsfree.c b/android/handsfree.c
index d9cb929..4d8dff4 100644
--- a/android/handsfree.c
+++ b/android/handsfree.c
@@ -1143,6 +1143,7 @@ static void at_cmd_ckpd(struct hfp_context *result, enum hfp_gw_cmd_type type,
 								void *user_data)
 {
 	struct hf_device *dev = user_data;
+	struct hal_ev_handsfree_hsp_key_press ev;
 	unsigned int val;
 
 	DBG("");
@@ -1155,8 +1156,11 @@ static void at_cmd_ckpd(struct hfp_context *result, enum hfp_gw_cmd_type type,
 		if (hfp_context_has_next(result))
 			break;
 
+		bdaddr2android(&dev->bdaddr, ev.bdaddr);
+
 		ipc_send_notif(hal_ipc, HAL_SERVICE_ID_HANDSFREE,
-				HAL_EV_HANDSFREE_HSP_KEY_PRESS, 0, NULL);
+						HAL_EV_HANDSFREE_HSP_KEY_PRESS,
+						sizeof(ev), &ev);
 
 		hfp_gw_send_result(dev->gw, HFP_RESULT_OK);
 		return;
-- 
1.9.1


  parent reply	other threads:[~2014-11-06  8:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06  8:31 [PATCH 00/14] 2nd part of handsfree Android 5.0 adaptation code Andrei Emeltchenko
2014-11-06  8:31 ` [PATCH 01/14] android/handsfree: Add support for new API for vr_cmd_cb Andrei Emeltchenko
2014-11-06  8:31 ` [PATCH 02/14] android/handsfree: Add support for new API for handle_answer Andrei Emeltchenko
2014-11-06  8:31 ` [PATCH 03/14] android/handsfree: Add support for new API for hangup_call_cmd_cb Andrei Emeltchenko
2014-11-06  8:31 ` [PATCH 04/14] android/handsfree: Add support for new API for volume_cmd_cb Andrei Emeltchenko
2014-11-06  8:32 ` [PATCH 05/14] android/handsfree: Add support for new API for dial_call_cmd_cb Andrei Emeltchenko
2014-11-06  8:32 ` [PATCH 06/14] android/handsfree: Add support for new API for handle_dtmf Andrei Emeltchenko
2014-11-06  8:32 ` [PATCH 07/14] android/handsfree: Add support for new API for nrec_cmd_cb Andrei Emeltchenko
2014-11-06  8:32 ` [PATCH 08/14] android/handsfree: Add support for new API for chld_cmd_cb Andrei Emeltchenko
2014-11-06  8:32 ` [PATCH 09/14] android/handsfree: Add support for new API for cnum_cmd_cb Andrei Emeltchenko
2014-11-06  8:32 ` [PATCH 10/14] android/handsfree: Add support for new API for cind_cmd_cb Andrei Emeltchenko
2014-11-06  8:32 ` [PATCH 11/14] android/handsfree: Add support for new API for cops_cmd_cb Andrei Emeltchenko
2014-11-06  8:32 ` [PATCH 12/14] android/handsfree: Add support for new API for clcc_cmd_cb Andrei Emeltchenko
2014-11-06  8:32 ` [PATCH 13/14] android/handsfree: Add support for new API for unknown_at_cmd_cb Andrei Emeltchenko
2014-11-06  8:32 ` Andrei Emeltchenko [this message]
2014-11-06 11:42 ` [PATCH 00/14] 2nd part of handsfree Android 5.0 adaptation code Szymon Janc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415262729-12573-15-git-send-email-Andrei.Emeltchenko.news@gmail.com \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox