From: Arman Uguray <armansito@chromium.org>
To: linux-bluetooth@vger.kernel.org
Cc: Arman Uguray <armansito@chromium.org>
Subject: [PATCH BlueZ 2/8] shared/gatt-db: Add helper to get service handles.
Date: Fri, 28 Nov 2014 09:49:16 -0800 [thread overview]
Message-ID: <1417196962-3876-3-git-send-email-armansito@chromium.org> (raw)
In-Reply-To: <1417196962-3876-1-git-send-email-armansito@chromium.org>
This patch adds gatt_db_service_get_handles which is an internal helper
to obtain service handles from a gatt_db_service directly.
---
src/shared/gatt-db.c | 35 ++++++++++++++++++-----------------
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/src/shared/gatt-db.c b/src/shared/gatt-db.c
index 30fa4df..b210376 100644
--- a/src/shared/gatt-db.c
+++ b/src/shared/gatt-db.c
@@ -317,6 +317,18 @@ bool gatt_db_clear(struct gatt_db *db)
return true;
}
+static void gatt_db_service_get_handles(const struct gatt_db_service *service,
+ uint16_t *start_handle,
+ uint16_t *end_handle)
+{
+ if (start_handle)
+ *start_handle = service->attributes[0]->handle;
+
+ if (end_handle)
+ *end_handle = service->attributes[0]->handle +
+ service->num_handles - 1;
+}
+
struct clear_range {
uint16_t start, end;
};
@@ -327,8 +339,7 @@ static bool match_range(const void *a, const void *b)
const struct clear_range *range = b;
uint16_t svc_start, svc_end;
- svc_start = service->attributes[0]->handle;
- svc_end = service->attributes[0]->handle + service->num_handles - 1;
+ gatt_db_service_get_handles(service, &svc_start, &svc_end);
return svc_start <= range->end && svc_end >= range->start;
}
@@ -366,8 +377,7 @@ static void search_for_insert_loc(void *data, void *user_data)
if (loc_data->done)
return;
- cur_start = service->attributes[0]->handle;
- cur_end = service->attributes[0]->handle + service->num_handles - 1;
+ gatt_db_service_get_handles(service, &cur_start, &cur_end);
/* Abort if the requested range overlaps with an existing service. */
if ((loc_data->start >= cur_start && loc_data->start <= cur_end) ||
@@ -1038,8 +1048,8 @@ bool gatt_db_attribute_get_service_uuid(struct gatt_db_attribute *attrib,
}
bool gatt_db_attribute_get_service_handles(struct gatt_db_attribute *attrib,
- uint16_t *start_handle,
- uint16_t *end_handle)
+ uint16_t *start_handle,
+ uint16_t *end_handle)
{
struct gatt_db_service *service;
@@ -1048,12 +1058,7 @@ bool gatt_db_attribute_get_service_handles(struct gatt_db_attribute *attrib,
service = attrib->service;
- if (start_handle)
- *start_handle = service->attributes[0]->handle;
-
- if (end_handle)
- *end_handle = service->attributes[0]->handle +
- service->num_handles - 1;
+ gatt_db_service_get_handles(service, start_handle, end_handle);
return true;
}
@@ -1073,11 +1078,7 @@ bool gatt_db_attribute_get_service_data(struct gatt_db_attribute *attrib,
service = attrib->service;
decl = service->attributes[0];
- if (start_handle)
- *start_handle = decl->handle;
-
- if (end_handle)
- *end_handle = decl->handle + service->num_handles - 1;
+ gatt_db_service_get_handles(service, start_handle, end_handle);
if (primary)
*primary = bt_uuid_cmp(&decl->uuid, &secondary_service_uuid);
--
2.2.0.rc0.207.ga3a616c
next prev parent reply other threads:[~2014-11-28 17:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 17:49 [PATCH BlueZ 0/8] shared/gatt: Use gatt-db for client role Arman Uguray
2014-11-28 17:49 ` [PATCH BlueZ 1/8] shared/gatt-db: Fix bug in maximum handle check Arman Uguray
2014-11-28 17:49 ` Arman Uguray [this message]
2014-11-28 17:49 ` [PATCH BlueZ 3/8] shared/gatt-client: Store services in gatt_db Arman Uguray
2014-12-01 9:45 ` Luiz Augusto von Dentz
2014-12-01 14:50 ` Arman Uguray
2014-12-01 16:02 ` Luiz Augusto von Dentz
2014-12-01 16:37 ` Arman Uguray
2014-12-01 17:19 ` Marcel Holtmann
2014-12-01 17:57 ` Arman Uguray
2014-12-02 10:46 ` Luiz Augusto von Dentz
2014-12-02 15:12 ` Luiz Augusto von Dentz
2014-12-02 19:35 ` Arman Uguray
2014-12-03 0:15 ` Arman Uguray
2014-11-28 17:49 ` [PATCH BlueZ 4/8] shared/gatt-client: Use gatt_db in bt_gatt_register_notify Arman Uguray
2014-11-28 17:49 ` [PATCH BlueZ 5/8] tools/btgatt-server: Add the "services" command Arman Uguray
2014-11-28 17:49 ` [PATCH BlueZ 6/8] tools/btgatt-client: Use gatt-db instead of iterators Arman Uguray
2014-11-28 17:49 ` [PATCH BlueZ 7/8] unit/test-gatt: Use gatt-db for CLIENT tests Arman Uguray
2014-11-28 17:49 ` [PATCH BlueZ 8/8] shared/gatt-client: Remove GATT structs and iterators Arman Uguray
2014-12-01 9:49 ` [PATCH BlueZ 0/8] shared/gatt: Use gatt-db for client role Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417196962-3876-3-git-send-email-armansito@chromium.org \
--to=armansito@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox