linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
	Xinming Hu <huxm@marvell.com>, Cathy Luo <cluo@marvell.com>,
	Avinash Patil <patila@marvell.com>
Subject: Re: [PATCH v4 2/2] Bluetooth: btmrvl add firmware dump support
Date: Fri, 12 Dec 2014 12:30:18 +0100	[thread overview]
Message-ID: <1418383818.2470.17.camel@sipsolutions.net> (raw)
In-Reply-To: <1416825653-32530-2-git-send-email-akarwar@marvell.com>

On Mon, 2014-11-24 at 02:40 -0800, Amitkumar Karwar wrote:
> From: Xinming Hu <huxm@marvell.com>
> 
> This patch adds firmware dump support for marvell
> bluetooth chipset. Currently only SD8897 is supported.
> This is implemented based on dev_coredump, a new mechnism
> introduced in kernel 3.18rc3
> 
> Firmware dump can be trigger by
> echo 1 > /sys/kernel/debug/bluetooth/hci*/config/fw_dump
> and when the dump operation is completed, data can be read by
> cat /sys/class/devcoredump/devcd*/data

If anyone still cares - this looks fine to me from devcoredump usage.

Personally I would've picked a binary format, but the devcoredump
framework is intentionally payload agnostic.

johannes

  parent reply	other threads:[~2014-12-12 11:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 10:40 [PATCH 1/2] Bluetooth: btmrvl: remove extra newline character Amitkumar Karwar
2014-11-24 10:40 ` [PATCH v4 2/2] Bluetooth: btmrvl add firmware dump support Amitkumar Karwar
2014-12-03 16:37   ` Marcel Holtmann
2014-12-12 11:30   ` Johannes Berg [this message]
2014-12-03 16:36 ` [PATCH 1/2] Bluetooth: btmrvl: remove extra newline character Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418383818.2470.17.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=akarwar@marvell.com \
    --cc=cluo@marvell.com \
    --cc=huxm@marvell.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=patila@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).