From: Bastien Nocera <hadess@hadess.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: bluetooth: Add hci_h4p driver
Date: Sun, 14 Dec 2014 14:18:39 +0100 [thread overview]
Message-ID: <1418563119.3172.35.camel@hadess.net> (raw)
In-Reply-To: <20141214104031.GA30692@amd>
On Sun, 2014-12-14 at 11:40 +0100, Pavel Machek wrote:
> On Sun 2014-12-14 00:30:13, Marcel Holtmann wrote:
> > Hi Pavel,
> >
> > > Add hci_h4p bluetooth driver to staging tree. This device is used
> > > for example on Nokia N900 cell phone.
> > >
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > Thanks-to: Sebastian Reichel <sre@debian.org>
> > > Thanks-to: Joe Perches <joe@perches.com>
> > >
> > > ---
> > >
> > >
> > > I'd prefer to resurect the driver in staging/ in order not to lose
> > > history, but Marcel wanted to treat it as new submission, so I'm doing
> > > that.
> >
> > that history is in linux.git now for all times. No need to repeat it. I rather not play around with that again. Lets get a minimal driver merged so we can give people something to improve.
> >
>
> We will merge minimum version. Still I'd like complete history for
> credits and bisect and easy ability to diff original and minimum
> version.
FWIW, I found that developing the driver outside of the main kernel tree
for merge is the best way to keep a history that's not too interesting
in the kernel tree.
Something like:
https://github.com/hadess/gt9xx
will allow small reversible commits, make it easy to branch for testing
(say a bug crops up, create a branch, fix the bug, get somebody to test
it, merge to master, and copy/paste the files to the upstream git tree
for inclusion).
Of course, in your case you might need to create a backport for the
whole bluetooth sub-system, as it uses internal API, which makes it
harder. But it's still viable for large cleanups, and pre-merge changes
while keeping history.
next prev parent reply other threads:[~2014-12-14 13:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-13 22:37 bluetooth: Add hci_h4p driver Pavel Machek
2014-12-13 23:30 ` Marcel Holtmann
2014-12-13 23:51 ` Pavel Machek
2014-12-14 0:07 ` Marcel Holtmann
2014-12-14 9:47 ` Pavel Machek
2014-12-14 10:40 ` Pavel Machek
2014-12-14 13:18 ` Bastien Nocera [this message]
2014-12-14 11:16 ` Pavel Machek
2014-12-14 19:21 ` Pavel Machek
2014-12-14 20:28 ` Marcel Holtmann
2014-12-14 22:41 ` Pavel Machek
2014-12-14 21:52 ` Pavel Machek
2014-12-15 10:01 ` Oliver Neukum
2014-12-18 19:31 ` Pavel Machek
2014-12-18 20:10 ` Pavel Machek
2014-12-15 12:10 ` Marcel Holtmann
2014-12-19 9:50 ` Pavel Machek
2014-12-19 9:58 ` Marcel Holtmann
2014-12-20 15:48 ` Pavel Machek
2014-12-20 23:39 ` Marcel Holtmann
2014-12-20 20:23 ` [PATCH] " Pavel Machek
2014-12-20 20:43 ` Paul Bolle
2014-12-20 23:35 ` Marcel Holtmann
2014-12-23 12:00 ` Pavel Machek
2014-12-23 12:41 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418563119.3172.35.camel@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).