From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cyrus@holtmann.org>
From: Szymon Janc <szymon.janc@tieto.com>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC] build: Enable -Wformat -Wformat-security in maintainer mode
Date: Fri, 02 Jan 2015 18:03:18 +0100
Message-ID: <1420224076.KRR1t0OsX3@leonov>
In-Reply-To: <1419857362-23502-1-git-send-email-szymon.janc@tieto.com>
References: <1419857362-23502-1-git-send-email-szymon.janc@tieto.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

On Monday 29 of December 2014 13:49:22 Szymon Janc wrote:
> __attribute__((format(printf))) doesn't seem to catch missing format
> string in function call ie.
> 
> char *p = "foo";
> 
> printf(p);
> vs
> printf("%s", p);
> 
> Enabling -Wformat -Wformat-security warns in such case.
> ---
> 
> This should allow to early catch bugs like those fixed in
> patch "Add missing format specifiers in src/error.c" sent by
> Mariusz.
> 
>  acinclude.m4 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/acinclude.m4 b/acinclude.m4
> index 960d54c..bc39c6d 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -21,6 +21,7 @@ AC_DEFUN([COMPILER_FLAGS], [
>  		with_cflags="$with_cflags -Wredundant-decls"
>  		with_cflags="$with_cflags -Wcast-align"
>  		with_cflags="$with_cflags -Wswitch-enum"
> +		with_cflags="$with_cflags -Wformat -Wformat-security"
>  		with_cflags="$with_cflags -DG_DISABLE_DEPRECATED"
>  		with_cflags="$with_cflags -
DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_28"
>  		with_cflags="$with_cflags -
DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_28"


Applied.

-- 
BR
Szymon Janc