From: Gowtham Anandha Babu <gowtham.ab@samsung.com>
To: linux-bluetooth@vger.kernel.org
Cc: bharat.panda@samsung.com, cpgs@samsung.com,
Gowtham Anandha Babu <gowtham.ab@samsung.com>
Subject: [PATCH v1 3/3] tools/hciattach_ath3k: Remove dead code warnings
Date: Tue, 27 Jan 2015 14:23:20 +0530 [thread overview]
Message-ID: <1422348800-5668-4-git-send-email-gowtham.ab@samsung.com> (raw)
In-Reply-To: <1422348800-5668-1-git-send-email-gowtham.ab@samsung.com>
tools/hciattach_ath3k.c:848:3: warning: Value stored to 'err' is never read
err = 0;
^ ~
tools/hciattach_ath3k.c:852:3: warning: Value stored to 'err' is never read
err = 0;
^ ~
---
tools/hciattach_ath3k.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/tools/hciattach_ath3k.c b/tools/hciattach_ath3k.c
index 23208c6..d31732e 100644
--- a/tools/hciattach_ath3k.c
+++ b/tools/hciattach_ath3k.c
@@ -840,17 +840,8 @@ static int ath_ps_download(int fd)
goto download_cmplete;
}
- /*
- * It is not necessary that Patch file be available,
- * continue with PS Operations if patch file is not available.
- */
- if (patch_file[0] == '\0')
- err = 0;
-
stream = fopen(patch_file, "r");
- if (!stream)
- err = 0;
- else {
+ if(stream) {
patch_count = ps_patch_download(fd, stream);
fclose(stream);
--
1.9.1
next prev parent reply other threads:[~2015-01-27 8:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 8:53 [PATCH v1 0/3] Fix memory issues and trivial code cleaup Gowtham Anandha Babu
2015-01-27 8:53 ` [PATCH v1 1/3] shared/gatt-helpers: Fix usage of freed memory Gowtham Anandha Babu
2015-01-28 13:07 ` Luiz Augusto von Dentz
2015-01-28 14:18 ` Gowtham Anandha Babu
2015-01-28 14:20 ` Luiz Augusto von Dentz
2015-01-27 8:53 ` [PATCH v1 2/3] shared/gatt-client: " Gowtham Anandha Babu
2015-01-27 8:53 ` Gowtham Anandha Babu [this message]
2015-01-27 13:39 ` [PATCH v1 0/3] Fix memory issues and trivial code cleaup Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422348800-5668-4-git-send-email-gowtham.ab@samsung.com \
--to=gowtham.ab@samsung.com \
--cc=bharat.panda@samsung.com \
--cc=cpgs@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox