From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [RFC BlueZ 2/3] shared/gatt-client: Add support for signed write
Date: Fri, 20 Feb 2015 12:38:29 +0200 [thread overview]
Message-ID: <1424428710-8907-2-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1424428710-8907-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
src/shared/gatt-client.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c
index ac2692f..a966dd0 100644
--- a/src/shared/gatt-client.c
+++ b/src/shared/gatt-client.c
@@ -2129,10 +2129,6 @@ unsigned int bt_gatt_client_write_without_response(
if (!client)
return 0;
- /* TODO: Support this once bt_att_send supports signed writes. */
- if (signed_write)
- return 0;
-
req = request_create(client);
if (!req)
return 0;
@@ -2140,9 +2136,10 @@ unsigned int bt_gatt_client_write_without_response(
put_le16(value_handle, pdu);
memcpy(pdu + 2, value, length);
- req->att_id = bt_att_send(client->att, BT_ATT_OP_WRITE_CMD,
- pdu, sizeof(pdu),
- NULL, NULL, NULL);
+ req->att_id = bt_att_send(client->att,
+ signed_write ? BT_ATT_OP_SIGNED_WRITE_CMD :
+ BT_ATT_OP_WRITE_CMD, pdu, sizeof(pdu),
+ NULL, NULL, NULL);
if (!req->att_id) {
request_unref(req);
return 0;
--
2.1.0
next prev parent reply other threads:[~2015-02-20 10:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 10:38 [RFC BlueZ 1/3] shared/att.c: Add signing key support Luiz Augusto von Dentz
2015-02-20 10:38 ` Luiz Augusto von Dentz [this message]
2015-02-20 10:38 ` [RFC BlueZ 3/3] tools/btgatt-client: Add signed write support Luiz Augusto von Dentz
2015-02-20 10:55 ` Johan Hedberg
2015-02-20 11:47 ` Luiz Augusto von Dentz
2015-02-20 12:04 ` [RFC BlueZ 1/3] shared/att.c: Add signing key support Lukasz Rymanowski
2015-02-20 13:25 ` Luiz Augusto von Dentz
2015-02-20 13:40 ` Luiz Augusto von Dentz
2015-02-20 13:44 ` Lukasz Rymanowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424428710-8907-2-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox