linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth:deltele some unuseful comments
@ 2015-04-10  8:45 DingXiang
  2015-04-10 16:21 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: DingXiang @ 2015-04-10  8:45 UTC (permalink / raw)
  To: linux-bluetooth, kernel-janitors; +Cc: dingxiang

From: dingxiang <dingxiang@huawei.com>

I think the comments are used to debug, and we don't need them in
mainline code

Signed-off-by: DingXiang <dingxiang@huawei.com>
---
 drivers/bluetooth/bt3c_cs.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/bluetooth/bt3c_cs.c b/drivers/bluetooth/bt3c_cs.c
index 4f7e8d4..6de97b3 100644
--- a/drivers/bluetooth/bt3c_cs.c
+++ b/drivers/bluetooth/bt3c_cs.c
@@ -227,7 +227,6 @@ static void bt3c_receive(struct bt3c_info *info)
 	iobase = info->p_dev->resource[0]->start;
 
 	avail = bt3c_read(iobase, 0x7006);
-	//printk("bt3c_cs: receiving %d bytes\n", avail);
 
 	bt3c_address(iobase, 0x7480);
 	while (size < avail) {
@@ -250,7 +249,6 @@ static void bt3c_receive(struct bt3c_info *info)
 
 			bt_cb(info->rx_skb)->pkt_type = inb(iobase + DATA_L);
 			inb(iobase + DATA_H);
-			//printk("bt3c: PACKET_TYPE=%02x\n", bt_cb(info->rx_skb)->pkt_type);
 
 			switch (bt_cb(info->rx_skb)->pkt_type) {
 
@@ -364,7 +362,6 @@ static irqreturn_t bt3c_interrupt(int irq, void *dev_inst)
 			if (stat & 0x0001)
 				bt3c_receive(info);
 			if (stat & 0x0002) {
-				//BT_ERR("Ack (stat=0x%04x)", stat);
 				clear_bit(XMIT_SENDING, &(info->tx_state));
 				bt3c_write_wakeup(info);
 			}
-- 
1.7.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth:deltele some unuseful comments
  2015-04-10  8:45 [PATCH] Bluetooth:deltele some unuseful comments DingXiang
@ 2015-04-10 16:21 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2015-04-10 16:21 UTC (permalink / raw)
  To: DingXiang; +Cc: linux-bluetooth, kernel-janitors

Hi Ding,

> I think the comments are used to debug, and we don't need them in
> mainline code
> 
> Signed-off-by: DingXiang <dingxiang@huawei.com>
> ---
> drivers/bluetooth/bt3c_cs.c |    3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-10 16:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-10  8:45 [PATCH] Bluetooth:deltele some unuseful comments DingXiang
2015-04-10 16:21 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).