From: Szymon Janc <szymon.janc@gmail.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org,
Anderson Lizardo <anderson.lizardo@openbossa.org>
Subject: Re: regression in sdp lib
Date: Tue, 25 Jun 2013 21:54:29 +0200 [thread overview]
Message-ID: <1429697.uq0A3eL4HE@athlon> (raw)
In-Reply-To: <20130625184848.GA29741@x220.P-661HNU-F1>
Hi Johan,
On Tuesday 25 June 2013 21:48:48 Johan Hedberg wrote:
> Hi Szymon,
>
> On Fri, Jun 21, 2013, Szymon Janc wrote:
> > commit 'lib: Add range check for SDP_SVC_ATTR_RSP/SDP_SVC_SEARCH_ATTR_RSP'
> > 1796f00e846561af broke sdp with Nokia BH217 headset.
>
> Since there evidently wasn't any progress on this issue and we want to
> get a new release out (due to also another severe regression) I've gone
> ahead and simply reverted the original patch. Nevertheless, I'm still
> looking forward to seeing a proper fix for this issue.
Maybe it would be enough to verify size only if there is no continuation?
/* Valid range for rsp_count is 0x0002-0xFFFF */
- if (rsp_count < 0x0002) {
+ if (t->rsp_concat_buf.data_size == 0 && rsp_count < 0x0002) {
t->err = EPROTO;
Seems to be working for me but I'm that much familiar sdp code..
--
Szymon K. Janc
szymon.janc@gmail.com
next prev parent reply other threads:[~2013-06-25 19:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 20:09 regression in sdp lib Szymon Janc
2013-06-21 22:38 ` Anderson Lizardo
2013-06-22 13:52 ` Szymon Janc
2013-06-25 18:48 ` Johan Hedberg
2013-06-25 19:54 ` Szymon Janc [this message]
2013-06-25 20:21 ` Anderson Lizardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429697.uq0A3eL4HE@athlon \
--to=szymon.janc@gmail.com \
--cc=anderson.lizardo@openbossa.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox