Linux bluetooth development
 help / color / mirror / Atom feed
From: Anupam Roy <anupam.r@samsung.com>
To: vinicius.gomes@intel.com
Cc: linux-bluetooth@vger.kernel.org, sachin.dev@samsung.com
Subject: [PATCH RESEND] tools/obex-client-tool.c: Fix memory leak in obex-client-tool
Date: Fri, 24 Jul 2015 11:01:46 -0400	[thread overview]
Message-ID: <1437750106-16261-1-git-send-email-anupam.r@samsung.com> (raw)

GOptionContext object should be freed in case socket connection
fails and program execution is terminated.

==12968== HEAP SUMMARY:
==12968==     in use at exit: 2,895 bytes in 14 blocks
==12968==   total heap usage: 23 allocs, 9 frees, 36,669 bytes allocated
==12968==
==12968== 624 (88 direct, 536 indirect) bytes in 1 blocks are definitely lost in loss record 13 of 14
==12968==    at 0x4C2CC70: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==12968==    by 0x4E85668: g_malloc0 (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
==12968==    by 0x4E89D22: g_option_context_new (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
==12968==    by 0x402BAB: main (obex-client-tool.c:428)
==12968==
==12968== LEAK SUMMARY:
==12968==    definitely lost: 88 bytes in 1 blocks
==12968==    indirectly lost: 536 bytes in 2 blocks
==12968==      possibly lost: 0 bytes in 0 blocks
==12968==    still reachable: 2,271 bytes in 11 blocks
==12968==         suppressed: 0 bytes in 0 blocks
---
 tools/obex-client-tool.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/obex-client-tool.c b/tools/obex-client-tool.c
index 4f931f6..d0ba8a6 100644
--- a/tools/obex-client-tool.c
+++ b/tools/obex-client-tool.c
@@ -432,6 +432,7 @@ int main(int argc, char *argv[])
 	if (err != NULL) {
 		g_printerr("%s\n", err->message);
 		g_error_free(err);
+		g_option_context_free(context);
 		exit(EXIT_FAILURE);
 	}
 
@@ -445,8 +446,10 @@ int main(int argc, char *argv[])
 	else
 		io = unix_connect(transport);
 
-	if (io == NULL)
+	if (io == NULL) {
+		g_option_context_free(context);
 		exit(EXIT_FAILURE);
+	}
 
 	memset(&sa, 0, sizeof(sa));
 	sa.sa_handler = sig_term;
-- 
1.9.1


             reply	other threads:[~2015-07-24 15:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 15:01 Anupam Roy [this message]
2015-07-27  7:22 ` [PATCH RESEND] tools/obex-client-tool.c: Fix memory leak in obex-client-tool Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437750106-16261-1-git-send-email-anupam.r@samsung.com \
    --to=anupam.r@samsung.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=sachin.dev@samsung.com \
    --cc=vinicius.gomes@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox