* btle 6lowpan races
@ 2015-07-29 12:38 Alexander Aring
2015-07-29 12:51 ` Jukka Rissanen
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Aring @ 2015-07-29 12:38 UTC (permalink / raw)
To: jukka.rissanen; +Cc: linux-bluetooth, kernel
Hi Jukka,
I think it's bad for filling data for btle lowpan private data at point [0].
This is called after register_netdev and the rtnl_lock isn't hold after
calling "register_netdev" anymore which ends in a possible interface up
between register and filling lowpan_dev information. The result would be
that lowpan_dev is readed somewhere where it isn't filled.
The solution would be simple move the filling between alloc and register of
netdev.
If you like I can prepare patches for that.
Any thoughts on this?
- Alex
[0] http://lxr.free-electrons.com/source/net/bluetooth/6lowpan.c#L874
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: btle 6lowpan races
2015-07-29 12:38 btle 6lowpan races Alexander Aring
@ 2015-07-29 12:51 ` Jukka Rissanen
0 siblings, 0 replies; 2+ messages in thread
From: Jukka Rissanen @ 2015-07-29 12:51 UTC (permalink / raw)
To: Alexander Aring; +Cc: linux-bluetooth, kernel
Hi Alex,
On ke, 2015-07-29 at 14:38 +0200, Alexander Aring wrote:
> Hi Jukka,
>
> I think it's bad for filling data for btle lowpan private data at point [0].
> This is called after register_netdev and the rtnl_lock isn't hold after
> calling "register_netdev" anymore which ends in a possible interface up
> between register and filling lowpan_dev information. The result would be
> that lowpan_dev is readed somewhere where it isn't filled.
>
> The solution would be simple move the filling between alloc and register of
> netdev.
Yes, that makes sense.
>
> If you like I can prepare patches for that.
Sure, patches are welcome.
>
> Any thoughts on this?
>
> - Alex
>
> [0] http://lxr.free-electrons.com/source/net/bluetooth/6lowpan.c#L874
Cheers,
Jukka
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-29 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-29 12:38 btle 6lowpan races Alexander Aring
2015-07-29 12:51 ` Jukka Rissanen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).