From: Szymon Janc <szymon.janc@tieto.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/4] android/gatt: Trivial whitespace fixes
Date: Fri, 11 Apr 2014 15:43:48 +0200 [thread overview]
Message-ID: <1438281.X3cEQKDDM8@uw000953> (raw)
In-Reply-To: <1397140494-4023-1-git-send-email-jakub.tyszkowski@tieto.com>
Hi Jakub,
On Thursday 10 of April 2014 16:34:51 Jakub Tyszkowski wrote:
> ---
> android/gatt.c | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index a7a7204..ff19767 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -745,8 +745,8 @@ connect:
> return;
>
> /* We are ok to perform connect now. Stop discovery
> - * and once it is stopped continue with creating ACL
> - */
> + * and once it is stopped continue with creating ACL
> + */
> bt_le_discovery_stop(bt_le_discovery_stop_cb);
> }
>
> @@ -792,7 +792,7 @@ done:
>
> queue_foreach(dev->clients, client_disconnect_notify, dev);
>
> - /* Reset conn_id and put on disconnected list.*/
> + /* Reset conn_id and put on disconnected list. */
> put_device_on_disc_list(dev);
>
> return FALSE;
> @@ -875,7 +875,7 @@ reply:
> if (scanning)
> bt_le_discovery_start(le_device_found_handler);
>
> - /*FIXME: What to do if discovery won't start here. */
> + /* FIXME: What to do if discovery won't start here. */
> }
>
> static int connect_le(struct gatt_device *dev)
> @@ -895,11 +895,10 @@ static int connect_le(struct gatt_device *dev)
>
> DBG("Connection attempt to: %s", addr);
>
> - /*TODO: If we are bonded then we should use higier sec level */
> + /* TODO: If we are bonded then we should use higier sec level */
> sec_level = BT_IO_SEC_LOW;
>
> - /*
> - * This connection will help us catch any PDUs that comes before
> + /* This connection will help us catch any PDUs that comes before
> * pairing finishes
> */
> io = bt_io_connect(connect_cb, dev, NULL, &gerr,
> @@ -996,7 +995,7 @@ static void bt_le_discovery_stop_cb(void)
> {
> DBG("");
>
> - /* Check now if there is any device ready to connect*/
> + /* Check now if there is any device ready to connect */
> if (connect_next_dev() < 0)
> bt_le_discovery_start(le_device_found_handler);
> }
> @@ -1061,9 +1060,9 @@ static void handle_client_connect(const void *buf, uint16_t len)
> android2bdaddr(&cmd->bdaddr, &addr);
>
> /* We do support many clients for one device connection so lets check
> - * If device is connected or in connecting state just update list of
> - * clients
> - */
> + * If device is connected or in connecting state just update list of
> + * clients
> + */
> dev = find_device(&addr);
> if (dev) {
> /* Remeber to send dummy notification event if we area
> @@ -1127,13 +1126,13 @@ reply:
> ipc_send_rsp(hal_ipc, HAL_SERVICE_ID_GATT, HAL_OP_GATT_CLIENT_CONNECT,
> status);
>
> - /* If there is an error here we should make sure dev is out.*/
> + /* If there is an error here we should make sure dev is out. */
> if ((status != HAL_STATUS_SUCCESS) && dev) {
> destroy_device(dev);
> return;
> }
>
> - /* Send dummy notification since ACL is already up*/
> + /* Send dummy notification since ACL is already up */
> if (send_notify) {
> struct hal_ev_gatt_client_connect ev;
>
>
All patches in this set are now applied, thanks.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-04-11 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 14:34 [PATCH 1/4] android/gatt: Trivial whitespace fixes Jakub Tyszkowski
2014-04-10 14:34 ` [PATCH 2/4] android/gatt: Fix sending device to (dis)connect callback Jakub Tyszkowski
2014-04-10 14:34 ` [PATCH 3/4] android/gatt: Add Client's refresh function call Jakub Tyszkowski
2014-04-10 14:34 ` [PATCH 4/4] android/gatt: Add cache check in Clients caching callbacks Jakub Tyszkowski
2014-04-11 13:43 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438281.X3cEQKDDM8@uw000953 \
--to=szymon.janc@tieto.com \
--cc=jakub.tyszkowski@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox