From: Johan Hedberg <johan.hedberg@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 6/6] Bluetooth: 6lowpan: Remove unnecessary chan_get() function
Date: Tue, 6 Oct 2015 13:03:24 +0300 [thread overview]
Message-ID: <1444125804-15577-7-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1444125804-15577-1-git-send-email-johan.hedberg@gmail.com>
From: Johan Hedberg <johan.hedberg@intel.com>
The chan_get() function just adds unnecessary indirection to calling
the chan_create() call. The only added value it gives is the chan->ops
assignment, but that can equally well be done in the calling code.
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---
net/bluetooth/6lowpan.c | 20 +++++---------------
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index e20b97297a15..9363f05275f4 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -1051,28 +1051,17 @@ static inline __u8 bdaddr_type(__u8 type)
return BDADDR_LE_RANDOM;
}
-static struct l2cap_chan *chan_get(void)
-{
- struct l2cap_chan *chan;
-
- chan = chan_create();
- if (!chan)
- return NULL;
-
- chan->ops = &bt_6lowpan_chan_ops;
-
- return chan;
-}
-
static int bt_6lowpan_connect(bdaddr_t *addr, u8 dst_type)
{
struct l2cap_chan *chan;
int err;
- chan = chan_get();
+ chan = chan_create();
if (!chan)
return -EINVAL;
+ chan->ops = &bt_6lowpan_chan_ops;
+
err = l2cap_chan_connect(chan, cpu_to_le16(L2CAP_PSM_IPSP), 0,
addr, dst_type);
@@ -1109,10 +1098,11 @@ static struct l2cap_chan *bt_6lowpan_listen(void)
if (!enable_6lowpan)
return NULL;
- chan = chan_get();
+ chan = chan_create();
if (!chan)
return NULL;
+ chan->ops = &bt_6lowpan_chan_ops;
chan->state = BT_LISTEN;
chan->src_type = BDADDR_LE_PUBLIC;
--
2.4.3
next prev parent reply other threads:[~2015-10-06 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 10:03 [PATCH 0/6] Bluetooth: 6lowpan cleanups Johan Hedberg
2015-10-06 10:03 ` [PATCH 1/6] Bluetooth: 6lowpan: Fix imtu & omtu values Johan Hedberg
2015-10-06 10:03 ` [PATCH 2/6] Bluetooth: 6lowpan: Remove redundant (and incorrect) MPS assignments Johan Hedberg
2015-10-06 10:03 ` [PATCH 3/6] Bluetooth: 6lowpan: Remove redundant BT_CONNECTED assignment Johan Hedberg
2015-10-06 10:03 ` [PATCH 4/6] Bluetooth: 6lowpan: Remove unnecessary chan_open() function Johan Hedberg
2015-10-06 10:03 ` [PATCH 5/6] Bluetooth: 6lowpan: Rename confusing 'pchan' variables Johan Hedberg
2015-10-06 10:03 ` Johan Hedberg [this message]
2015-10-06 10:25 ` [PATCH 0/6] Bluetooth: 6lowpan cleanups Jukka Rissanen
2015-10-08 8:46 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444125804-15577-7-git-send-email-johan.hedberg@gmail.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).