* [PATCH BlueZ] core/gatt-client: Fix printing errors if experimental is disabled
@ 2016-02-29 15:28 Luiz Augusto von Dentz
2016-03-02 10:53 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2016-02-29 15:28 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
If experimental flag is not set don't attempt to create any objects since
it will cause error that are hard to guess such as bellow:
bluetoothd[6539]: Unable to register GATT service with handle 0x000c for device
---
src/gatt-client.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/gatt-client.c b/src/gatt-client.c
index b4ca3b6..dd76a36 100644
--- a/src/gatt-client.c
+++ b/src/gatt-client.c
@@ -1688,6 +1688,12 @@ static void export_service(struct gatt_db_attribute *attr, void *user_data)
static void create_services(struct btd_gatt_client *client)
{
+ /* Don't attempt to create any objects if experimental is disabled */
+ if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL)) {
+ info("GATT service objects disabled");
+ return;
+ }
+
DBG("Exporting objects for GATT services: %s", client->devaddr);
gatt_db_foreach_service(client->db, NULL, export_service, client);
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BlueZ] core/gatt-client: Fix printing errors if experimental is disabled
2016-02-29 15:28 [PATCH BlueZ] core/gatt-client: Fix printing errors if experimental is disabled Luiz Augusto von Dentz
@ 2016-03-02 10:53 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2016-03-02 10:53 UTC (permalink / raw)
To: linux-bluetooth@vger.kernel.org
Hi,
On Mon, Feb 29, 2016 at 5:28 PM, Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> If experimental flag is not set don't attempt to create any objects since
> it will cause error that are hard to guess such as bellow:
>
> bluetoothd[6539]: Unable to register GATT service with handle 0x000c for device
> ---
> src/gatt-client.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/gatt-client.c b/src/gatt-client.c
> index b4ca3b6..dd76a36 100644
> --- a/src/gatt-client.c
> +++ b/src/gatt-client.c
> @@ -1688,6 +1688,12 @@ static void export_service(struct gatt_db_attribute *attr, void *user_data)
>
> static void create_services(struct btd_gatt_client *client)
> {
> + /* Don't attempt to create any objects if experimental is disabled */
> + if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL)) {
> + info("GATT service objects disabled");
> + return;
> + }
> +
> DBG("Exporting objects for GATT services: %s", client->devaddr);
>
> gatt_db_foreach_service(client->db, NULL, export_service, client);
> --
> 2.5.0
Applied.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-02 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-29 15:28 [PATCH BlueZ] core/gatt-client: Fix printing errors if experimental is disabled Luiz Augusto von Dentz
2016-03-02 10:53 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).