From: Ivan Shapovalov <intelfx@intelfx.name>
To: linux-bluetooth@vger.kernel.org
Cc: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Subject: Fallout from commit 70fdb77 "audio/avrcp: Fix not always requesting capabilities"
Date: Thu, 31 Mar 2016 20:00:53 +0300 [thread overview]
Message-ID: <1459443653.22297.7.camel@intelfx.name> (raw)
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
Hello,
The commit 70fdb7 "audio/avrcp: Fix not always requesting capabilities"
introduced a series of bugs where the code thinks that session-
>controller->player cannot be NULL, but in fact it can be so. The first
one was fixed in 177d27 "audio/avrcp: Fix crash when connecting to controllers", but there remain multiple code pathes via avrcp_register_notification() -> callback -> avrcp_handle_event() -> avrcp_{status,track,playback_pos,settings,uids}_changed() where session->controller->player may be dereferenced.
I'm unsure how to fix that properly (either not register notifications,
or ignore specific callbacks if s->c->player is NULL), so I'm just
reporting this.
Ref.: https://bugs.archlinux.org/task/48644
--
Ivan Shapovalov / intelfx /
Please Cc: me on replies as I'm not subscribed to the list.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next reply other threads:[~2016-03-31 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 17:00 Ivan Shapovalov [this message]
2016-04-01 9:31 ` Fallout from commit 70fdb77 "audio/avrcp: Fix not always requesting capabilities" Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459443653.22297.7.camel@intelfx.name \
--to=intelfx@intelfx.name \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).