linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jukka Rissanen <jukka.rissanen@linux.intel.com>
To: Alexander Aring <aar@pengutronix.de>,
	Patrik Flykt <Patrik.Flykt@linux.intel.com>,
	Linux Bluetooth <linux-bluetooth@vger.kernel.org>
Cc: linux-wpan@vger.kernel.org, kernel@pengutronix.de
Subject: Re: current btle 6lowpan issues
Date: Mon, 20 Jun 2016 10:07:23 +0300	[thread overview]
Message-ID: <1466406443.31678.121.camel@linux.intel.com> (raw)
In-Reply-To: <594d0734-87d2-2cbf-716b-2c3b0ac97ac6@pengutronix.de>

Hi Alex,

On Thu, 2016-06-16 at 23:38 +0200, Alexander Aring wrote:
> Hi,
> 
> On 06/16/2016 03:41 PM, Patrik Flykt wrote:
> > 
> > On Thu, 2016-06-16 at 13:00 +0300, Jukka Rissanen wrote:
> > > 
> > > Yes you are right that there are issues. Fortunately the bt0 is
> > > currently a point-to-point link in which case ND is not really
> > > done
> > > and everything kind of "works" ok.
> > > 
> > > I added Patrik to cc: as he has been working to fix the issues
> > > but
> > > the patches are not yet ready. Perhaps we could combine the
> > > efforts
> > > here.
> > I had some patches that make BTLE interfaces non-point-to-point.
> > Let me
> > check that they can be applied on the latest bluetooth-next and
> > that
> > they still compile after a few months of sitting on an old version.
> > Then let's hope they also work as expected...
> > 
> With non-point-to-point you mean to remove the IFF_POINTOPOINT flag
> in
> net_device? Yes this should be removed.

Yes, agreed.

> 
> But I think this is one of the smallest issue in btle 6lowpan.
> 
> What means "ND is not really done", does that means you will not see
> btle neighbours by doing "ip -6 neigh" for your bt interface?

Yes.

> 
> I don't believe that and I think no matter if you set IFF_POINTOPOINT
> or
> not, the IPv6 stack will mostly ignore such flag. I did a grep and it
> seems the SIT stuff sets this flag and IPv6 stack does something with
> that, but not in case of ARPHRD_6LOWPAN, it's for ARPHRD_SIT only. So
> I
> think this flag makes some "peer" address in "ip a" handling instead
> of
> showing broadcast address. But nobody will make special handling in
> IPv6
> or btle 6lowpan if this flag is set.
> 
> What I mean is, you can set this flag on or off but it will don't
> change
> any behaviour.

Unfortunately there is a different behaviour. If the interface has
IFF_POINTTOPOINT, then kernel will not send neighbor discovery messages
to that link. I have not checked the kernel code where exactly that is
enforced but I have looked the wireshark output and there are no ND's
sent if bt0 is p-to-p link. If the flag is removed, the device starts
to send ND's to that interface.

Removing the IFF_POINTTOPPOINT is not enough as the MAC address will be
wrongly set in that case as you have noticed.


Cheers,
Jukka


  reply	other threads:[~2016-06-20  7:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15 18:02 current btle 6lowpan issues Alexander Aring
2016-06-16 10:00 ` Jukka Rissanen
2016-06-16 13:41   ` Patrik Flykt
2016-06-16 21:38     ` Alexander Aring
2016-06-20  7:07       ` Jukka Rissanen [this message]
2016-07-05 13:13   ` Michael Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466406443.31678.121.camel@linux.intel.com \
    --to=jukka.rissanen@linux.intel.com \
    --cc=Patrik.Flykt@linux.intel.com \
    --cc=aar@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).