* [PATCH] Bluetooth: btmrvl: reset is_suspending flag in failure path
@ 2016-07-15 10:48 Amitkumar Karwar
0 siblings, 0 replies; 3+ messages in thread
From: Amitkumar Karwar @ 2016-07-15 10:48 UTC (permalink / raw)
To: linux-bluetooth; +Cc: marcel, Minghsiu.Tsai, Amitkumar Karwar
is_suspending flag remains on when host sleep fails to enable. Data
path is unnecessarily blocked after this. This patch ensures to
reset the flag in failure path.
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
---
drivers/bluetooth/btmrvl_sdio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index b7c3928..d02f2c1 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -1625,6 +1625,7 @@ static int btmrvl_sdio_suspend(struct device *dev)
if (priv->adapter->hs_state != HS_ACTIVATED) {
if (btmrvl_enable_hs(priv)) {
BT_ERR("HS not actived, suspend failed!");
+ priv->adapter->is_suspending = false;
return -EBUSY;
}
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] Bluetooth: btmrvl: reset is_suspending flag in failure path
@ 2016-07-15 10:50 Amitkumar Karwar
2016-07-18 8:13 ` Marcel Holtmann
0 siblings, 1 reply; 3+ messages in thread
From: Amitkumar Karwar @ 2016-07-15 10:50 UTC (permalink / raw)
To: linux-bluetooth; +Cc: linux-kernel, marcel, Minghsiu.Tsai, Amitkumar Karwar
is_suspending flag remains on when host sleep fails to enable. Data
path is unnecessarily blocked after this. This patch ensures to
reset the flag in failure path.
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
---
drivers/bluetooth/btmrvl_sdio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index b7c3928..d02f2c1 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -1625,6 +1625,7 @@ static int btmrvl_sdio_suspend(struct device *dev)
if (priv->adapter->hs_state != HS_ACTIVATED) {
if (btmrvl_enable_hs(priv)) {
BT_ERR("HS not actived, suspend failed!");
+ priv->adapter->is_suspending = false;
return -EBUSY;
}
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: btmrvl: reset is_suspending flag in failure path
2016-07-15 10:50 Amitkumar Karwar
@ 2016-07-18 8:13 ` Marcel Holtmann
0 siblings, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2016-07-18 8:13 UTC (permalink / raw)
To: Amitkumar Karwar; +Cc: open list:BLUETOOTH DRIVERS, linux-kernel, Minghsiu.Tsai
Hi Amitkumar,
> is_suspending flag remains on when host sleep fails to enable. Data
> path is unnecessarily blocked after this. This patch ensures to
> reset the flag in failure path.
>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> ---
> drivers/bluetooth/btmrvl_sdio.c | 1 +
> 1 file changed, 1 insertion(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-18 8:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-15 10:48 [PATCH] Bluetooth: btmrvl: reset is_suspending flag in failure path Amitkumar Karwar
-- strict thread matches above, loose matches on Subject: below --
2016-07-15 10:50 Amitkumar Karwar
2016-07-18 8:13 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).