linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ] core/advertising: Fix not adding local name and appearance flags
Date: Fri, 22 Jul 2016 16:56:25 +0300	[thread overview]
Message-ID: <1469195785-8907-1-git-send-email-luiz.dentz@gmail.com> (raw)

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

If the advertisement is cause the connectable flag to be set add local
name and appearance so the scan response is generated properly as the
remote may attempt connect/pair these information shall be made available
as well.
---
 src/advertising.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/advertising.c b/src/advertising.c
index d2019de..52b536d 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -473,7 +473,8 @@ static DBusMessage *refresh_advertisement(struct advertisement *ad)
 	DBG("Refreshing advertisement: %s", ad->path);
 
 	if (ad->type == AD_TYPE_PERIPHERAL)
-		flags = MGMT_ADV_FLAG_CONNECTABLE | MGMT_ADV_FLAG_DISCOV;
+		flags = MGMT_ADV_FLAG_CONNECTABLE | MGMT_ADV_FLAG_DISCOV |
+			MGMT_ADV_FLAG_APPEARANCE | MGMT_ADV_FLAG_LOCAL_NAME;
 
 	if (ad->include_tx_power)
 		flags |= MGMT_ADV_FLAG_TX_POWER;
-- 
2.7.4


             reply	other threads:[~2016-07-22 13:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-22 13:56 Luiz Augusto von Dentz [this message]
2016-08-01 11:49 ` [PATCH BlueZ] core/advertising: Fix not adding local name and appearance flags Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469195785-8907-1-git-send-email-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).