* [PATCH BlueZ] core/advertising: Fix not adding local name and appearance flags
@ 2016-07-22 13:56 Luiz Augusto von Dentz
2016-08-01 11:49 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2016-07-22 13:56 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
If the advertisement is cause the connectable flag to be set add local
name and appearance so the scan response is generated properly as the
remote may attempt connect/pair these information shall be made available
as well.
---
src/advertising.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/advertising.c b/src/advertising.c
index d2019de..52b536d 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -473,7 +473,8 @@ static DBusMessage *refresh_advertisement(struct advertisement *ad)
DBG("Refreshing advertisement: %s", ad->path);
if (ad->type == AD_TYPE_PERIPHERAL)
- flags = MGMT_ADV_FLAG_CONNECTABLE | MGMT_ADV_FLAG_DISCOV;
+ flags = MGMT_ADV_FLAG_CONNECTABLE | MGMT_ADV_FLAG_DISCOV |
+ MGMT_ADV_FLAG_APPEARANCE | MGMT_ADV_FLAG_LOCAL_NAME;
if (ad->include_tx_power)
flags |= MGMT_ADV_FLAG_TX_POWER;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH BlueZ] core/advertising: Fix not adding local name and appearance flags
2016-07-22 13:56 [PATCH BlueZ] core/advertising: Fix not adding local name and appearance flags Luiz Augusto von Dentz
@ 2016-08-01 11:49 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2016-08-01 11:49 UTC (permalink / raw)
To: linux-bluetooth@vger.kernel.org
Hi,
On Fri, Jul 22, 2016 at 4:56 PM, Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> If the advertisement is cause the connectable flag to be set add local
> name and appearance so the scan response is generated properly as the
> remote may attempt connect/pair these information shall be made available
> as well.
> ---
> src/advertising.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/advertising.c b/src/advertising.c
> index d2019de..52b536d 100644
> --- a/src/advertising.c
> +++ b/src/advertising.c
> @@ -473,7 +473,8 @@ static DBusMessage *refresh_advertisement(struct advertisement *ad)
> DBG("Refreshing advertisement: %s", ad->path);
>
> if (ad->type == AD_TYPE_PERIPHERAL)
> - flags = MGMT_ADV_FLAG_CONNECTABLE | MGMT_ADV_FLAG_DISCOV;
> + flags = MGMT_ADV_FLAG_CONNECTABLE | MGMT_ADV_FLAG_DISCOV |
> + MGMT_ADV_FLAG_APPEARANCE | MGMT_ADV_FLAG_LOCAL_NAME;
>
> if (ad->include_tx_power)
> flags |= MGMT_ADV_FLAG_TX_POWER;
> --
> 2.7.4
This does not work since the kernel does not even check those flags,
instead it seems to expect the scan data to come directly from
userspace.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-01 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-22 13:56 [PATCH BlueZ] core/advertising: Fix not adding local name and appearance flags Luiz Augusto von Dentz
2016-08-01 11:49 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).