Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Mariusz Skamra <mariusz.skamra@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] android/handsfree: Fix SCO disconnection while dialing
Date: Fri, 20 Feb 2015 16:29:37 +0100	[thread overview]
Message-ID: <1474927.h0juZcpg0K@uw000953> (raw)
In-Reply-To: <1424427986-31620-2-git-send-email-mariusz.skamra@tieto.com>

Hi Mariusz,

On Friday 20 of February 2015 11:26:26 Mariusz Skamra wrote:
> If we decide to hang up while dialing or alerting, SCO needs to be closed.
> Fixes: TC_AG_TCA_BV_04_C
> ---
>  android/handsfree.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/android/handsfree.c b/android/handsfree.c
> index f4d6cf0..b0d8058 100644
> --- a/android/handsfree.c
> +++ b/android/handsfree.c
> @@ -2403,6 +2403,10 @@ static void phone_state_idle(struct hf_device *dev, int num_active,
>  					num_held ? (num_active ? 1 : 2) : 0);
>  
>  		update_indicator(dev, IND_CALLSETUP, 0);
> +
> +		/* disconnect SCO if we hang up while dialing or alerting */
> +		if (num_active == 0 && num_held == 0)
> +			disconnect_sco(dev);
>  		break;
>  	case HAL_HANDSFREE_CALL_STATE_IDLE:
>  		if (dev->call_hanging_up) {
> 

This patch is now applied, thanks.

-- 
Best regards, 
Szymon Janc

  reply	other threads:[~2015-02-20 15:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20 10:26 [PATCH 1/2] android/handsfree: Fix not sending proper call hold status Mariusz Skamra
2015-02-20 10:26 ` [PATCH 2/2] android/handsfree: Fix SCO disconnection while dialing Mariusz Skamra
2015-02-20 15:29   ` Szymon Janc [this message]
2015-02-20 12:29 ` [PATCH 1/2] android/handsfree: Fix not sending proper call hold status Szymon Janc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474927.h0juZcpg0K@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mariusz.skamra@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox