From: "Michał Narajowski" <michal.narajowski@codecoup.pl>
To: linux-bluetooth@vger.kernel.org
Cc: "Michał Narajowski" <michal.narajowski@codecoup.pl>
Subject: [PATCH BlueZ 3/4] tools/mgmt-tester: Fix not updating scan rsp when adv off
Date: Wed, 5 Oct 2016 12:27:16 +0200 [thread overview]
Message-ID: <1475663237-3070-3-git-send-email-michal.narajowski@codecoup.pl> (raw)
In-Reply-To: <1475663237-3070-1-git-send-email-michal.narajowski@codecoup.pl>
Scan response data should not be updated unless there
is an advertising instance. So set scan rsp data hci commands
wont be fired on setup.
---
tools/mgmt-tester.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
index bc770b7..feef5f1 100644
--- a/tools/mgmt-tester.c
+++ b/tools/mgmt-tester.c
@@ -6221,9 +6221,6 @@ static const uint8_t set_scan_rsp_data_name[] = {
static const struct generic_data add_advertising_name_in_scrsp = {
.setup_settings = settings_powered_le,
- .setup_expect_hci_command = BT_HCI_CMD_LE_SET_SCAN_RSP_DATA,
- .setup_expect_hci_param = set_scan_rsp_data_name,
- .setup_expect_hci_len = sizeof(set_scan_rsp_data_name),
.setup_send_opcode = MGMT_OP_SET_LOCAL_NAME,
.setup_send_param = set_local_name_param,
.setup_send_len = sizeof(set_local_name_param),
@@ -6253,9 +6250,6 @@ static const uint8_t set_scan_rsp_data_empty[] = {
static const struct generic_data add_advertising_empty_scrsp = {
.setup_settings = settings_powered_le,
- .setup_expect_hci_command = BT_HCI_CMD_LE_SET_SCAN_RSP_DATA,
- .setup_expect_hci_param = set_scan_rsp_data_name,
- .setup_expect_hci_len = sizeof(set_scan_rsp_data_name),
.setup_send_opcode = MGMT_OP_SET_LOCAL_NAME,
.setup_send_param = set_local_name_param,
.setup_send_len = sizeof(set_local_name_param),
@@ -6265,9 +6259,6 @@ static const struct generic_data add_advertising_empty_scrsp = {
.expect_status = MGMT_STATUS_SUCCESS,
.expect_param = advertising_instance1_param,
.expect_len = sizeof(advertising_instance1_param),
- .expect_hci_command = BT_HCI_CMD_LE_SET_SCAN_RSP_DATA,
- .expect_hci_param = set_scan_rsp_data_empty,
- .expect_hci_len = sizeof(set_scan_rsp_data_empty),
};
static const uint8_t add_advertising_param_name_data_scrsp[] = {
@@ -6300,9 +6291,6 @@ static const uint8_t set_scan_rsp_data_name_data[] = {
static const struct generic_data add_advertising_name_data_scrsp = {
.setup_settings = settings_powered_le,
- .setup_expect_hci_command = BT_HCI_CMD_LE_SET_SCAN_RSP_DATA,
- .setup_expect_hci_param = set_scan_rsp_data_name,
- .setup_expect_hci_len = sizeof(set_scan_rsp_data_name),
.setup_send_opcode = MGMT_OP_SET_LOCAL_NAME,
.setup_send_param = set_local_name_param,
.setup_send_len = sizeof(set_local_name_param),
@@ -6349,9 +6337,6 @@ static const uint8_t set_scan_rsp_data_shortened_name[] = {
static const struct generic_data add_advertising_dta_name_scrsp = {
.setup_settings = settings_powered_le,
- .setup_expect_hci_command = BT_HCI_CMD_LE_SET_SCAN_RSP_DATA,
- .setup_expect_hci_param = set_scan_rsp_data_name,
- .setup_expect_hci_len = sizeof(set_scan_rsp_data_name),
.setup_send_opcode = MGMT_OP_SET_LOCAL_NAME,
.setup_send_param = set_local_name_param,
.setup_send_len = sizeof(set_local_name_param),
@@ -6392,9 +6377,6 @@ static const uint8_t set_scan_rsp_data_short_name[] = {
static const struct generic_data add_advertising_dta_short_name_scrsp = {
.setup_settings = settings_powered_le,
- .setup_expect_hci_command = BT_HCI_CMD_LE_SET_SCAN_RSP_DATA,
- .setup_expect_hci_param = set_scan_rsp_data_name,
- .setup_expect_hci_len = sizeof(set_scan_rsp_data_name),
.setup_send_opcode = MGMT_OP_SET_LOCAL_NAME,
.setup_send_param = &set_local_name_cp,
.setup_send_len = sizeof(set_local_name_cp),
--
2.7.4
next prev parent reply other threads:[~2016-10-05 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 10:27 [PATCH BlueZ 1/4] tools/mgmt-tester: Fix setup commands and conditions handling Michał Narajowski
2016-10-05 10:27 ` [PATCH BlueZ 2/4] tools/mgmt-tester: Fix add local name to scan rsp Michał Narajowski
2016-10-05 10:27 ` Michał Narajowski [this message]
2016-10-05 10:27 ` [PATCH BlueZ 4/4] tools/mgmt-tester: Test appearance in default scan rsp data Michał Narajowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475663237-3070-3-git-send-email-michal.narajowski@codecoup.pl \
--to=michal.narajowski@codecoup.pl \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).