From: Joe Perches <joe@perches.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Marcel Holtmann <marcel@holtmann.org>,
trivial@kernel.org, "Gustavo F. Padovan" <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel
Date: Wed, 05 Oct 2016 12:15:34 -0700 [thread overview]
Message-ID: <1475694934.1941.1.camel@perches.com> (raw)
In-Reply-To: <20161005191103.GA25972@amd>
On Wed, 2016-10-05 at 21:11 +0200, Pavel Machek wrote:
> On Wed 2016-10-05 10:53:16, Joe Perches wrote:
> > On Wed, 2016-10-05 at 13:14 +0200, Marcel Holtmann wrote:
> > > Hi Pavel,
> > >
> > > > bluetooth.h is not part of user API, so __ variants are not neccessary
> > > > here.
> > > >
> > > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > >
> > > > diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> >
> > []
> > > > struct bt_skb_cb {
> > > > - __u8 pkt_type;
> > > > - __u8 force_active;
> > > > - __u16 expect;
> > > > - __u8 incoming:1;
> > > > + u8 pkt_type;
> > > > + u8 force_active;
> > > > + u16 expect;
> > > > + u8 incoming:1;
> > > > union {
> > > > struct l2cap_ctrl l2cap;
> > > > struct hci_ctrl hci;
> >
> >
> > trivia:
> >
> > It's generally faster to use bool instead of u8 foo:1;
>
> Ok, but I'm not changing that in this patch.
> (And actually, bool will take a lot more memory, right?)
No worries, and bool is the same size as u8.
>
next prev parent reply other threads:[~2016-10-05 19:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 8:56 [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel Pavel Machek
2016-10-05 11:14 ` Marcel Holtmann
2016-10-05 17:53 ` Joe Perches
2016-10-05 19:11 ` Pavel Machek
2016-10-05 19:15 ` Joe Perches [this message]
2016-10-05 22:13 ` Pavel Machek
2016-10-05 22:28 ` Joe Perches
2016-10-06 7:02 ` Pavel Machek
2016-10-06 7:07 ` Joe Perches
2016-10-06 8:38 ` Johan Hedberg
2016-10-06 9:41 ` David Laight
2016-10-06 11:38 ` Joe Perches
2016-10-06 13:00 ` David Laight
2016-10-06 15:41 ` Joe Perches
2016-10-05 20:51 ` [PATCHv2] " Pavel Machek
2016-10-05 21:54 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475694934.1941.1.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).