linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Łukasz Rymanowski" <lukasz.rymanowski@codecoup.pl>
To: linux-bluetooth@vger.kernel.org
Cc: "Łukasz Rymanowski" <lukasz.rymanowski@codecoup.pl>
Subject: [PATCH BlueZ 2/2] shared/gatt-helpers: Fix find by type response handling
Date: Mon, 17 Oct 2016 12:02:32 +0200	[thread overview]
Message-ID: <1476698552-8030-2-git-send-email-lukasz.rymanowski@codecoup.pl> (raw)
In-Reply-To: <1476698552-8030-1-git-send-email-lukasz.rymanowski@codecoup.pl>

Due to regression from

db24bf0 shared/gatt-helper: Consolidate error checking,

procedure Discover Primary Services by Service UUID, can succeed
only when last response is Error Response with ATTRIBUTE_NOT_FOUND
error code.

With this patch it also succeed when Find By Type response contains
service which is already in a required search range.

It is verified with unit test /TP/GAD/CL/BV-02-C-1-alternative
---
 src/shared/gatt-helpers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/gatt-helpers.c b/src/shared/gatt-helpers.c
index a0a5b26..6b39bb1 100644
--- a/src/shared/gatt-helpers.c
+++ b/src/shared/gatt-helpers.c
@@ -797,7 +797,7 @@ static void find_by_type_val_cb(uint8_t opcode, const void *pdu,
 		goto done;
 	}
 
-	success = false;
+	success = true;
 
 done:
 	discovery_op_complete(op, success, att_ecode);
-- 
2.7.4


  reply	other threads:[~2016-10-17 10:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 10:02 [PATCH BlueZ 1/2] unit/test-gatt: Add /TP/GAD/CL/BV-02-C-1-alternative Łukasz Rymanowski
2016-10-17 10:02 ` Łukasz Rymanowski [this message]
2016-10-18 10:59 ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476698552-8030-2-git-send-email-lukasz.rymanowski@codecoup.pl \
    --to=lukasz.rymanowski@codecoup.pl \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).